New issue
Advanced search Search tips

Issue 891629 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Lars: Apply input DSP to fix audio_AudioBasicExternalMicrophone test

Project Member Reported by cychiang@chromium.org, Oct 3

Issue description

Labels: Merge-Request-70 M-70
Status: Started (was: Untriaged)
Request merge to M70. It fixed the audio_AudioBasicExternalMicrophone test failure. Thanks.
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 8

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: We are only 7 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 9

Labels: merge-merged-release-R70-11021.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/840ad89983279ddf7743e68da370d5806082eae8

commit 840ad89983279ddf7743e68da370d5806082eae8
Author: Yu-Hsuan Hsu <yuhsuan@google.com>
Date: Tue Oct 09 02:05:12 2018

Lars: Enable DC filter in DSP for external mic

We need to suppress DC to pass audio_AudioBasicExternalMicrophone test.

BUG= chromium:891629 
TEST=Pass audio_AudioBasicExternalMicrophone test on Lars reliably.

Change-Id: Iab81540d9e4eb3b74b196ad46aab364bf9ff823a
Previous-Reviewed-on: https://chromium-review.googlesource.com/1264357
(cherry picked from commit b73cd0930a911a4ed0d3c000c4b740601bbe1de9)
Reviewed-on: https://chromium-review.googlesource.com/c/1270375
Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>
Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org>
Tested-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>

[modify] https://crrev.com/840ad89983279ddf7743e68da370d5806082eae8/overlay-lars/chromeos-base/chromeos-bsp-lars/files/audio-config/cras-config/LARS/dsp.ini
[rename] https://crrev.com/840ad89983279ddf7743e68da370d5806082eae8/overlay-lars/chromeos-base/chromeos-bsp-lars/chromeos-bsp-lars-0.0.1-r21.ebuild
[modify] https://crrev.com/840ad89983279ddf7743e68da370d5806082eae8/overlay-lars/chromeos-base/chromeos-bsp-lars/files/audio-config/ucm-config/sklnau8825max/HiFi.conf
[modify] https://crrev.com/840ad89983279ddf7743e68da370d5806082eae8/overlay-lars/chromeos-base/chromeos-bsp-lars/files/audio-config/cras-config/LILI/dsp.ini

Labels: -Merge-Approved-70
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Test is passing.
https://screenshot.googleplex.com/yYAxmkw8LzJ

Sign in to add a comment