New issue
Advanced search Search tips

Issue 891613 link

Starred by 2 users

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 872339



Sign in to add a comment

[ozone/headless] Implement PlatfromScreen for headless backend.

Project Member Reported by msi...@igalia.com, Oct 3

Issue description

The headless uses a DesktopScreenOzone now. Implement the PlatformScreen available on the Ozone level and start using aura::ScreenOzone instead.
 
Blocking: 872339
Cc: msi...@igalia.com rjkroege@chromium.org s...@chromium.org
Labels: Proj-Headless Proj-Ozone
Labels: -Proj-Headless Hotlist-GoodFirstBug
Components: UI Internals>PlatformIntegration

Comment 4 Deleted

I would like to take this issue if no one working on this.
Owner: jdragon....@gmail.com
Sure thing. I can review.
jdragon.bae@, please add me into the CC as well.
Cc: -s...@chromium.org je_julie.kim@chromium.org sky@chromium.org
I'm trying to fix this issue. And I think PlatformScreen should be implemented in ui/ozone/platform/headless/headless_screen.h like Wayland[1], Scenic[2]. 
However, I'm not sure if it's the good start point.
Could you give me some guidance or reference? Thanks :)

[1]https://chromium-review.googlesource.com/c/chromium/src/+/1236268
[2]https://chromium-review.googlesource.com/c/chromium/src/+/1162426



 
yes. There should be a file headless_screen.{h,cc}

You should create a subclass of PlatformScreen and implement its methods, write appropriate unit tests etc. The wayland implementation is a mostly reasonable starting point. 

The PlatformScreen class comments do not provide a great deal of assistance to implementors. It is perhaps desirable to start by expanding that with some comments? That would be a comparatively easy first CL that would require you to understand what a PlatformScreen implementation actually needs to do.
Labels: Hotlist-DesktopUIToolingRequired Hotlist-DesktopUIChecked

Sign in to add a comment