ResetAfterFirstConfigInfo VDA unittest triggers DCHECK() on Hana |
||
Issue description./video_decode_accelerator_unittest --single-process-tests --disable_rendering --test_video_data=test-25fps.vp9:320:240:250:250:35:150:12 ... [11866:11943:1003/140932.497860:76288873277:FATAL:v4l2_video_decode_accelerator.cc(442)] Check failed: output_queue_->FreeBuffersCount() == 0u (17 vs. 0) #0 0x0000073d1174 base::debug::StackTrace::StackTrace() #1 0x0000072c13c4 base::debug::StackTrace::StackTrace() #2 0x0000072dc548 logging::LogMessage::~LogMessage() #3 0x000007288274 media::V4L2VideoDecodeAccelerator::AssignPictureBuffersTask() #4 0x0000062e8a4c _ZN4base8internal13FunctorTraitsIMN5media8AudioLogEFvRKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEEEvE6InvokeISE_PS3_JSC_EEEvT_OT0_DpOT1_ #5 0x0000062e89c8 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN5media8AudioLogEFvRKNSt3__112basic_stringIcNS6_11char_traitsIcEENS6_9allocatorIcEEEEEJPS5_SE_EEEvOT_DpOT0_ #6 0x00000729b102 _ZN4base8internal7InvokerINS0_9BindStateIMN5media26V4L2VideoDecodeAcceleratorEFvRKNSt3__16vectorINS3_13PictureBufferENS5_9allocatorIS7_EEEEEJNS0_17UnretainedWrapperIS4_EESA_EEEFvvEE7RunImplIRKSE_RKNS5_5tupleIJSG_SA_EEEJLj0ELj1EEEEvOT_OT0_NS5_16integer_sequenceIjJXspT1_EEEE #7 0x00000729b040 _ZN4base8internal7InvokerINS0_9BindStateIMN5media26V4L2VideoDecodeAcceleratorEFvRKNSt3__16vectorINS3_13PictureBufferENS5_9allocatorIS7_EEEEEJNS0_17UnretainedWrapperIS4_EESA_EEEFvvEE3RunEPNS0_13BindStateBaseE #8 0x000006237194 _ZNO4base12OnceCallbackIFvvEE3RunEv #9 0x000007405b86 base::debug::TaskAnnotator::RunTask() #10 0x0000072e6796 base::MessageLoop::RunTask() #11 0x0000072e69d0 base::MessageLoop::DeferOrRunPendingTask() #12 0x0000072e6cf4 base::MessageLoop::DoWork() #13 0x0000072ec596 base::MessagePumpDefault::Run() #14 0x0000072e62b0 base::MessageLoop::Run() #15 0x00000732a496 base::RunLoop::Run() #16 0x0000073750aa base::Thread::Run() #17 0x000007375798 base::Thread::ThreadMain() #18 0x0000073ea40a base::(anonymous namespace)::ThreadFunc()
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81023e3b363fee7229b5078d116ac451b9f72624 commit 81023e3b363fee7229b5078d116ac451b9f72624 Author: Alexandre Courbot <acourbot@chromium.org> Date: Wed Oct 10 11:05:51 2018 media/gpu/v4l2vda: remove faulty DCHECK() At the end of AssignPictureBuffersTask(), we used to check that the number of free output buffers was equal to zero, as it was assumed that they would be awaiting for their EGL image to be assigned. However, if in allocate mode and rendering is disabled, ImportBufferForPictureTask(), which is directly called from AssignPictureBuffersTask(), can allow the buffers to return to the free list. In this case the number of free buffers will be higher then zero at the end of the loop. Remove this DCHECK() as it is clearly checking for an invalid condition. BUG= 891600 TEST=Checked that VDA unittest was passing on Hana with rendering both enabled and disabled. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I87f3e10656eaa5e15de9a806e7175fb0078ed9cc Reviewed-on: https://chromium-review.googlesource.com/c/1258685 Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Pawel Osciak <posciak@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#598281} [modify] https://crrev.com/81023e3b363fee7229b5078d116ac451b9f72624/media/gpu/v4l2/v4l2_video_decode_accelerator.cc
,
Oct 11
CL has landed, closing as fixed. |
||
►
Sign in to add a comment |
||
Comment 1 by acourbot@chromium.org
, Oct 3Labels: videoshortlist
Owner: acourbot@chromium.org
Status: Started (was: Untriaged)