New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 891587 link

Starred by 1 user
Status: Fixed
Owner:
hychao@chromium.org
Closed: Oct 11
Cc:
█ geohsu@chromium.org
cychiang@chromium.org
chromeos-audio-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

CRAS: ignore software node gain when APM is engaged

Project Member Reported by hychao@chromium.org, Oct 3 
When a CRAS stream enables system AEC, the whole capture path will have two APM instances: one in CRAS and one in browser.
And we would like to avoid any gain between these 2 APM.

Change in CRAS is required to disable CRAS's node gain for streams that uses APM. APM's own gain functions should be used instead.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/ab9af3b88c1692b5e3a722bde0dbe908f4a473ea

commit ab9af3b88c1692b5e3a722bde0dbe908f4a473ea
Author: Hsin-Yu Chao <hychao@google.com>
Date: Wed Oct 10 04:14:19 2018

CRAS: dev_io - Don't appy software gain if APM is used

When CRAS APM is used for a stream, it wants full control to
the input gain, and doesn't want additional gain between CRAS
and browser APM.

BUG= chromium:891587 
TEST=Manual test with tuned APM config, measure between
CRAS and browser's aecdump.

Change-Id: I0bc1dbc523d173a50746b6fe24b34eaaa5c757f2
Reviewed-on: https://chromium-review.googlesource.com/1267581
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/ab9af3b88c1692b5e3a722bde0dbe908f4a473ea/cras/src/server/dev_io.c

Comment 2 by hychao@chromium.org, Oct 10

Cc: geohsu@chromium.org
Labels: Merge-Request-70
Status: Started (was: Assigned)
Request M-70 merge, since experimental native AEC is enabled on M70, since 70.0.3538.53
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 10

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: We are only 5 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by geo...@google.com, Oct 10

Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 11

Labels: merge-merged-release-R70-11021.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/189f3f3520c03ef1598c0b62755b883e38ed42ae

commit 189f3f3520c03ef1598c0b62755b883e38ed42ae
Author: Hsin-Yu Chao <hychao@google.com>
Date: Thu Oct 11 02:59:27 2018

CRAS: dev_io - Don't appy software gain if APM is used

When CRAS APM is used for a stream, it wants full control to
the input gain, and doesn't want additional gain between CRAS
and browser APM.

BUG= chromium:891587 
TEST=Manual test with tuned APM config, measure between
CRAS and browser's aecdump.

Change-Id: I0bc1dbc523d173a50746b6fe24b34eaaa5c757f2
Reviewed-on: https://chromium-review.googlesource.com/1267581
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
(cherry picked from commit ab9af3b88c1692b5e3a722bde0dbe908f4a473ea)
Reviewed-on: https://chromium-review.googlesource.com/c/1275506
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Commit-Queue: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/189f3f3520c03ef1598c0b62755b883e38ed42ae/cras/src/server/dev_io.c

Comment 6 by hychao@chromium.org, Oct 11

Labels: -Merge-Approved-70
Status: Fixed (was: Started)
►

Sign in to add a comment