New issue
Advanced search Search tips

Issue 891577 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Print Preview: collapsed items are in the tab order

Project Member Reported by rbpotter@chromium.org, Oct 3

Issue description

Chrome Version: ToT

Items in the collapsed more settings can still be tabbed to.
 
Cc: nyerramilli@chromium.org rbpotter@chromium.org rbasuvula@chromium.org pbomm...@chromium.org
 Issue 891659  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45494050d3c3cd2c17cbffb2b32fc0c288da283d

commit 45494050d3c3cd2c17cbffb2b32fc0c288da283d
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Oct 03 19:51:16 2018

Print Preview Refresh: Address UI review comments

(1) Increase line height for destinations items
(2) Remove "Advanced" label for printer options button
(3) Remove margin on paper-icon-button so Print with system dialog...
    does not wrap (for English + normal font size)
(4) Change pages per sheet label to sentence case
(5) Fix alignment of "Destinations" label with printer names,
    particularly for printers that do not have a status/location
    displayed.

Bug:  891375 ,  891378 ,  891379 ,  891395 ,  891577 
Change-Id: I13fbcd167e2e9ee513ef056ce5c9e471248dd3d8
Reviewed-on: https://chromium-review.googlesource.com/c/1257370
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596332}
[modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/app/printing_strings.grdp
[modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/advanced_options_settings.html
[modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/destination_list.html
[modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/destination_list.js
[modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/destination_list_item.html
[modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/link_container.html
[modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/print_preview_shared_css.html
[modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/settings_section.html

Labels: TE-Verified-71.0.3570.0 TE-Verified-M71
Updated:
Re-tested above issue (with steps mentioned in 891659) on Windows (7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTS) machines using latest Canary build #71.0.3570.0 and the issue is fixed. Hence adding TE-Verified labels. 

Kindly review an attached screen-cast for reference.

Thank you..!
Fixed_Behaviour.mp4
527 KB View Download
Status: Verified (was: Started)

Sign in to add a comment