viz_browser_tests failing on multiple builders |
||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of loyso@google.com viz_browser_tests failing on multiple builders Builders failed on: - linux-chromeos-dbg: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg - Linux Chromium OS ASan LSan Tests (1): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29 failures: ConsumerDeviceStatusCollectorTimeLimitEnabledTest.ReportingActivityTimesSleepTransistions ConsumerDeviceStatusCollectorTimeLimitEnabledTest.ActivityKeptInPref ConsumerDeviceStatusCollectorTimeLimitEnabledTest.ReportingActivityTimesIdleTransitions ConsumerDeviceStatusCollectorTimeLimitEnabledTest.ReportingActivityTimesSessionTransistions ConsumerDeviceStatusCollectorTimeLimitEnabledTest.ActivityNotWrittenToLocalState https://cs.chromium.org/chromium/src/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
,
Oct 3
,
Oct 3
,
Oct 3
,
Oct 3
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85d9eb647aa6e562d1dabe31a27c6a4126c3c186 commit 85d9eb647aa6e562d1dabe31a27c6a4126c3c186 Author: Alexey Baskakov <loyso@chromium.org> Date: Wed Oct 03 03:36:37 2018 Disable device_status_collector_browsertest.cc TBR=poromov@chromium.org TEST=none Bug: 891573 Change-Id: I3837b32e995ac6d7dd757ca70a0a8d16e6c7e2a6 Reviewed-on: https://chromium-review.googlesource.com/c/1257485 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#596111} [modify] https://crrev.com/85d9eb647aa6e562d1dabe31a27c6a4126c3c186/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
,
Oct 3
Issue 891447 has been merged into this issue.
,
Oct 3
Issue 891448 has been merged into this issue.
,
Oct 3
Issue 891449 has been merged into this issue.
,
Oct 3
Issue 891450 has been merged into this issue.
,
Oct 3
Issue 891451 has been merged into this issue.
,
Oct 3
(cc-ing their @google account since the @chromium has a last visit of > 30 days)
,
Oct 3
Removing from sheriff queue as test has now been disabled.
,
Oct 3
I have run the tests several times locally and they passed in all executions. I think the issue could be a result of a race condition between the write and read methods over the kChildScreenTimeMilliseconds pref. I am trying to ensure that the asserts performed on the test only happen after the write, but it is being difficult to test, because as I mentioned it is not failing locally.
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a09f6fd5ceeaf6bb606e19e1d9e6462e0d569702 commit a09f6fd5ceeaf6bb606e19e1d9e6462e0d569702 Author: Henrique Grandinetti <hgrandinetti@chromium.org> Date: Fri Oct 05 16:42:27 2018 Fix DeviceStatusCollector tests that were flaky. Some of the tests make assetions on pref values, but they were doing so without guarantees that the latest value were available. To solve the proble, I forced the pending values to be written to the prefs and moved the assertion to the callback that is invoked when this operation has finished. Bug: 891573 Change-Id: I76411e6d93f061b12af2144cc88e9339531dd3a0 Reviewed-on: https://chromium-review.googlesource.com/c/1261995 Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Reviewed-by: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#597165} [modify] https://crrev.com/a09f6fd5ceeaf6bb606e19e1d9e6462e0d569702/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
,
Oct 5
,
Oct 8
Reopening since the tests are still flaky: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29417 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933354636347205216/+/steps/single_process_mash_browser_tests/0/logs/ConsumerDeviceStatusCollectorTimeLimitEnabledTest.ReportingActivityTimesSleepTransistions/0
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8bca52f24d6dd3a58310f3ece21c3ce1804a2b65 commit 8bca52f24d6dd3a58310f3ece21c3ce1804a2b65 Author: Alexey Baskakov <loyso@chromium.org> Date: Mon Oct 08 02:30:05 2018 Disable device_status_collector_browsertest.cc Tests still flaky: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29417 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933354636347205216/+/steps/single_process_mash_browser_tests/0/logs/ConsumerDeviceStatusCollectorTimeLimitEnabledTest.ReportingActivityTimesSleepTransistions/0 TBR=poromov@chromium.org Bug: 891573 Change-Id: I9fd2b8b70d5d2483df3ed97d7d657e8cdc43ba3d Reviewed-on: https://chromium-review.googlesource.com/c/1267717 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#597472} [modify] https://crrev.com/8bca52f24d6dd3a58310f3ece21c3ce1804a2b65/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
,
Jan 10
Sergey, these tests were disabled last year, I submitted a fix but it didn't work, so they were disabled again. Now I am back to this investigation, because those are very important integration tests to Time Limit, and having them disabled is not a good idea. The problem is that I can't make them fail locally nor on the dry run. Also, the logs listed on this bug are no longer available, so I have no way to debug the issue. Do you have any suggestion in what could I do? |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by loyso@chromium.org
, Oct 3Labels: -Pri-2 Pri-1