New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 891568 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
User never visited
Closed: Dec 12
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

dragonegg-release build fails at SignerTest: Unexpected kernel parameters found

Project Member Reported by apronin@chromium.org, Oct 3

Issue description

dragonegg-release builds fails during SignerTest:

sed: -e expression #1, char 75: Invalid back reference
Unexpected kernel parameters found:
  earlyprintk=uart8250,mmio32,0xfe032000,115200n8 console=uart8250,mmio32,0xfe032000,115200n8 tpm_tis.force=0 
Debug output:
required_kparams=(
	'cros_secure'
	'dm_verity.error_behavior=3'
	'dm_verity.max_bios=-1'
	'dm_verity.dev_wait=1'
	'init=/sbin/init'
	'ro'
	'rootwait'
	'add_efi_memmap'
	'boot=local'
	'i915.modeset=1'
	'nmi_watchdog=panic,lapic'
	'noresume'
	'noswap'
	'tpm_tis.force=1'
	'tpm_tis.interrupts=0'
)
required_kparams_regex=(
	'root=/dev/dm-[0-1]'
	'kern_guid=\(PARTUUID=\)\?%U'
)
optional_kparams=(
	'console='
	'console=tty2'
	'cros_recovery'
	'disablevmx=off'
	'earlyprintk'
	'i8042.nomux=1'
	'idle=halt'
	'noinitrd'
	'oops=panic'
	'panic=-1'
	'panic=60'
	'quiet'
	'vt.global_cursor_default=0'
)
optional_kparams_regex=(
	'earlycon=[a-z0-9,]*'
	'gsmi.s0ix_logging_enable=[01]'
	'i915.alpha_support=[01]'
	'i915.enable_dbc=[01]'
	'i915.enable_dpcd_backlight=[01]'
	'i915.enable_execlists=[01]'
	'i915.enable_psr=[01]'
	'i915.preliminary_hw_support=[01]'
	'intel_idle.max_cstate=[0-9]'
	'intel_idle.slp_s0_check=[01YN]'
	'intel_idle.slp_s0_seed=[0-9]\+'
	'iwlwifi.remove_when_gone=[01]'
	'iTCO_vendor_support.vendorsupport=[0-9]'
	'kern_b_hash=[a-f0-9]*'
	'loglevel=[0-9]'
	'maxcpus=[0-9]\+'
	'ramoops.ecc=[0-9]\+'
	'usbcore.quirks=[a-z0-9]\+:[a-z0-9]\+:[a-m]\+'
)
required_dmparams=(
	''
)
required_dmparams_regex=(
	'vroot none ro,0 [1-9][0-9]\{6\} verity %U+1 %U+1  0 sha1 MAGIC_HASH'
	'vroot none ro,0 [1-9][0-9]\{6\} verity payload=%U+1 hashtree=%U+1 hashstart= alg=sha1 root_hexdigest=MAGIC_HASH'
	'vroot none ro,0 [1-9][0-9]\{6\} verity payload=%U+1 hashtree=%U+1 hashstart= alg=sha1 root_hexdigest=MAGIC_HASH salt=MAGIC_SALT'
	'1 vroot none ro 1,0 [1-9][0-9]\{6\} verity payload=%U+1 hashtree=%U+1 hashstart= alg=sha1 root_hexdigest=MAGIC_HASH salt=MAGIC_SALT'
	'2 vboot none ro 1,0 \(1768000\|2129920\|2545920\|2579200\) bootcache %U+1  MAGIC_HASH [0-9]\+ [0-9]\+ [0-9]\+, vroot none ro 1,0 [1-9][0-9]\{6\} verity payload=254:0 hashtree=254:0 hashstart= alg=sha1 root_hexdigest=MAGIC_HASH salt=MAGIC_SALT'
	'1 vroot none ro 1,0 [1-9][0-9]\{6\} verity payload=PARTUUID=%U/PARTNROFF=1 hashtree=PARTUUID=%U/PARTNROFF=1 hashstart= alg=sha1 root_hexdigest=MAGIC_HASH salt=MAGIC_SALT'
	'2 vboot none ro 1,0 \(1768000\|2129920\|2545920\|2579200\) bootcache PARTUUID=%U/PARTNROFF=1  MAGIC_HASH [0-9]\+ [0-9]\+ [0-9]\+, vroot none ro 1,0 [1-9][0-9]\{6\} verity payload=254:0 hashtree=254:0 hashstart= alg=sha1 root_hexdigest=MAGIC_HASH salt=MAGIC_SALT'
)
kparams='console= loglevel=7 init=/sbin/init cros_secure oops=panic panic=-1 root=/dev/dm-0 rootwait ro dm_verity.error_behavior=3 dm_verity.max_bios=-1 dm_verity.dev_wait=1 dm="1 vroot none ro 1,0 4710400 verity payload=PARTUUID=%U/PARTNROFF=1 hashtree=PARTUUID=%U/PARTNROFF=1 hashstart=4710400 alg=sha1 root_hexdigest=572353be2b88246388ef1ce9e6955b0703754243 salt=a334f46f30ec004383a93c0fcd835e688d2c85c2ab26b43eef1aa21335f572a8" noinitrd vt.global_cursor_default=0 kern_guid=%U add_efi_memmap boot=local noresume noswap i915.modeset=1 tpm_tis.force=1 tpm_tis.interrupts=0 nmi_watchdog=panic,lapic i915.alpha_support=1 ramoops.ecc=1 earlyprintk=uart8250,mmio32,0xfe032000,115200n8 console=uart8250,mmio32,0xfe032000,115200n8 tpm_tis.force=0 '
dmparams='1 vroot none ro 1,0 4710400 verity payload=PARTUUID=%U/PARTNROFF=1 hashtree=PARTUUID=%U/PARTNROFF=1 hashstart=4710400 alg=sha1 root_hexdigest=572353be2b88246388ef1ce9e6955b0703754243 salt=a334f46f30ec004383a93c0fcd835e688d2c85c2ab26b43eef1aa21335f572a8'
kparams_nodm='console= loglevel=7 init=/sbin/init cros_secure oops=panic panic=-1 root=/dev/dm-0 rootwait ro dm_verity.error_behavior=3 dm_verity.max_bios=-1 dm_verity.dev_wait=1  noinitrd vt.global_cursor_default=0 kern_guid=%U add_efi_memmap boot=local noresume noswap i915.modeset=1 tpm_tis.force=1 tpm_tis.interrupts=0 nmi_watchdog=panic,lapic i915.alpha_support=1 ramoops.ecc=1 earlyprintk=uart8250,mmio32,0xfe032000,115200n8 console=uart8250,mmio32,0xfe032000,115200n8 tpm_tis.force=0 '
mangled_dmparams='1 vroot none ro 1,0 4710400 verity payload=PARTUUID=%U/PARTNROFF=1 hashtree=PARTUUID=%U/PARTNROFF=1 hashstart=4710400 alg=sha1 root_hexdigest=MAGIC_HASH salt=MAGIC_SALT'
(actual error will be at the top of output)
ERROR   security_test_image: secure_kernelparams: test failed
INFO    security_test_image: Running ensure_not_ASAN.sh
ERROR   security_test_image: 1 tests failed
 
Looks like due to unexpected tpm_tis.force=0. There was a recent fix that changed 0 to 1 for dragonegg.
Owner: rajatja@chromium.org
Must be the result of https://crrev.com/c/1195763. 
Kernel options checks should be updated to allow tpm_tis.force=0
Components: OS>Kernel>TPM OS>Kernel
Cc: -briannorris@chromium.org
Labels: OS-Chrome
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/cros-signing/+/52b6867906f2eb2a430ed2492a35ba4ab69c0466

commit 52b6867906f2eb2a430ed2492a35ba4ab69c0466
Author: Rajat Jain <rajatja@google.com>
Date: Thu Oct 25 00:12:53 2018

Status: Fixed (was: Untriaged)
AFAICT this is fixed with the above change

Sign in to add a comment