New issue
Advanced search Search tips

Issue 891562 link

Starred by 1 user
Status: Verified
Owner:
joelhockey@chromium.org
Closed: Oct 3
Cc:
slangley@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

CrOS FilesApp UI Test webkitResolveLocalFileSystemURL throwing incorrect error

Project Member Reported by joelhockey@chromium.org, Oct 3 
FilesApp UI Test webkitResolveLocalFileSystemURL implementation should be throwing FileNotFound error to be correct and consistent with the handling in VolumeInfoImpl.prototype.resolveTeamDrivesRoot_.

Errors such as https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-chromeos-rel/106331 should be ignored for certain drive root folders.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d1fb4160b7faad192dc86e29861c48530acf995

commit 3d1fb4160b7faad192dc86e29861c48530acf995
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Oct 03 02:03:44 2018

CrOS FilesApp UI tests: throw FileNotFound error in webkitResolveLocalFileSystemURL

FileNotFound is the correct error that should be thrown in this case, and is
consistent with the handling in VolumeInfoImpl.prototype.resolveTeamDrivesRoot_.

Bug:  891562 
Change-Id: I41e663a47c6f51190bb2344969a8eca6df36b3a3
Reviewed-on: https://chromium-review.googlesource.com/c/1258662
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596094}
[modify] https://crrev.com/3d1fb4160b7faad192dc86e29861c48530acf995/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js

Comment 2 by joelhockey@chromium.org, Oct 3

Status: Verified (was: Assigned)
►

Sign in to add a comment