Click to script: Wants-to-run badge UI is not always updated due to withheld web requests. |
|||||||
Issue descriptionRepro steps: - Have an extension installed which listens to web request events to x.com. - Change the extension to run on click. - Load a page (say to example.com) which makes a request to x.com (from its main-frame) as part of window.onload event (i.e. after the page has committed). - Notice that the web request listener can't intercept the request (This is correct). Expected: - The extension action is updated to indicate that the extension wants-to-run on the page. Actual: - The extension icon is not updated.
,
Oct 4
Requesting merge to M70. This is required for the runtime-host-permissions feature. It's a pretty low risk change (all of 7 lines).
,
Oct 4
This bug requires manual review: We are only 11 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 4
Have you verified this in canary?
,
Oct 5
Verified this on Canary.
,
Oct 8
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f4bb05ab7b85d9c843dcf8fbb00fa12ad9cf022 commit 8f4bb05ab7b85d9c843dcf8fbb00fa12ad9cf022 Author: Karandeep Bhatia <karandeepb@chromium.org> Date: Mon Oct 08 18:46:22 2018 [Merge M70] Click to script: Ensure withheld web requests correctly update wants-to-run badge UI. Currently we might not correctly update the wants-to-run badge UI for an extension if it has a withheld web request. Fix this by notifying the extension action API to update the badge UI, whenever the first withheld web request for an extension is registered on a web contents. TBR=rdevlin.cronin@chromium.org BUG= 891549 (cherry picked from commit 1c72c697f2d108a1f07e2fc451fb4d7b0190ff1c) Change-Id: Ibd5c639a878857bd96f2d7cc8a967b2750dabf57 Reviewed-on: https://chromium-review.googlesource.com/c/1258321 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#596448} Reviewed-on: https://chromium-review.googlesource.com/c/1268941 Cr-Commit-Position: refs/branch-heads/3538@{#899} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/8f4bb05ab7b85d9c843dcf8fbb00fa12ad9cf022/chrome/browser/extensions/api/extension_action/extension_action_apitest.cc [add] https://crrev.com/8f4bb05ab7b85d9c843dcf8fbb00fa12ad9cf022/chrome/browser/extensions/api/extension_action/test_extension_action_api_observer.cc [add] https://crrev.com/8f4bb05ab7b85d9c843dcf8fbb00fa12ad9cf022/chrome/browser/extensions/api/extension_action/test_extension_action_api_observer.h [modify] https://crrev.com/8f4bb05ab7b85d9c843dcf8fbb00fa12ad9cf022/chrome/browser/extensions/api/web_request/web_request_apitest.cc [modify] https://crrev.com/8f4bb05ab7b85d9c843dcf8fbb00fa12ad9cf022/chrome/browser/extensions/extension_action_runner.cc [modify] https://crrev.com/8f4bb05ab7b85d9c843dcf8fbb00fa12ad9cf022/chrome/test/BUILD.gn
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f4bb05ab7b85d9c843dcf8fbb00fa12ad9cf022 Commit: 8f4bb05ab7b85d9c843dcf8fbb00fa12ad9cf022 Author: karandeepb@chromium.org Commiter: karandeepb@chromium.org Date: 2018-10-08 18:46:22 +0000 UTC [Merge M70] Click to script: Ensure withheld web requests correctly update wants-to-run badge UI. Currently we might not correctly update the wants-to-run badge UI for an extension if it has a withheld web request. Fix this by notifying the extension action API to update the badge UI, whenever the first withheld web request for an extension is registered on a web contents. TBR=rdevlin.cronin@chromium.org BUG= 891549 (cherry picked from commit 1c72c697f2d108a1f07e2fc451fb4d7b0190ff1c) Change-Id: Ibd5c639a878857bd96f2d7cc8a967b2750dabf57 Reviewed-on: https://chromium-review.googlesource.com/c/1258321 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#596448} Reviewed-on: https://chromium-review.googlesource.com/c/1268941 Cr-Commit-Position: refs/branch-heads/3538@{#899} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Oct 4