PAC script fails to be parsed when it starts with a BOM |
|||
Issue description(This continues the problem reported in comments #9 and #11 of Issue 886578 ) The user's PAC script failed to execute in Chrome with: PAC_JAVASCRIPT_ERROR --> line_number = 1 --> message = "Uncaught SyntaxError: Invalid or unexpected token" The PAC file in question starts with a UTF-8 BOM (0xef, 0xbb, 0xbf). The server in question sending this response is Microsoft-IIS/7.5, so this will be affecting other users. Chrome should be able to correctly detect the encoding. This may be a regression, as the user notes this broke with Chrome 69.
,
Oct 3
This doesn't appear to be a regression -- Chrome 68 doesn't support BOM in PAC file either. (But is a bug nonetheless as the system resolver handles BOM)
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/598760f52aa37c308598575dbd037d7c9f3fcba5 commit 598760f52aa37c308598575dbd037d7c9f3fcba5 Author: Eric Roman <eroman@chromium.org> Date: Fri Oct 12 01:30:41 2018 Handle a BOM when converting PAC file to UTF16. Bug: 891526 Change-Id: I3ecda33cc7c1dbc2df96a613c5723a77ead9806c Reviewed-on: https://chromium-review.googlesource.com/c/1258505 Reviewed-by: Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#599060} [add] https://crrev.com/598760f52aa37c308598575dbd037d7c9f3fcba5/net/data/pac_file_fetcher_unittest/utf8_bom [add] https://crrev.com/598760f52aa37c308598575dbd037d7c9f3fcba5/net/data/pac_file_fetcher_unittest/utf8_bom.mock-http-headers [modify] https://crrev.com/598760f52aa37c308598575dbd037d7c9f3fcba5/net/proxy_resolution/pac_file_fetcher_impl.cc [modify] https://crrev.com/598760f52aa37c308598575dbd037d7c9f3fcba5/net/proxy_resolution/pac_file_fetcher_impl_unittest.cc
,
Oct 12
,
Nov 14
Is there an update on this, as my company is asking users to change there shortcuts to add --winhttp-proxy-resolver on it.
,
Nov 14
The fix is in Chrome 72, which should reach stable channel in the of January.
,
Nov 20
Thank you for this information, will pass this on. As it is getting really hard to have to keep closing and reopen chrome and a page does not want to load, but will load just fine in IE. Is there anything else you need to help further investigate this??
,
Nov 21
You could confirm whether Chrome 72 fixes the issue for you. You can test Chrome 72 using the Dev channel: https://www.google.com/chrome/dev/?platform=win64 |
|||
►
Sign in to add a comment |
|||
Comment 1 by eroman@chromium.org
, Oct 2