New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 891525 link

Starred by 1 user
Status: Fixed
Owner:
cblume@chromium.org
Closed: Oct 3
Cc:
█ egdaniel@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Non-Vulkan Android builds are including Vulkan headers

Project Member Reported by cblume@chromium.org, Oct 2 
When building Chrome for Android (which currently has Vulkan disabled) the Vulkan headers are being included. This isn't intentional. And it ends up causing redefinition errors when Skia builds with Vulkan always included.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e20c6e8387cdccf61eef8615ac2b3b0a582b156b

commit e20c6e8387cdccf61eef8615ac2b3b0a582b156b
Author: Chris Blume <cblume@chromium.org>
Date: Wed Oct 03 02:53:28 2018

Do not always include Vulkan headers

Building Chromium for Android currently does not support Vulkan.
However, Vulkan headers were accidentally being included anyway.

This was causing a redefinition error when Skia opted to always include
Vulkan but only use it when requested.

This patch puts the Vulkan includes behind a flag to match existing
gating.

BUG= 891525 

Change-Id: I88b759451a6353a762ea65cdbe34a4c467799ff2
Reviewed-on: https://chromium-review.googlesource.com/c/1257651
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596104}
[modify] https://crrev.com/e20c6e8387cdccf61eef8615ac2b3b0a582b156b/content/browser/renderer_host/compositor_impl_android.cc

Comment 2 by cblume@chromium.org, Oct 3

Status: Fixed (was: Assigned)
►

Sign in to add a comment