New issue
Advanced search Search tips

Issue 891517 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 4
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

SmbProviderClient crashes when SetupKerberos doesnt respond

Project Member Reported by baileyberro@chromium.org, Oct 2

Issue description

TOT

What steps will reproduce the problem?
I experience it on AD managed device after login
Crashes here: https://cs.chromium.org/chromium/src/chromeos/dbus/smb_provider_client.cc?rcl=7d03223d50065a02913ab233e3d7024c52ccf71c&l=523
because response is nullptr

[5819:5819:0927/125630.603525:ERROR:object_proxy.cc(621)] Failed to call method: org.chromium.SmbProvider.SetupKerberos: object_path= /org/chromium/SmbProvider: org.freedesktop.DBus.Error.NoReply: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
Received signal 11 SEGV_MAPERR 000000000008
#0 0x60e8e3fcff8c <unknown>
#1 0x60e8e3fcfb01 <unknown>
#2 0x7801428df2e0 <unknown>
#3 0x780142d334a0 <unknown>
  r8: 0000000000000000  r9: 00007801417a3740 r10: 6b726f7774656e20 r11: 0000000000000000
 r12: 000060e8e497a710 r13: 0000000000000000 r14: 00007ffdaf8397df r15: 00002c0559965df0
  di: 0000000000000008  si: 0000000000000062  bp: 00007ffdaf839610  bx: 00007ffdaf8397e8
  dx: 0000000000000000  ax: 93fe482213fd6900  cx: 000060e8e3fde0c0  sp: 00007ffdaf8395f8
  ip: 0000780142d334a0 efl: 0000000000010202 cgf: 0000000000000033 erf: 0000000000000004
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000008
[end of stack trace]

 
Copied this over from crbug.com/889830 since I made a mess over there
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0ef948abd75384b09c997bfe7def2f067af3445

commit f0ef948abd75384b09c997bfe7def2f067af3445
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Oct 03 15:15:11 2018

Don't crash on null response from smbproviderd

- Fixes a nullptr dereference crash when SetupKerberos times out.

Bug:  chromium:891517 
Change-Id: Ie9394ec31d1f1c640c313a829bd0d99c9f02e48f
Reviewed-on: https://chromium-review.googlesource.com/c/1258216
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596216}
[modify] https://crrev.com/f0ef948abd75384b09c997bfe7def2f067af3445/chromeos/dbus/smb_provider_client.cc

Labels: Merge-Request-70
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 3

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 3

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82a75a742f5fc81ab2b6bd9f1bca1720bf9cf399

commit 82a75a742f5fc81ab2b6bd9f1bca1720bf9cf399
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Oct 03 22:46:21 2018

Don't crash on null response from smbproviderd

- Fixes a nullptr dereference crash when SetupKerberos times out.

Bug:  chromium:891517 
Change-Id: Ie9394ec31d1f1c640c313a829bd0d99c9f02e48f
Reviewed-on: https://chromium-review.googlesource.com/c/1258216
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#596216}(cherry picked from commit f0ef948abd75384b09c997bfe7def2f067af3445)
Reviewed-on: https://chromium-review.googlesource.com/c/1260206
Cr-Commit-Position: refs/branch-heads/3538@{#843}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/82a75a742f5fc81ab2b6bd9f1bca1720bf9cf399/chromeos/dbus/smb_provider_client.cc

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/82a75a742f5fc81ab2b6bd9f1bca1720bf9cf399

Commit: 82a75a742f5fc81ab2b6bd9f1bca1720bf9cf399
Author: baileyberro@chromium.org
Commiter: zentaro@chromium.org
Date: 2018-10-03 22:46:21 +0000 UTC

Don't crash on null response from smbproviderd

- Fixes a nullptr dereference crash when SetupKerberos times out.

Bug:  chromium:891517 
Change-Id: Ie9394ec31d1f1c640c313a829bd0d99c9f02e48f
Reviewed-on: https://chromium-review.googlesource.com/c/1258216
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#596216}(cherry picked from commit f0ef948abd75384b09c997bfe7def2f067af3445)
Reviewed-on: https://chromium-review.googlesource.com/c/1260206
Cr-Commit-Position: refs/branch-heads/3538@{#843}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
Status: Fixed (was: Started)

Sign in to add a comment