Flaky test: TopControlsSlideControllerTest.TestIntermediateSliding Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=404fa248cb337a10 Test output log: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/14146 Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/I0737b5b38c727dd77fc522d9a52537f70abb16bd Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyugELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKDAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzE0MTQ2L2Jyb3dzZXJfdGVzdHMvVkc5d1EyOXVkSEp2YkhOVGJHbGtaVU52Ym5SeWIyeHNaWEpVWlhOMExsUmxjM1JKYm5SbGNtMWxaR2xoZEdWVGJHbGthVzVuDAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20TopControlsSlideControllerTest.TestIntermediateSliding&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyugELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKDAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzE0MTQ2L2Jyb3dzZXJfdGVzdHMvVkc5d1EyOXVkSEp2YkhOVGJHbGtaVU52Ym5SeWIyeHNaWEpVWlhOMExsUmxjM1JKYm5SbGNtMWxaR2xoZEdWVGJHbGthVzVuDAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2068a3fcdd9e78afb652a3fff28e048b3a98647c commit 2068a3fcdd9e78afb652a3fff28e048b3a98647c Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Tue Oct 02 22:11:37 2018 Revert "Top-chrome slide: Fix and test intermediate sliding" This reverts commit 43ffa309bf311ca8297809886f52a5ae4749dc41. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 595899 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNDNmZmEzMDliZjMxMWNhODI5NzgwOTg4NmY1MmE1YWU0NzQ5ZGM0MQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/14146 Sample Failed Step: browser_tests Sample Flaky Test: TopControlsSlideControllerTest.TestIntermediateSliding Original change's description: > Top-chrome slide: Fix and test intermediate sliding > > Gesture scrolling starts before top-chrome starts > sliding. During that small period, the > `DoBrowserControlsShrinkRendererSize` bit should > remain unchanged. > > This CL fixes this issue and adds a test to verify > the state of the browser while top-chrome sliding > is in progress. > > BUG=884440, 867063 > TEST=Added new test > > Change-Id: I0737b5b38c727dd77fc522d9a52537f70abb16bd > Reviewed-on: https://chromium-review.googlesource.com/c/1249729 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595899} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=884440, 867063, 891516 Change-Id: I5acaddebf8b9aade85e0371dbf8b6933dcaae18c Reviewed-on: https://chromium-review.googlesource.com/c/1258215 Cr-Commit-Position: refs/heads/master@{#596002} [modify] https://crrev.com/2068a3fcdd9e78afb652a3fff28e048b3a98647c/chrome/browser/ui/views/frame/OWNERS [modify] https://crrev.com/2068a3fcdd9e78afb652a3fff28e048b3a98647c/chrome/browser/ui/views/frame/top_controls_slide_controller.h [modify] https://crrev.com/2068a3fcdd9e78afb652a3fff28e048b3a98647c/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.cc [modify] https://crrev.com/2068a3fcdd9e78afb652a3fff28e048b3a98647c/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.h [modify] https://crrev.com/2068a3fcdd9e78afb652a3fff28e048b3a98647c/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc
Removing from sheriff queue since no longer flaky (no longer exists after revert). Assigning to original CL author; please feel free to close or repurpose for your own tracking.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40f94744d2c3da39380ca595a49637adb2aa9cc8 commit 40f94744d2c3da39380ca595a49637adb2aa9cc8 Author: Ahmed Fakhry <afakhry@chromium.org> Date: Thu Oct 04 16:25:16 2018 (Reland) Top-chrome slide: Fix and test intermediate sliding Gesture scrolling starts before top-chrome starts sliding. During that small period, the `DoBrowserControlsShrinkRendererSize` bit should remain unchanged. This CL fixes this issue and adds a test to verify the state of the browser while top-chrome sliding is in progress. BUG=884440, 867063, 891516 TEST=Added new test Reviewed-on: https://chromium-review.googlesource.com/c/1249729 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#595899} Change-Id: I63f101175c1ec1052d6e0bb55bbe760fd7a8b369 Reviewed-on: https://chromium-review.googlesource.com/c/1260105 Cr-Commit-Position: refs/heads/master@{#596700} [modify] https://crrev.com/40f94744d2c3da39380ca595a49637adb2aa9cc8/chrome/browser/ui/views/frame/OWNERS [modify] https://crrev.com/40f94744d2c3da39380ca595a49637adb2aa9cc8/chrome/browser/ui/views/frame/top_controls_slide_controller.h [modify] https://crrev.com/40f94744d2c3da39380ca595a49637adb2aa9cc8/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.cc [modify] https://crrev.com/40f94744d2c3da39380ca595a49637adb2aa9cc8/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.h [modify] https://crrev.com/40f94744d2c3da39380ca595a49637adb2aa9cc8/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc
Comment 1 by bugdroid1@chromium.org
, Oct 2