New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 891514 link

Starred by 1 user
Status: Fixed
Owner:
chanli@chromium.org
Closed: Oct 10
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] ValueError: python2.7/json/decoder.py:380 raw_decode

Project Member Reported by chanli@chromium.org, Oct 2 
Error log: https://pantheon.corp.google.com/errors/CM_F_s3GruroAw?time=P1D&refresh=off&project=findit-for-me

This error happens on https://findit-for-me.appspot.com/waterfall/failure?url=https://luci-milo.appspot.com/buildbot/chromium.linux/Linux%20Tests%20(dbg)(1)/74791

Sample log:
ValueError: python2.7/json/decoder.py:380 raw_decode $$ Unterminated string starting at: line 1 column 33549659 (char 33549658)
at raw_decode (/base/alloc/tmpfs/dynamic_runtimes/python27g/ec315266546cb44c/python27/python27_dist/lib/python2.7/json/decoder.py:380)
at decode (/base/alloc/tmpfs/dynamic_runtimes/python27g/ec315266546cb44c/python27/python27_dist/lib/python2.7/json/decoder.py:364)
at loads (/base/alloc/tmpfs/dynamic_runtimes/python27g/ec315266546cb44c/python27/python27_dist/lib/python2.7/json/__init__.py:339)
at _GetRawLogsFromGetEndpoint (/base/data/home/apps/s~findit-for-me/waterfall-backend:17991-52918bd.412895804370637222/infra_api_clients/logdog_util.py:91)
at _GetLogForPath (/base/data/home/apps/s~findit-for-me/waterfall-backend:17991-52918bd.412895804370637222/infra_api_clients/logdog_util.py:110)
at _GetLog (/base/data/home/apps/s~findit-for-me/waterfall-backend:17991-52918bd.412895804370637222/infra_api_clients/logdog_util.py:268)
at GetStepLogLegacy (/base/data/home/apps/s~findit-for-me/waterfall-backend:17991-52918bd.412895804370637222/infra_api_clients/logdog_util.py:285)
at GetWaterfallBuildStepLog (/base/data/home/apps/s~findit-for-me/waterfall-backend:17991-52918bd.412895804370637222/services/step_util.py:388)
at GetStdoutLog (/base/data/home/apps/s~findit-for-me/waterfall-backend:17991-52918bd.412895804370637222/services/extract_signal.py:46)
at ExtractSignalsForTestFailure (/base/data/home/apps/s~findit-for-me/waterfall-backend:17991-52918bd.412895804370637222/services/test_failure/extract_test_signal.py:71)
at HeuristicAnalysisForTest (/base/data/home/apps/s~findit-for-me/waterfall-backend:17991-52918bd.412895804370637222/services/test_failure/test_failure_analysis.py:228)
at RunImpl (/base/data/home/apps/s~findit-for-me/waterfall-backend:17991-52918bd.412895804370637222/pipelines/test_failure/heuristic_analysis_for_test_pipeline.py:30)
at _RunImplWrapper (/base/data/home/apps/s~findit-for-me/waterfall-backend:17991-52918bd.412895804370637222/gae_libs/pipelines.py:232)
at Wrapped (/base/data/home/apps/s~findit-for-me/waterfall-backend:17991-52918bd.412895804370637222/libs/exceptions.py:27)
at run (/base/data/home/apps/s~findit-for-me/waterfall-backend:17991-52918bd.412895804370637222/gae_libs/pipelines.py:253)
at _run_internal (/base/data/home/apps/s~findit-for-me/waterfall-backend:17991-52918bd.412895804370637222/third_party/pipeline/pipeline.py:1113)
at evaluate (/base/data/home/apps/s~findit-for-me/waterfall-backend:17991-52918bd.412895804370637222/third_party/pipeline/pipeline.py:2158)
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ee5de9895a62ac092fc3e7d1d9d7e6dcb121ccfc

commit ee5de9895a62ac092fc3e7d1d9d7e6dcb121ccfc
Author: Chan <chanli@chromium.org>
Date: Wed Oct 03 01:05:37 2018

[Findit] catch the exception that failed to json load a response when getting a logdog log.

For unknown reason sometimes the response_json is truncated and cannot be json loaded. Catch the exception to record the error and keep the analysis going.

Bug:  891514 

Change-Id: Ie31fe74089fcc3385a87d45bff7813193e1058c5
Reviewed-on: https://chromium-review.googlesource.com/c/1257576
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18017}
[modify] https://crrev.com/ee5de9895a62ac092fc3e7d1d9d7e6dcb121ccfc/appengine/findit/infra_api_clients/logdog_util.py
[modify] https://crrev.com/ee5de9895a62ac092fc3e7d1d9d7e6dcb121ccfc/appengine/findit/infra_api_clients/test/logdog_util_test.py

Comment 2 by chanli@chromium.org, Oct 10

Status: Fixed (was: Started)
►

Sign in to add a comment