New issue
Advanced search Search tips

Issue 891513 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Build-Toolchain



Sign in to add a comment

Cannot build dev-util/cargo

Project Member Reported by manojgupta@chromium.org, Oct 2

Issue description

Cargo is failing to build locally on my chroot.
Also saw the same problem in one of my tryjobs with "--latest-toolchain".

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8933747311035214960

>>> Preparing source in /var/tmp/portage/dev-util/cargo-0.29.0-r1/work/cargo-0.29.0 ...
 * ERROR: dev-util/cargo-0.29.0-r1::chromiumos failed (prepare phase):
 *   eapply: no files specified
 * 
 * Call stack:
 *            ebuild.sh, line  133:  Called src_prepare
 *          environment, line 3401:  Called default
 *   phase-functions.sh, line  805:  Called default_src_prepare
 *   phase-functions.sh, line  870:  Called __eapi6_src_prepare
 *          environment, line  471:  Called eapply
 *          environment, line 1255:  Called die
 * The specific snippet of code:
 *           die "eapply: no files specified";


Please fix asap since this will also break SDK builder (once the builder's current set of issues are fixed).
 
I don't really understand why this isn't working.  The ebuild is identical to upstream except for KEYWORDS.
Probably upstream Gentoo portage allows eapply with no patches, or may not be running eapply at all if PATCHES is empty. vapier@ might know what's going on.

Nevertheless, did you try building it locally?
I also had the build fail locally; but I found that if I change "EAPI=6" to "EAPI=5" in the cargo ebuild file, the local build succeeds.  I've created a CL to make this change:

 https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1258094

Cc: manojgupta@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/dc772c83c108d0555ac017cb2ce89c1e6265e6f2

commit dc772c83c108d0555ac017cb2ce89c1e6265e6f2
Author: Chirantan Ekbote <chirantan@chromium.org>
Date: Wed Oct 03 20:59:21 2018

dev-util/cargo: Remove empty PATCHES array

Remove the empty PATCHES array in the cargo ebuild.  Portage doesn't
seem to like it and we don't have any patches to apply anyway.

BUG= chromium:891513 
TEST=sudo emerge cargo

Change-Id: I58351568643b0e47405811cf498d7427cabc8d5d
Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1257593
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/dc772c83c108d0555ac017cb2ce89c1e6265e6f2/dev-util/cargo/cargo-0.29.0.ebuild
[rename] https://crrev.com/dc772c83c108d0555ac017cb2ce89c1e6265e6f2/dev-util/cargo/cargo-0.29.0-r2.ebuild

Status: Fixed (was: Assigned)

Sign in to add a comment