New issue
Advanced search Search tips

Issue 891510 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug
Flaky-Test: fast/dom/inline-event-attributes-release.html



Sign in to add a comment

fast/dom/inline-event-attributes-release.html is flaky fail

Project Member Reported by Findit, Oct 2

Issue description

Cc: mlippautz@chromium.org
Summary: fast/dom/inline-event-attributes-release.html is flaky fail on win7 (was: fast/dom/inline-event-attributes-release.html is flaky)
Appears to be flaky-fail on win7:

"Tests that we do not hold on to any nodes

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


FAIL afterCount - beforeCount should be 0. Was 3.
PASS successfullyParsed is true

TEST COMPLETE"

Test is flaking quite a lot on the CQ/tryjobs: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=fast%2Fdom%2Finline-event-attributes-release.html

Not sure yet what caused the flake; the test doesn't seem to be run before r596128 but there's no obvious reason I can see. Will likely update TestExpectations for the test shortly unless I can find a reason for the flake.

Not 100% sure who to cc, so guessing based on the file history.
Components: Blink>DOM
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/439b35f5806bc2b9e3d4a77d0af379d85693525f

commit 439b35f5806bc2b9e3d4a77d0af379d85693525f
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Wed Oct 03 16:12:31 2018

[Sheriff] Mark fast/dom/inline-event-attributes-release.html flaky

Test is flaky-failing on win7, with no obvious recent change to be
reverted.

Bug: 891510
Change-Id: Ie77d5cf168bcf363dd994414249ea4f803907690

TBR=mlippautz@chromium.org

Change-Id: Ie77d5cf168bcf363dd994414249ea4f803907690
Reviewed-on: https://chromium-review.googlesource.com/c/1258962
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596241}
[modify] https://crrev.com/439b35f5806bc2b9e3d4a77d0af379d85693525f/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium
Taking this off sheriff queue since its now marked flaky.
Components: -Blink>DOM Blink>HTML
Labels: -Pri-1 Test-Layout Pri-3
Status: Available (was: Untriaged)
Labels: -Pri-3 Pri-1
Seems to be an issue on Linux as well, it failed several times during a trybot run in linux_chromium_rel_ng here: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/216859

Maybe mark as flaky for all platforms?
Summary: fast/dom/inline-event-attributes-release.html is flaky fail (was: fast/dom/inline-event-attributes-release.html is flaky fail on win7)
Add Mac to that: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/169742
Labels: Sheriff-Chromium
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36270188f9d694a8200c3bf088b13d752875de0b

commit 36270188f9d694a8200c3bf088b13d752875de0b
Author: Marc Treib <treib@chromium.org>
Date: Thu Oct 25 11:37:04 2018

Mark fast/dom/inline-event-attributes-release.html flaky on Linux

It was already marked flaky on Win7, but it's just as flaky on Linux

TBR=mlippautz@chromium.org

Bug: 891510
Change-Id: If866e045a379aa66ebf24e18acca9c1db6a2bef6
Reviewed-on: https://chromium-review.googlesource.com/c/1298208
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602669}
[modify] https://crrev.com/36270188f9d694a8200c3bf088b13d752875de0b/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium
Cc: -mlippautz@chromium.org
Owner: mlippautz@chromium.org
Status: Assigned (was: Available)
mlippautz, could you take a look or reassign as appropriate?
Cc: mlippautz@chromium.org
Labels: -Pri-1 Pri-2
Owner: keishi@chromium.org
Keishi, can you have a look? Otherwise, it needs to wait as I don't have cycles right now.

Sign in to add a comment