New issue
Advanced search Search tips

Issue 891495 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 2
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Extract cross platform portions from VrShell and VrGlThread

Project Member Reported by acondor@chromium.org, Oct 2

Issue description

To be used on Windows.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f088b1eab73afb7e1f716e000b22f785ebe41a85

commit f088b1eab73afb7e1f716e000b22f785ebe41a85
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Wed Oct 03 14:14:43 2018

VR: Make VrWebContentsObserver platform independent

Bug: 891495
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6b4aa77dc0c81b79afe681c31ed2b4a06f19dc37
Reviewed-on: https://chromium-review.googlesource.com/c/1257816
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596201}
[modify] https://crrev.com/f088b1eab73afb7e1f716e000b22f785ebe41a85/chrome/browser/android/vr/BUILD.gn
[modify] https://crrev.com/f088b1eab73afb7e1f716e000b22f785ebe41a85/chrome/browser/android/vr/vr_shell.cc
[modify] https://crrev.com/f088b1eab73afb7e1f716e000b22f785ebe41a85/chrome/browser/android/vr/vr_shell.h
[modify] https://crrev.com/f088b1eab73afb7e1f716e000b22f785ebe41a85/chrome/browser/vr/BUILD.gn
[rename] https://crrev.com/f088b1eab73afb7e1f716e000b22f785ebe41a85/chrome/browser/vr/vr_web_contents_observer.cc
[rename] https://crrev.com/f088b1eab73afb7e1f716e000b22f785ebe41a85/chrome/browser/vr/vr_web_contents_observer.h

Owner: billorr@chromium.org
I'll upload my WIP in a bit.

Sign in to add a comment