Can you post a screenshot of the text that should be found but it isn't?

Thanks for filing Chris!

There are two versions of the "Enhanced spell check" setting right now:
(1) #unified-consent=Disabled: this is the current version that's launched on stable. The setting lives underneath "Privacy and security" and is titled "Use a web spelling service to help resolve errors"
(2) #unified-consent=Enabled: this is the planned version of the setting that we will roll out with Unity (targeting M71+). We moved the setting to the "Sync and Google services" page, as Chris noted in his original post. The title of the setting is "Enhanced spell check"

I've included screenshots of both the current stable state and the planned change for Unity. Note that in the second screenshot, searching for "spell" doesn't pick up on "Enhanced spell check" in "Sync and Google services" settings subpage (chrome://settings/syncSetup). Demetrios - could you help advise us on how to make sure the settings appears in search results?

Deleted: Screen Shot 2018-10-02 at 3.12.35 PM.png 138 KB

	Screen Shot 2018-10-02 at 3.12.35 PM.png 138 KB View Download

Deleted: Screen Shot 2018-10-02 at 3.12.54 PM.png 38.7 KB

	Screen Shot 2018-10-02 at 3.12.54 PM.png 38.7 KB View Download

Deleted: Screen Shot 2018-10-02 at 3.13.03 PM.png 140 KB

	Screen Shot 2018-10-02 at 3.13.03 PM.png 140 KB View Download

Thanks for the screenshots. I can reproduce the fact that the contents of chrome://settings/syncSetup are not search at all (not just for "spell" but for other strings as well).

Inspecting the DOM reveals that the corresponding subpage has a 'no-search' attribute, causing the search algorithm to bail out, see attachment.

Have not located exactly where that attribute appears in the source code, but should not be very hard to find.

Deleted: no_search.png 23.1 KB

	no_search.png 23.1 KB View Download

Found it at https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/people_page/people_page.html?l=364.

So the question is why is this returning true, when it should return false (which would cause the no-search attribute to be removed).

+scott who landed that particular line at r545617. Scott, any ideas on why isAdvancedSyncSettingsVisible_() seems to be returning the wrong value?

I think at the time I added the unifiedConsent in the check, it was because the sync page was existing with no content in the page, so it was causing JS errors when user searched. Now that that's changed, the content for isAdvancedSyncSettingsVisible_() function should be updated to the appropriate checks.

We might also need to take into account which part of the sync page is available to be searched based on the user login/sync status, so potentially we need to add more conditional "no-search" attributes to certain elements in the sync page. because of that, assigning to tangltom@ who is more familiar with the new sync page.

Updating the title per #4.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/076ee02363e99bb3e8a8ddf8cd4f6237ac3ebf9c

commit 076ee02363e99bb3e8a8ddf8cd4f6237ac3ebf9c
Author: Thomas Tangl <tangltom@chromium.org>
Date: Mon Oct 29 01:15:47 2018

[unified-consent] Make sync page searchable

- Remove the no-search property from the sync page elements when
  unified consent is enabled.
- Assign the correct associated-control property to the
  settings-subpage element.

Bug:  891494 
Change-Id: I968860a49d9be93a4cdb0319946a72ab8c3ea3ef
Reviewed-on: https://chromium-review.googlesource.com/c/1301599
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603395}
[modify] https://crrev.com/076ee02363e99bb3e8a8ddf8cd4f6237ac3ebf9c/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/076ee02363e99bb3e8a8ddf8cd4f6237ac3ebf9c/chrome/browser/resources/settings/people_page/people_page.js

Tested this issue on Windows 10 on the latest M-72 - 72.0.3596.0 build by following the below steps.

1. Launched Chrome -> Signed into Chrome and Synced the account.
2. Navigated to chrome://settings and searched for 'spell'. Could see the search results from chrome://settings/ page only and Enhanced Spell Check is not returned.
3. Navigated to chrome://flags and Enabled 'Unified Consent' flag and now could see the search result for Spell on navigating to chrome://settings/syncSetup 
Attached is the screen cast for reference.

tangltom@ Request you to check and confirm if anything is missed from our end in verifying the issue and help us in verifying the fix on the latest M-72 build.

Thanks..

Deleted: 891494.mp4 3.2 MB

	891494.mp4 3.2 MB View Download

Perfect. Requesting merge based on #c14.

This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approving merge to M71 branch 3578 based on comment #15. Please merge ASAP. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6c77065bf06ca3d315bc4c83066a3600e2ae719

commit a6c77065bf06ca3d315bc4c83066a3600e2ae719
Author: Thomas Tangl <tangltom@chromium.org>
Date: Tue Oct 30 14:41:01 2018

[unified-consent] Make sync page searchable

- Remove the no-search property from the sync page elements when
  unified consent is enabled.
- Assign the correct associated-control property to the
  settings-subpage element.

Bug:  891494 
Change-Id: I968860a49d9be93a4cdb0319946a72ab8c3ea3ef
Reviewed-on: https://chromium-review.googlesource.com/c/1301599
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#603395}(cherry picked from commit 076ee02363e99bb3e8a8ddf8cd4f6237ac3ebf9c)
Reviewed-on: https://chromium-review.googlesource.com/c/1307505
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#390}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/a6c77065bf06ca3d315bc4c83066a3600e2ae719/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/a6c77065bf06ca3d315bc4c83066a3600e2ae719/chrome/browser/resources/settings/people_page/people_page.js

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/a6c77065bf06ca3d315bc4c83066a3600e2ae719

Commit: a6c77065bf06ca3d315bc4c83066a3600e2ae719
Author: tangltom@chromium.org
Commiter: tangltom@chromium.org
Date: 2018-10-30 14:41:01 +0000 UTC

[unified-consent] Make sync page searchable

- Remove the no-search property from the sync page elements when
  unified consent is enabled.
- Assign the correct associated-control property to the
  settings-subpage element.

Bug:  891494 
Change-Id: I968860a49d9be93a4cdb0319946a72ab8c3ea3ef
Reviewed-on: https://chromium-review.googlesource.com/c/1301599
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#603395}(cherry picked from commit 076ee02363e99bb3e8a8ddf8cd4f6237ac3ebf9c)
Reviewed-on: https://chromium-review.googlesource.com/c/1307505
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#390}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Able to reproduce this issue on Windows 10, Mac OS 10.13.6 and Ubuntu 17.10 on the reported version 71.0.3568.0 and the issue is fixed on the latest M-71 build 71.0.3578.30 as per comment #15.

1. Launched Chrome -> Signed into Chrome and Synced the account.
2. Navigated to chrome://settings and searched for 'spell'. Could see the search results from chrome://settings/ page only and Enhanced Spell Check is not returned.
3. Navigated to chrome://flags and Enabled 'Unified Consent' flag and now could see the search result for Spell on navigating to chrome://settings/syncSetup 
Attached is the screen cast for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..

Deleted: 891494-M71.mp4 2.6 MB

	891494-M71.mp4 2.6 MB View Download