see b/112934573 go/a11y-arc++-window-mapping
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cae9ffb0b21833eb464b9acd4c6c614dc94290b1 commit cae9ffb0b21833eb464b9acd4c6c614dc94290b1 Author: Katie D <katie@chromium.org> Date: Wed Oct 03 17:39:48 2018 Chrome can pick ARC++ tree depending on source_id. This will allow us to pass more AccessibilityNodeInfoDatas even if they belong to different windows, which is part of the upgrade path planned for mapping ARC++ windows to Chrome OS. See go/a11y-arc++-window-mapping > Upgrade path for more. Bug: 891483 Change-Id: Ic7a1654691cec6d4229898d7d7aaeb3947953234 Reviewed-on: https://chromium-review.googlesource.com/1258207 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#596276} [modify] https://crrev.com/cae9ffb0b21833eb464b9acd4c6c614dc94290b1/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc [modify] https://crrev.com/cae9ffb0b21833eb464b9acd4c6c614dc94290b1/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/942dbde3b5cb09fe05e410c91857907eed02fb39 commit 942dbde3b5cb09fe05e410c91857907eed02fb39 Author: Katie D <katie@chromium.org> Date: Thu Oct 25 18:32:27 2018 Prepare to support windows in ARC++ accessibility tree. This creates no behavior changes, but refactors AXTreeSourceARC to take a more generic type, ArcAccessibilityInfoData, rather than mojom::AccessibilityNodeInfoData. This will support AXTreeSourceARC working with mojom::AccessibilityWindowInfoData in a follow-up change. Also udpates the mojo file to match the ARC++ side, see https://googleplex-android-review.git.corp.google.com/c/platform/vendor/google_arc/+/5216428. Also refactors helper function ToAXEvent into the ARC utils class. See go/a11y-arc++-window-mapping for more. Bug: b/112934573,891483 Change-Id: I0dfb41bb3397dc2b82976d75b2a9daedfcca49f1 Reviewed-on: https://chromium-review.googlesource.com/c/1274105 Reviewed-by: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#602805} [modify] https://crrev.com/942dbde3b5cb09fe05e410c91857907eed02fb39/chrome/browser/chromeos/BUILD.gn [add] https://crrev.com/942dbde3b5cb09fe05e410c91857907eed02fb39/chrome/browser/chromeos/arc/accessibility/accessibility_node_info_data_wrapper.cc [add] https://crrev.com/942dbde3b5cb09fe05e410c91857907eed02fb39/chrome/browser/chromeos/arc/accessibility/accessibility_node_info_data_wrapper.h [add] https://crrev.com/942dbde3b5cb09fe05e410c91857907eed02fb39/chrome/browser/chromeos/arc/accessibility/accessibility_window_info_data_wrapper.cc [add] https://crrev.com/942dbde3b5cb09fe05e410c91857907eed02fb39/chrome/browser/chromeos/arc/accessibility/accessibility_window_info_data_wrapper.h [add] https://crrev.com/942dbde3b5cb09fe05e410c91857907eed02fb39/chrome/browser/chromeos/arc/accessibility/arc_accessibility_info_data.h [modify] https://crrev.com/942dbde3b5cb09fe05e410c91857907eed02fb39/chrome/browser/chromeos/arc/accessibility/arc_accessibility_util.cc [modify] https://crrev.com/942dbde3b5cb09fe05e410c91857907eed02fb39/chrome/browser/chromeos/arc/accessibility/arc_accessibility_util.h [modify] https://crrev.com/942dbde3b5cb09fe05e410c91857907eed02fb39/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc [modify] https://crrev.com/942dbde3b5cb09fe05e410c91857907eed02fb39/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.h [modify] https://crrev.com/942dbde3b5cb09fe05e410c91857907eed02fb39/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc_unittest.cc [modify] https://crrev.com/942dbde3b5cb09fe05e410c91857907eed02fb39/components/arc/common/accessibility_helper.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51bc29e2f4ef8f9f56afd4c3d0a98ca86c8859a8 commit 51bc29e2f4ef8f9f56afd4c3d0a98ca86c8859a8 Author: Katie D <katie@chromium.org> Date: Fri Nov 02 19:13:11 2018 Populate window data in AccessibilityWindowInfoDataWrapper. Does not yet start using windows in Arc. See go/a11y-arc++-window-mapping for more. Bug: 891483 Change-Id: Ibbd47b12b4440f3200edb9e57a14658f489e4cd5 Reviewed-on: https://chromium-review.googlesource.com/c/1308079 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#605008} [modify] https://crrev.com/51bc29e2f4ef8f9f56afd4c3d0a98ca86c8859a8/chrome/browser/chromeos/arc/accessibility/accessibility_node_info_data_wrapper.cc [modify] https://crrev.com/51bc29e2f4ef8f9f56afd4c3d0a98ca86c8859a8/chrome/browser/chromeos/arc/accessibility/accessibility_node_info_data_wrapper.h [modify] https://crrev.com/51bc29e2f4ef8f9f56afd4c3d0a98ca86c8859a8/chrome/browser/chromeos/arc/accessibility/accessibility_window_info_data_wrapper.cc [modify] https://crrev.com/51bc29e2f4ef8f9f56afd4c3d0a98ca86c8859a8/chrome/browser/chromeos/arc/accessibility/accessibility_window_info_data_wrapper.h [modify] https://crrev.com/51bc29e2f4ef8f9f56afd4c3d0a98ca86c8859a8/chrome/browser/chromeos/arc/accessibility/arc_accessibility_info_data.h [modify] https://crrev.com/51bc29e2f4ef8f9f56afd4c3d0a98ca86c8859a8/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02cb40dc9dd9e867d79d23bfe33d7b7be12f8fbe commit 02cb40dc9dd9e867d79d23bfe33d7b7be12f8fbe Author: Katie D <katie@chromium.org> Date: Mon Nov 19 19:42:56 2018 Use ARC++ windows in Chrome accessibility tree. This completes work from go/a11y-arc++-window-mapping, but does not yet remove the restriction that we only look at the interesting subtree. That restriction is still valid because we only want one root node ID. If we assume that there is only one, we can remove this restriction. Bug: 891483 Change-Id: Ib9581be294de88c6ed4c4e9934536859edc9b4e7 Reviewed-on: https://chromium-review.googlesource.com/c/1319858 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#609400} [modify] https://crrev.com/02cb40dc9dd9e867d79d23bfe33d7b7be12f8fbe/chrome/browser/chromeos/arc/accessibility/accessibility_node_info_data_wrapper.cc [modify] https://crrev.com/02cb40dc9dd9e867d79d23bfe33d7b7be12f8fbe/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc [modify] https://crrev.com/02cb40dc9dd9e867d79d23bfe33d7b7be12f8fbe/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc [modify] https://crrev.com/02cb40dc9dd9e867d79d23bfe33d7b7be12f8fbe/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.h [modify] https://crrev.com/02cb40dc9dd9e867d79d23bfe33d7b7be12f8fbe/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc_unittest.cc
There's some follow-up work that can be done to support multiple windows at once, which I'll mark in separate bugs.
Comment 1 by bugdroid1@chromium.org
, Oct 3