New issue
Advanced search Search tips

Issue 891473 link

Starred by 1 user
Status: Duplicate
Merged: issue 891489
Owner:
mukai@chromium.org
Closed: Oct 3
Cc:
sky@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

KeyboardLock is not implemented for Mash

Project Member Reported by mukai@chromium.org, Oct 2 
The test failures of KeyboardLockInteractiveBrowserTest are due to the lack of implementation of locking keyboard.

In ChromeOS (Aura), RenderWidgetHostView's LockKeyboard / UnlockKeyboard https://cs.chromium.org/chromium/src/content/public/browser/render_widget_host_view.h?q=renderwidgethostview&sq=package:chromium&g=0&l=178 invokes aura::WindowTreeHost::CaptureSystemKeyEvents https://cs.chromium.org/chromium/src/ui/aura/window_tree_host.h?q=windowtreehost&sq=package:chromium&g=0&l=220. For Mash / SingleProcessMash, this happens only within the browser but this needs to be handled in Ash to take the effect.

Maybe we want to add a mojo method for this feature?

Comment 1 by sky@chromium.org, Oct 3 

Indeed. We will definitely need to add some mojom interfaces for this.

Comment 2 by mukai@chromium.org, Oct 3

Mergedinto: 891489
Status: Duplicate (was: Assigned)
My bad, my comment was wrong actually. Sorry.

KeyboardLock behavior seems staying within browser and so it does not have to be propagated to Ash. However WindowServiceDelegateImpl::OnUnhandledEvent invokes some acccelerators which break the test expectations. This means KeyboardLockInteractibeBrowserTest failures are essentially same as  issue 891489 .
Deduping.
►

Sign in to add a comment