New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 891461 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Build-Toolchain



Sign in to add a comment

chromiumos-sdk: builder fails InitSDK with "Permission denied: '/etc/cros_chroot_version"

Project Member Reported by briannorris@chromium.org, Oct 2

Issue description

e.g.:

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8933755792503577184

There are other failures due to  bug 890858  mixed in there, but I think that particular one might be resolved.

These look possibly related?

https://chromium-review.googlesource.com/1231357
https://chromium-review.googlesource.com/1236781

--

Log snippet (InitSDK):

run_chroot_version_hooks: Unhandled exception:
Traceback (most recent call last):
  File "/mnt/host/source/chromite/bin/run_chroot_version_hooks", line 169, in <module>
    DoMain()
  File "/mnt/host/source/chromite/bin/run_chroot_version_hooks", line 165, in DoMain
    commandline.ScriptWrapperMain(FindTarget)
  File "/mnt/host/source/chromite/lib/commandline.py", line 912, in ScriptWrapperMain
    ret = target(argv[1:])
  File "/mnt/host/source/chromite/scripts/run_chroot_version_hooks.py", line 50, in main
    cros_sdk_lib.InitLatestVersion()
  File "/mnt/host/source/chromite/lib/cros_sdk_lib.py", line 483, in InitLatestVersion
    chroot.SetVersion(chroot.latest_version)
  File "/mnt/host/source/chromite/lib/cros_sdk_lib.py", line 556, in SetVersion
    osutils.WriteFile(self._version_file, str(version))
  File "/mnt/host/source/chromite/lib/osutils.py", line 145, in WriteFile
    with open(write_path, mode) as f:
IOError: [Errno 13] Permission denied: '/etc/cros_chroot_version'
 
Components: Tools>ChromeOS-Toolchain
Owner: saklein@chromium.org
Status: Assigned (was: Untriaged)
+ toolchain component, in case toolchain team is particularly interested in this builder
probably missing a `sudo` or sudo=True in the new code paths.  shouldn't be too hard to fix.
Cc: yunlian@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/40a16ffeefe6193827248e96d3402b2cf0c4e5ce

commit 40a16ffeefe6193827248e96d3402b2cf0c4e5ce
Author: Alex Klein <saklein@chromium.org>
Date: Thu Oct 04 07:37:15 2018

run_chroot_version_hooks: hook and version file permissions fix

The version file update needed to be run as sudo and was missing
a followup chown.
Many hooks have their permissions set to 644, so the bash -c run
attempts did not always properly execute the scripts.

BUG= chromium:891461 
TEST=new tests, run_tests, manual

Change-Id: Ibbf76e4ead4b4aa22a7f76394d8279f732c408be
Reviewed-on: https://chromium-review.googlesource.com/1257943
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/40a16ffeefe6193827248e96d3402b2cf0c4e5ce/lib/cros_sdk_lib.py
[modify] https://crrev.com/40a16ffeefe6193827248e96d3402b2cf0c4e5ce/lib/cros_sdk_lib_unittest.py
[modify] https://crrev.com/40a16ffeefe6193827248e96d3402b2cf0c4e5ce/lib/osutils_unittest.py
[modify] https://crrev.com/40a16ffeefe6193827248e96d3402b2cf0c4e5ce/lib/osutils.py

Status: Fixed (was: Started)

Sign in to add a comment