New issue
Advanced search Search tips

Issue 891442 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----



Sign in to add a comment

Context menu remains visible after tablet mode transition

Project Member Reported by newcomer@chromium.org, Oct 2

Issue description

Chrome Version: latest m-70 canary

Open context menu of an app in folder in laptop mode, then switch to tablet mode, the folder will be closed, but context menu is not.
 
Summary: Context menu remains visible after tablet mode transition (was: White / light gray border around the QS tray)
Labels: -Pri-2 Pri-1
Owner: ginko@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Interestingly, this works perfectly going from tablet->clamshell

I'd imagine this has to do with an app_list Dismiss() call somewhere that cleans up context menus.

I'll try to find the exact spot they get dismissed...
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ddae57b9f3f4515ba4bcba4d8ec107e0d016196

commit 1ddae57b9f3f4515ba4bcba4d8ec107e0d016196
Author: Kevin Strohbehn <ginko@google.com>
Date: Tue Nov 06 02:11:11 2018

Prevent context menus from remaining open after a tablet mode transition

Bug:  891442 
Change-Id: Ib173d99becdfc8924ddf382aeb0687c2bde1a145
Reviewed-on: https://chromium-review.googlesource.com/c/1317899
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605569}
[modify] https://crrev.com/1ddae57b9f3f4515ba4bcba4d8ec107e0d016196/ash/app_list/views/apps_grid_view.cc

Status: Fixed (was: Started)

Sign in to add a comment