The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bff4f2f26def416abcffdf48a3b802c0ba11f52

commit 2bff4f2f26def416abcffdf48a3b802c0ba11f52
Author: Mason Freed <masonfreed@chromium.org>
Date: Wed Oct 10 13:25:10 2018

Exchange shockwave object for an SVG in layout test.

The existing backdrop-object.html test uses a shockwave object and tests
to see that the backdrop gets properly set in fullscreen mode. However,
when actually running the test, the shockwave object gets rendered as
a small text that says "Couldn't load plugin." and the rest is green.
With this CL, instead of a shockwave object, a simple SVG with a blue
circle is used. Seems cleaner. And with this change, this test is now
compatible with --enable-display-compositor-pixel-dump.

Bug: 891427,  667551 
Change-Id: Ia6e4cfc5a93cbad56b7b8c2f7d32f40966e5584f
Reviewed-on: https://chromium-review.googlesource.com/c/1258313
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598303}
[modify] https://crrev.com/2bff4f2f26def416abcffdf48a3b802c0ba11f52/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-object-expected.html
[modify] https://crrev.com/2bff4f2f26def416abcffdf48a3b802c0ba11f52/third_party/WebKit/LayoutTests/fullscreen/rendering/backdrop-object.html

Note: the list of failures has changed, and there is no longer a "these need triage" heading. The heading to search for is "See crbug.com/891427". In addition, links have been added to examples of most all failures.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c41b2d08296c7d720343f716641e40c9c2f68ad0

commit c41b2d08296c7d720343f716641e40c9c2f68ad0
Author: Mason Freed <masonfreed@chromium.org>
Date: Fri Oct 26 17:20:21 2018

Enable display compositor pixel dumps by default.

SHERIFFS: PLEASE DO NOT REVERT THIS CL BECAUSE OF A SMALL AMOUNT OF LAYOUT
TEST FLAKINESS. If a few layout tests begin to show flakiness after this CL
lands, please add them to TestExpectations and email me (masonfreed@) to
investigate. Though I tried to identify all potentially flaky tests, a few
may have slipped through.

With this CL, the --enable-display-compositor-pixel-dump flag becomes the default
for content_shell. With this flag in place, layout test pixel dumps are performed
from the browser side, instead of from the renderer side. Note that to avoid a
significant amount of layout test flakiness, another change was also made to
not add the --run-all-compositor-stages-before-draw flag by default. There is
a bug (crbug.com/894613) tracking that problem separately.

With the flip of this switch, several modifications had to be made to the
TestExpectations file. First, there are a number of tests that change their
appearance slightly when being captured from the browser, and these tests need
to be rebaselined. These are summarized below, and will be rebaselined as a
separate CL, once this one lands and has had time to stabilize.

These bugs track the items added to TestExpectations:
 - crbug.com/887140: HDR support
 -  crbug.com/881040 : Media controls now contain an overflow menu.
 -  crbug.com/667551 : A bunch of tests are listed under this bug, and just
                     require rebaselining to fix non-material single-pixel
                     antialiasing failures.
 - crbug.com/891427: These either start failing, or become flaky, when the
                     --enable-display-compositor-pixel-dump flag is enabled.
                     They need to be debugged prior to re-enabling.
 -  crbug.com/895556 : These tests double their background size when the flag
                     is enabled. They need to be fixed or rebaselined.

Bug:  667551 , 891427,  881040 , 887140, 894613,  895556 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I46946e6377f659c9dedc0dfaa20e7658e8cc519d
Reviewed-on: https://chromium-review.googlesource.com/c/1213864
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603127}
[modify] https://crrev.com/c41b2d08296c7d720343f716641e40c9c2f68ad0/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/c41b2d08296c7d720343f716641e40c9c2f68ad0/docs/testing/writing_layout_tests.md
[modify] https://crrev.com/c41b2d08296c7d720343f716641e40c9c2f68ad0/third_party/WebKit/LayoutTests/TestExpectations

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b66f278b8f7b927578005ef1f3c44aa6128228c

commit 2b66f278b8f7b927578005ef1f3c44aa6128228c
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Oct 29 08:13:28 2018

Suppress layout test failures

This failure happened due to https://chromium-review.googlesource.com/c/chromium/src/+/1213864,
and there are a test that was not added at that time. This CL adds this.

TBR=grunell@chromium.org

Bug: 891427
Change-Id: I850c3c8a390e75d3a6b4234cf1c1f5fbf379838e
Reviewed-on: https://chromium-review.googlesource.com/c/1303319
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603438}
[modify] https://crrev.com/2b66f278b8f7b927578005ef1f3c44aa6128228c/third_party/WebKit/LayoutTests/TestExpectations

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f79bd5bc7893e50ad7178fc28ec04a39278be090

commit f79bd5bc7893e50ad7178fc28ec04a39278be090
Author: Henrik Grunell <grunell@chromium.org>
Date: Mon Oct 29 10:00:51 2018

Disable flaky virtual/threaded/animations/invisible-composited-animations-prevent-scroll.html.

TBR=masonfreed@chromium.org

Bug: 891427,  899609 
Change-Id: Idb7a9501c40d008df9b02b7a1626579466fa2889

No-Try: true
Change-Id: Idb7a9501c40d008df9b02b7a1626579466fa2889
Reviewed-on: https://chromium-review.googlesource.com/c/1303361
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603445}
[modify] https://crrev.com/f79bd5bc7893e50ad7178fc28ec04a39278be090/third_party/WebKit/LayoutTests/TestExpectations

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c8bf2a26050e4b343bc38cac260849bd5c758bb

commit 4c8bf2a26050e4b343bc38cac260849bd5c758bb
Author: Henrik Grunell <grunell@chromium.org>
Date: Mon Oct 29 11:28:54 2018

Disable flaky virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-nested-divs-forbidden.html.

TBR=masonfreed@chromium.org

Bug: 891427,  899548 
Change-Id: I044b5f63c84ec3a0761302f4dfc8d96f694ccbdf

No-Try: true
Change-Id: I044b5f63c84ec3a0761302f4dfc8d96f694ccbdf
Reviewed-on: https://chromium-review.googlesource.com/c/1304414
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603455}
[modify] https://crrev.com/4c8bf2a26050e4b343bc38cac260849bd5c758bb/third_party/WebKit/LayoutTests/TestExpectations

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85b9228009a8816af4a33d76b18057ccc52d5f35

commit 85b9228009a8816af4a33d76b18057ccc52d5f35
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Tue Oct 30 04:54:21 2018

disable virtual/fractional_scrolling/fast/scrolling/editor-command-scroll-page-scale.html

TBR=masonfreed@chromium.org

Bug: 891427
Change-Id: Ifaf011a3dcde7f6a0fd4a9f2e5828285c2e08f46
Reviewed-on: https://chromium-review.googlesource.com/c/1306940
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603790}
[modify] https://crrev.com/85b9228009a8816af4a33d76b18057ccc52d5f35/third_party/WebKit/LayoutTests/TestExpectations

 Issue 900081  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa4418ef6b77ce043b20153a1d026d6987b5ed18

commit fa4418ef6b77ce043b20153a1d026d6987b5ed18
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Tue Oct 30 09:22:45 2018

[Picture-in-Picture] Clean video-surface-layer virtual tests.

Now that display compositor pixel dumps becomes the default for
content_shell, layout test pixel dumps are performed from the browser
side, instead of from the renderer side. This allows us to clean
Picture-in-Picture tests that were executed with some flags to enable
it.

In particular, this CL removes 3 virtual video-surface-layer test
suites:
- external/wpt/picture-in-picture,
- external/wpt/feature-policy,
- http/tests/devtools/sources/debugger-breakpoints.

It also clean SlowTests and TestExpectations.

Bug: 891427
Change-Id: Ib74f042ad0024e4a10603996026b2abf3862518a
Reviewed-on: https://chromium-review.googlesource.com/c/1303364
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603842}
[modify] https://crrev.com/fa4418ef6b77ce043b20153a1d026d6987b5ed18/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/fa4418ef6b77ce043b20153a1d026d6987b5ed18/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/fa4418ef6b77ce043b20153a1d026d6987b5ed18/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/cfa60baf92a5606c22365b9db8b78ef836c19322/third_party/WebKit/LayoutTests/external/wpt/picture-in-picture/idlharness.window-expected.txt
[delete] https://crrev.com/cfa60baf92a5606c22365b9db8b78ef836c19322/third_party/WebKit/LayoutTests/virtual/video-surface-layer/external/wpt/feature-policy/README.txt
[delete] https://crrev.com/cfa60baf92a5606c22365b9db8b78ef836c19322/third_party/WebKit/LayoutTests/virtual/video-surface-layer/external/wpt/picture-in-picture/README.txt
[delete] https://crrev.com/cfa60baf92a5606c22365b9db8b78ef836c19322/third_party/WebKit/LayoutTests/virtual/video-surface-layer/external/wpt/picture-in-picture/idlharness.window-expected.txt
[delete] https://crrev.com/cfa60baf92a5606c22365b9db8b78ef836c19322/third_party/WebKit/LayoutTests/virtual/video-surface-layer/http/tests/devtools/sources/debugger-breakpoints/README.txt
[delete] https://crrev.com/cfa60baf92a5606c22365b9db8b78ef836c19322/third_party/WebKit/LayoutTests/virtual/video-surface-layer/http/tests/devtools/sources/debugger-breakpoints/picture-in-picture-event-listener-breakpoints-expected.txt

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92c061d07915cc7d27db2fa65c69566e6a95c67c

commit 92c061d07915cc7d27db2fa65c69566e6a95c67c
Author: Owen Min <zmin@chromium.org>
Date: Tue Oct 30 19:59:20 2018

Disable feature-policy-frame-policy-allowed-for-all.https.sub.html

Disable tests on Mac10.12 and Win7

Bug:  899890 , 891427, 626703
Change-Id: Iaf47b38dcf45f5fce734325450609a10a9c5d712
Tbr: masonfreed@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1308413
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603991}
[modify] https://crrev.com/92c061d07915cc7d27db2fa65c69566e6a95c67c/third_party/WebKit/LayoutTests/TestExpectations

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e751123495f6b0dbab52400500ef730d035d5920

commit e751123495f6b0dbab52400500ef730d035d5920
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Thu Nov 01 15:51:25 2018

[Picture-in-Picture] Re-enable devtools test.

This CL is a follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/1303364

Bug: 891427
Change-Id: Ie3075933134463107e43d2f452cc025405ba19c5
Reviewed-on: https://chromium-review.googlesource.com/c/1307394
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#604595}
[modify] https://crrev.com/e751123495f6b0dbab52400500ef730d035d5920/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/e751123495f6b0dbab52400500ef730d035d5920/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/picture-in-picture-event-listener-breakpoints-expected.txt

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f889e44367898265df3c75734e61f1142599ef54

commit f889e44367898265df3c75734e61f1142599ef54
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Wed Nov 14 04:35:31 2018

layout tests: Fix some flakes with --enable-display-compositor-pixel-dump

A number of layout tests requests a testRunner.capturePixelsAsyncThen().
When not using the display-compositor for pixel-dumps, this triggers a
complete composition (i.e. this triggers a commit, raster, frame
submission, and processing in the display compositor). The tests that
use the testRunner.capturePixelsAsyncThen(callback) API expects these
steps to be completed before the callback is run. However, when using the
display-compositor for pixel-dumps, it immediately triggers the callback
without doing any of these steps. This caused a bunch of tests to fail,
or become flaky, when --enable-display-compositor-pixel-dump became the
default.

This patch fixes the flakiness, by making sure the callback is run only
after all the required steps have been performed. This is done by forcing
a redraw, and requesting a presentation-timestamp from viz. This does not
actually fix the readback itself, i.e. the pixels returned to the
callback is still invalid. However, this does fix the timing of running
the callback. That is sufficient to fix a number of the existing flaky
tests.

Bug: 891427
Change-Id: Ic09db1c3a0a410b2d5687999d7144260df7ea272
Reviewed-on: https://chromium-review.googlesource.com/c/1322364
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607906}
[modify] https://crrev.com/f889e44367898265df3c75734e61f1142599ef54/content/renderer/gpu/layer_tree_view.cc
[modify] https://crrev.com/f889e44367898265df3c75734e61f1142599ef54/content/renderer/gpu/layer_tree_view.h
[modify] https://crrev.com/f889e44367898265df3c75734e61f1142599ef54/content/shell/test_runner/test_runner.cc
[modify] https://crrev.com/f889e44367898265df3c75734e61f1142599ef54/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/f889e44367898265df3c75734e61f1142599ef54/third_party/blink/public/platform/web_layer_tree_view.h
[modify] https://crrev.com/f889e44367898265df3c75734e61f1142599ef54/third_party/blink/public/web/web_widget.h
[modify] https://crrev.com/f889e44367898265df3c75734e61f1142599ef54/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/f889e44367898265df3c75734e61f1142599ef54/third_party/blink/renderer/core/exported/web_view_impl.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/176dd221f205a9866e2a78f6b3c044a0b69b0cae

commit 176dd221f205a9866e2a78f6b3c044a0b69b0cae
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Wed Nov 14 05:42:13 2018

layout-tests: Re-enable ~30 more flaky tests.

After the fix in crrev.com/c/1322364, a bunch of tests that use the
testRunner.capturePixelsAsyncThen() API can be turned back on.

BUG=891427

Change-Id: Ice7d7b5f4dd0e0096363820cd4433ce0404ec83e
Reviewed-on: https://chromium-review.googlesource.com/c/1330993
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607915}
[modify] https://crrev.com/176dd221f205a9866e2a78f6b3c044a0b69b0cae/third_party/WebKit/LayoutTests/TestExpectations

 Issue 918236  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82d8267d87bd9054c31c30dd5f2b1b43677483a1

commit 82d8267d87bd9054c31c30dd5f2b1b43677483a1
Author: Balazs Engedy <engedy@chromium.org>
Date: Mon Dec 31 15:20:11 2018

Disable flaky touch-gesture-scroll-listbox.html test.

Bug: 891427
Change-Id: I0a3e53ee9e3b6dbe5989adf4286ce2cbfef3ef59
TBR: sahel@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1392945
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619310}
[modify] https://crrev.com/82d8267d87bd9054c31c30dd5f2b1b43677483a1/third_party/blink/web_tests/TestExpectations

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08aed290f42041ab29fc82ef6e127c33e2871b47

commit 08aed290f42041ab29fc82ef6e127c33e2871b47
Author: Kevin McNee <mcnee@chromium.org>
Date: Mon Jan 21 18:02:07 2019

Address flaky desktop touchscreen synthetic pinch zoom gesture tests

The lenient versions of these tests were missing a call to
waitForCompositorCommit after the gesture which the full versions of
the tests have.

We also clean up the TestExpectations for these synthetic_gestures tests
as some of the entries appear to no longer be an issue.

Bug: 922508,  787615 , 891427, 882975
Change-Id: Idf084b3651e74bbbfc337a73ba8223aa8db8d3a3
Reviewed-on: https://chromium-review.googlesource.com/c/1418522
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624613}
[modify] https://crrev.com/08aed290f42041ab29fc82ef6e127c33e2871b47/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/08aed290f42041ab29fc82ef6e127c33e2871b47/third_party/blink/web_tests/virtual/threaded/synthetic_gestures/synthetic-pinch-zoom-gesture.js