New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 891416 link

Starred by 1 user
Status: Fixed
Owner:
manucornet@chromium.org
Closed: Oct 24
Cc:
█ yoshiki@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Shelf animation is weird when it is placed on left-side

Project Member Reported by yoshiki@chromium.org, Oct 2 
Chrome Version: latest canary (71.0.3565.0)

What steps will reproduce the problem?
(1) Change the shelf position to "left"
(2) Touch a finger on the shelf
(3) Keeping the finger on the monitor, move the finger to right

What is the expected result?
- The circle should move along with the shelf
- No junk is observed

What happens instead?
- The circle doesn't move along with the shelf
- Junks (vertical black lines?) are observed around the round at the top of the shelf



Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
IMG_5143.MOV
6.3 MB View Download

Comment 1 by newcomer@chromium.org, Oct 2

Summary: Shelf animation is wired when it is placed on left-side (was: Launcher animation is wired when it is placed on left-side)

Comment 2 by manucornet@chromium.org, Oct 3

Summary: Shelf animation is weird when it is placed on left-side (was: Shelf animation is wired when it is placed on left-side)

Comment 3 by kaznacheev@chromium.org, Oct 16

Labels: -M-71 M-72

Comment 4 by manucornet@chromium.org, Oct 19

Status: Started (was: Assigned)

Comment 7 by manucornet@chromium.org, Oct 24

Status: Fixed (was: Started)
Project Member

Comment 8 by cr-audit...@appspot.gserviceaccount.com, Oct 25

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8

Commit: 62dcf48b9ecd4ac3b24667a133b7c373cc296bb8
Author: manucornet@chromium.org
Commiter: manucornet@chromium.org
Date: 2018-10-25 09:41:55 +0000 UTC

CrOS shelf: use translation for auto-hide instead of altering size

TBR=manucornet@chromium.org

(cherry picked from commit ee02be48c59260a48c98ebf3c9a58e1a5dd2b68e)

Bug:  891416 , 886622 , 888205 , 887733 ,881684,822477
Change-Id: Id187d692caf7b9ca8ce4ecee2206dc6420c343c4
Reviewed-on: https://chromium-review.googlesource.com/c/1290056
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602201}
Reviewed-on: https://chromium-review.googlesource.com/c/1298945
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#314}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 25

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8

commit 62dcf48b9ecd4ac3b24667a133b7c373cc296bb8
Author: Manu Cornet <manucornet@chromium.org>
Date: Thu Oct 25 09:41:55 2018

CrOS shelf: use translation for auto-hide instead of altering size

TBR=manucornet@chromium.org

(cherry picked from commit ee02be48c59260a48c98ebf3c9a58e1a5dd2b68e)

Bug:  891416 , 886622 , 888205 , 887733 ,881684,822477
Change-Id: Id187d692caf7b9ca8ce4ecee2206dc6420c343c4
Reviewed-on: https://chromium-review.googlesource.com/c/1290056
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602201}
Reviewed-on: https://chromium-review.googlesource.com/c/1298945
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#314}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8/ash/shelf/shelf_constants.h
[modify] https://crrev.com/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8/ash/system/toast/toast_manager_unittest.cc
►

Sign in to add a comment