New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 891412 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Issue for the metrics for test heuristic analysis

Project Member Reported by chanli@chromium.org, Oct 2

Issue description

The metrics was collected at step level, but when an analysis is aborted, we don't have enough information to decide which step actually causes the analysis to abort.

Currently we should remove the step level info for failed heuristic analyses. So that the alert will not be triggered for a single failed analysis anymore.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/249ed32ed0461bbdff25573efcb38c12b3776b12

commit 249ed32ed0461bbdff25573efcb38c12b3776b12
Author: Chan <chanli@chromium.org>
Date: Tue Oct 09 02:25:29 2018

[Findit] Only record once for a completed test heuristic analysis.

The metrics was collected at step level, but when an analysis is aborted, we don't have enough information to decide which step actually causes the analysis to abort. So we should not include step level info to the metrics for now. Later when we change the way to trigger test failure analyses, we can add the step level info then.

Bug: 891412
Change-Id: Ia00dece7576864a839896273103beffda666f52a
Reviewed-on: https://chromium-review.googlesource.com/c/1257573
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18168}
[modify] https://crrev.com/249ed32ed0461bbdff25573efcb38c12b3776b12/appengine/findit/pipelines/test_failure/analyze_test_failure_pipeline.py
[modify] https://crrev.com/249ed32ed0461bbdff25573efcb38c12b3776b12/appengine/findit/services/test_failure/test_failure_analysis.py
[modify] https://crrev.com/249ed32ed0461bbdff25573efcb38c12b3776b12/appengine/findit/services/test_failure/test/test_failure_analysis_test.py
[modify] https://crrev.com/249ed32ed0461bbdff25573efcb38c12b3776b12/appengine/findit/pipelines/test_failure/test/analyze_test_failure_pipeline_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4aef31f844fca7832d065454eecb6ed22a071bfc

commit 4aef31f844fca7832d065454eecb6ed22a071bfc
Author: Chan <chanli@chromium.org>
Date: Mon Oct 15 23:22:31 2018

[Findit] In consistent test failure analysis, record try job state change per analysis and swarming task state change per step.

This should fix https://pantheon.corp.google.com/errors/CK2mzPra7rS2lgE?time=P30D&project=findit-for-me

Traceback:
TypeError: RecordTestFailureAnalysisStateChange() takes exactly 4 arguments (6 given)
at OnSwarmingTaskCompleted (/base/data/home/apps/s~findit-for-me/waterfall-backend:18363-0342663.413293638472577070/services/test_failure/test_swarming.py:240)
at OnSwarmingTaskStateChanged (/base/data/home/apps/s~findit-for-me/waterfall-backend:18363-0342663.413293638472577070/services/test_failure/test_swarming.py:262)

Bug: 891412
Change-Id: Id78d0952be108d9b681f82a4badffc1976159a89
Reviewed-on: https://chromium-review.googlesource.com/c/1281995
Commit-Queue: Chan Li <chanli@chromium.org>
Auto-Submit: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18334}
[modify] https://crrev.com/4aef31f844fca7832d065454eecb6ed22a071bfc/appengine/findit/services/test_failure/test/test_try_job_test.py
[modify] https://crrev.com/4aef31f844fca7832d065454eecb6ed22a071bfc/appengine/findit/services/test_failure/test/test_swarming_test.py
[modify] https://crrev.com/4aef31f844fca7832d065454eecb6ed22a071bfc/appengine/findit/services/test_failure/test_try_job.py
[modify] https://crrev.com/4aef31f844fca7832d065454eecb6ed22a071bfc/appengine/findit/services/test_failure/test_swarming.py

Sign in to add a comment