1. Removed advanced label for Change printer options and change button label to Advanced printer options 2. Sentence case for Pages per sheet label (currently it is Pages Per Sheet)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45494050d3c3cd2c17cbffb2b32fc0c288da283d commit 45494050d3c3cd2c17cbffb2b32fc0c288da283d Author: rbpotter <rbpotter@chromium.org> Date: Wed Oct 03 19:51:16 2018 Print Preview Refresh: Address UI review comments (1) Increase line height for destinations items (2) Remove "Advanced" label for printer options button (3) Remove margin on paper-icon-button so Print with system dialog... does not wrap (for English + normal font size) (4) Change pages per sheet label to sentence case (5) Fix alignment of "Destinations" label with printer names, particularly for printers that do not have a status/location displayed. Bug: 891375 , 891378 , 891379 , 891395 , 891577 Change-Id: I13fbcd167e2e9ee513ef056ce5c9e471248dd3d8 Reviewed-on: https://chromium-review.googlesource.com/c/1257370 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#596332} [modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/app/printing_strings.grdp [modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/advanced_options_settings.html [modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/app.html [modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/destination_dialog.html [modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/destination_list.html [modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/destination_list.js [modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/destination_list_item.html [modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/destination_settings.html [modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/link_container.html [modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/pages_settings.html [modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/print_preview_shared_css.html [modify] https://crrev.com/45494050d3c3cd2c17cbffb2b32fc0c288da283d/chrome/browser/resources/print_preview/new/settings_section.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed27ffba70b0fff2a21628074ced60c81e88489d commit ed27ffba70b0fff2a21628074ced60c81e88489d Author: rbpotter <rbpotter@chromium.org> Date: Thu Oct 04 23:03:14 2018 Print Preview Refresh: Change advanced button text As requested by UI review. Bug: 891379 Change-Id: I0f5d69300852a4a8cae191684ceddb2c5fbfaa15 Reviewed-on: https://chromium-review.googlesource.com/c/1262431 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#596904} [modify] https://crrev.com/ed27ffba70b0fff2a21628074ced60c81e88489d/chrome/app/printing_strings.grdp [modify] https://crrev.com/ed27ffba70b0fff2a21628074ced60c81e88489d/chrome/browser/resources/print_preview/new/advanced_options_settings.html [modify] https://crrev.com/ed27ffba70b0fff2a21628074ced60c81e88489d/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
Comment 1 by thestig@chromium.org
, Oct 2