Keyboard shortcuts stop working after window minimization |
|||||||||||
Issue descriptionChrome Version: 70.0.3538.35 (Official Build) beta (64-bit) OS: Linux What steps will reproduce the problem? (1) Open Chrome, 2 separate windows, for different profiles. (Not sure if this is required) (2) Minimize one of the windows. (3) Maximize that same window, notice keyboard shortcuts stop working. (4) Closing the profile's window (or restarting Chrome) both fix this, until the window is minimized again. What is the expected result? All keyboard shortcuts still work. What happens instead? Shortcuts that affect Chrome stop working, like ctrl+1, alt+left arrow, ctrl+pg up, ctrl+tab. Things in the content area like ctrl+a to select text, or k/j to navigate through gmail emails still work.
,
Oct 4
2 profiles/windows are not needed. ctrl- shortcuts immediately break after clicking the minimize button on the Chrome window, whether or not Chrome is maximized (tested: xfwm4 on Debian 9.5). This doesn't repro when clicking a taskbar button to hide/show Chrome. The minimize button breaks more than just the keyboard shortcuts: Chrome is also no longer able to maximize properly after being moved.
,
Oct 4
Still repros on 70.0.3538.45
,
Oct 4
,
Oct 4
thomasanderson@: Can you take a quick look here to see what's up?
,
Oct 4
E-mail was disabled, resending: thomasanderson@: Can you take a quick look here to see what's up? Thanks!
,
Oct 4
Bisected to https://chromium.googlesource.com/chromium/src/+/02370c73936726c387f74cfbd5796f1667ae8a65
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5eb95eb3b3b001d8479b811a3280dbb0e36a3998 commit 5eb95eb3b3b001d8479b811a3280dbb0e36a3998 Author: Tom Anderson <thomasanderson@chromium.org> Date: Fri Oct 05 17:36:10 2018 X11: Make sure a window IsVisible() after it's unminimized This CL fixes a bug after [1]. The issue was setting "window_mapped_in_client_ = false" after XIconfiyWindow(). Despite the ICCCM spec requiring the state transition "Iconic -> Normal - The client should map the window" [2], the window is not actually placed in an unmapped state. Instead, the _NET_WM_STATE_HIDDEN property is set. [1] https://chromium.googlesource.com/chromium/src/+/02370c73936726c387f74cfbd5796f1667ae8a65 [2] ftp://www.x.org/pub/current/doc/xorg-docs/icccm/icccm.html BUG= 891376 R=sky Change-Id: Ibfcc66a54249bad8926d23cd4eabf1e6979f7d07 Reviewed-on: https://chromium-review.googlesource.com/c/1263431 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#597186} [modify] https://crrev.com/5eb95eb3b3b001d8479b811a3280dbb0e36a3998/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
,
Oct 5
,
Oct 5
,
Oct 5
This bug requires manual review: We are only 10 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 5
Have you confirmed this locally?
,
Oct 5
On a ToT build, yes.
,
Oct 8
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/483e3d23569078015ae70de476a4fe1a115df51c Commit: 483e3d23569078015ae70de476a4fe1a115df51c Author: thomasanderson@chromium.org Commiter: thomasanderson@chromium.org Date: 2018-10-08 16:57:54 +0000 UTC [Merge to M70] X11: Make sure a window IsVisible() after it's unminimized > This CL fixes a bug after [1]. The issue was setting "window_mapped_in_client_ > = false" after XIconfiyWindow(). Despite the ICCCM spec requiring the state > transition "Iconic -> Normal - The client should map the window" [2], the window > is not actually placed in an unmapped state. Instead, the _NET_WM_STATE_HIDDEN > property is set. > > [1] https://chromium.googlesource.com/chromium/src/+/02370c73936726c387f74cfbd5796f1667ae8a65 > [2] ftp://www.x.org/pub/current/doc/xorg-docs/icccm/icccm.html > > BUG= 891376 > R=sky > > Change-Id: Ibfcc66a54249bad8926d23cd4eabf1e6979f7d07 > Reviewed-on: https://chromium-review.googlesource.com/c/1263431 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597186} BUG= 891376 TBR=sky NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: I38cbb9fda36b72aba21155f47a2723713856bb85 Reviewed-on: https://chromium-review.googlesource.com/c/1268660 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#892} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/483e3d23569078015ae70de476a4fe1a115df51c commit 483e3d23569078015ae70de476a4fe1a115df51c Author: Tom Anderson <thomasanderson@chromium.org> Date: Mon Oct 08 16:57:54 2018 [Merge to M70] X11: Make sure a window IsVisible() after it's unminimized > This CL fixes a bug after [1]. The issue was setting "window_mapped_in_client_ > = false" after XIconfiyWindow(). Despite the ICCCM spec requiring the state > transition "Iconic -> Normal - The client should map the window" [2], the window > is not actually placed in an unmapped state. Instead, the _NET_WM_STATE_HIDDEN > property is set. > > [1] https://chromium.googlesource.com/chromium/src/+/02370c73936726c387f74cfbd5796f1667ae8a65 > [2] ftp://www.x.org/pub/current/doc/xorg-docs/icccm/icccm.html > > BUG= 891376 > R=sky > > Change-Id: Ibfcc66a54249bad8926d23cd4eabf1e6979f7d07 > Reviewed-on: https://chromium-review.googlesource.com/c/1263431 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597186} BUG= 891376 TBR=sky NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: I38cbb9fda36b72aba21155f47a2723713856bb85 Reviewed-on: https://chromium-review.googlesource.com/c/1268660 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#892} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/483e3d23569078015ae70de476a4fe1a115df51c/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
,
Oct 10
Tried verifying the fix on build without fix #70.0.3538.35 and build with fix #70.0.3538.54 on Ubuntu 14.04 by following steps as per comment #0, but unable to observe the difference between the both builds. Note:Tried with different profiles and same profile. Attached the screencast for reference. thomasanderson@@ - Could you please help in verifying the fix. Thanks..! |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by robliao@chromium.org
, Oct 4