New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 891374 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

ZipFiles/FilesAppBrowserTest.Test/zipCreateFileDrive was normalized as ZipFiles/FilesAppBrowserTest.Test?*

Project Member Reported by st...@chromium.org, Oct 2

Issue description

Page URL: https://findit-for-me.appspot.com/ranked-flakes

 Description:

ZipFiles/FilesAppBrowserTest.Test/* was normalized as ZipFiles/FilesAppBrowserTest.Test?*
 
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/cabfb4152833144f0db12d6957bc4b322f1786b6

commit cabfb4152833144f0db12d6957bc4b322f1786b6
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Fri Oct 05 16:56:44 2018

[Findit] Fix a gtest normalization bug

Previously, the regular expression used to normalize gtests assume that
the second parameter part can only be a number, however, it's not the
case, for example: ZipFiles/FilesAppBrowserTest.Test/zipCreateFileDrive
is a valid gtest name.

It is impossible to perfectly tell gtests apart from webkit_layout_tests,
for example, a/b.html can be both a valid type parameterized version of
a.html and a webkit_layout_tests, this CL also adds an option to pass
the step name to the normalize function to help identify the type of
the test.

Bug: 891374
Change-Id: Iebc76e36982c70d075b6fd7875a43c5b1af43b28
Reviewed-on: https://chromium-review.googlesource.com/c/1263419
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18101}
[modify] https://crrev.com/cabfb4152833144f0db12d6957bc4b322f1786b6/appengine/findit/libs/test/test_name_util_test.py
[modify] https://crrev.com/cabfb4152833144f0db12d6957bc4b322f1786b6/appengine/findit/model/flake/test/flake_test.py
[modify] https://crrev.com/cabfb4152833144f0db12d6957bc4b322f1786b6/appengine/findit/libs/test_name_util.py
[modify] https://crrev.com/cabfb4152833144f0db12d6957bc4b322f1786b6/appengine/findit/services/flake_failure/flake_report_util.py
[modify] https://crrev.com/cabfb4152833144f0db12d6957bc4b322f1786b6/appengine/findit/model/flake/flake.py
[modify] https://crrev.com/cabfb4152833144f0db12d6957bc4b322f1786b6/appengine/findit/services/flake_detection/detect_cq_false_rejection_flakes.py

Sign in to add a comment