New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 891373 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Do not show "Add card", "Add address" when Autofill is disabled

Project Member Reported by ftirelo@chromium.org, Oct 2

Issue description

Chrome Version: M71
OS: Android

On Android, we show an "Add card" or "Add address" button even if Autofill is disabled (Settings > Payment methods or Settings > Addresses and more).

We currently show it in a disabled state, but we should simply hide it as requested by UI review: https://docs.google.com/presentation/d/1kehLTBu_D46cixF4wftcnLqiiI60tu2Nx8OR_jzVVkM/edit?ts=5bb334f5#slide=id.g3f3356251e_0_4
 
Description: Show this description
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3a9a0585b6094591617f60e3e0a7d47c3082379

commit f3a9a0585b6094591617f60e3e0a7d47c3082379
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Tue Oct 02 20:51:39 2018

[AF] Do not show 'Add' button when toggle is disabled

This was suggested during UI review for finer-grained Autofill settings.

Screenshots in the bug.

Bug:  891373 
Change-Id: Ia14a9573e1ac0ffe010c98c38af7301dfb1b435d
Reviewed-on: https://chromium-review.googlesource.com/c/1257624
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595970}
[modify] https://crrev.com/f3a9a0585b6094591617f60e3e0a7d47c3082379/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPaymentMethodsFragment.java
[modify] https://crrev.com/f3a9a0585b6094591617f60e3e0a7d47c3082379/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java

Status: Fixed (was: Assigned)

Sign in to add a comment