New issue
Advanced search Search tips

Issue 891370 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 3
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Skip cookie check for origins when sending client hints

Project Member Reported by tbansal@chromium.org, Oct 2

Issue description

Skip cookie check for origins when sending client hints. The cookie check was initially added when there was plan to allow 3rd party origins to request client hints. Since client hints are now restricted to only first party origins, and client hints are already disabled for origins that do not have JavaScript permissions, this cookie check is considered redundant. Note that cookie check is not required by the fetch or client hints spec either.


https://bugs.chromium.org/p/chromium/issues/detail?id=853256#c21 and https://bugs.chromium.org/p/chromium/issues/detail?id=880806#c18 have more details.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0c1fc317df31881810430d0acd5907b5bd0130e

commit a0c1fc317df31881810430d0acd5907b5bd0130e
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Oct 03 16:14:52 2018

Skip cookie check for origins when sending client hints

Skip cookie check for origins when sending client hints.
The cookie check was initially added when there was plan to
allow 3rd party origins to request client hints.
Since client hints are now
restricted to only first party origins, and client hints are
already disabled for origins that do not have JavaScript permissions,
this cookie check is considered redundant. Note that cookie check is not
required by the fetch or client hints spec either.

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I080fa5257abba15724559a39b4b73ac4f2e12e3e
Bug:  891370 
Reviewed-on: https://chromium-review.googlesource.com/c/1253215
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596243}
[modify] https://crrev.com/a0c1fc317df31881810430d0acd5907b5bd0130e/chrome/browser/client_hints/client_hints.cc
[modify] https://crrev.com/a0c1fc317df31881810430d0acd5907b5bd0130e/chrome/browser/client_hints/client_hints.h
[modify] https://crrev.com/a0c1fc317df31881810430d0acd5907b5bd0130e/chrome/browser/client_hints/client_hints_browsertest.cc
[modify] https://crrev.com/a0c1fc317df31881810430d0acd5907b5bd0130e/chrome/browser/client_hints/client_hints_observer.cc
[modify] https://crrev.com/a0c1fc317df31881810430d0acd5907b5bd0130e/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/a0c1fc317df31881810430d0acd5907b5bd0130e/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Status: Fixed (was: Started)

Sign in to add a comment