Hide "Add" option when Autofill is disabled |
|||||||||||||
Issue descriptionChrome Version: M71 OS: Desktop On Desktop, we show an "Add" button even if Autofill is disabled (locations: chrome://settings/autofill for Addresses, chrome://settings/payments for Payment methods). We currently show it in a disabled state, but we should simply hide it as requested by UI review: https://docs.google.com/presentation/d/1kehLTBu_D46cixF4wftcnLqiiI60tu2Nx8OR_jzVVkM/edit?ts=5bb334f5#slide=id.g3f3356251e_0_4
,
Oct 2
,
Oct 2
,
Oct 2
,
Oct 2
Screenshots for crrev.com/c/1258046
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1cef206244b29575391e471c2a11a052d993bcbb commit 1cef206244b29575391e471c2a11a052d993bcbb Author: Fabio Tirelo <ftirelo@chromium.org> Date: Wed Oct 03 17:37:37 2018 [Autofill Settings] Hide 'Add' button when Autofill toggle is disabled Screenshots can be found in the bug. Bug: 891369 Change-Id: I206d89a1118cad0f65c17ba3cafee81998e3198c Reviewed-on: https://chromium-review.googlesource.com/1258046 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#596272} [modify] https://crrev.com/1cef206244b29575391e471c2a11a052d993bcbb/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html [modify] https://crrev.com/1cef206244b29575391e471c2a11a052d993bcbb/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.html [modify] https://crrev.com/1cef206244b29575391e471c2a11a052d993bcbb/chrome/test/data/webui/settings/autofill_section_test.js [modify] https://crrev.com/1cef206244b29575391e471c2a11a052d993bcbb/chrome/test/data/webui/settings/payments_section_test.js
,
Oct 3
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by ftirelo@chromium.org
, Oct 2