Swiping down on shelf minimizes all windows. |
||||
Issue descriptionWhat steps will reproduce the problem? (1) Enter tablet mode, homecher needs to be enabled. (2) Have a least one maximized window opened. (3) Press down on the top of shelf and swipe down and release. What is the expected result? Nothing. What happens instead? All windows opened will be closed.
,
Oct 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c035b3ff56f31954c6ac938d5e250d00b4d7a561 commit c035b3ff56f31954c6ac938d5e250d00b4d7a561 Author: Sammie Quon <sammiequon@google.com> Date: Mon Oct 15 23:34:35 2018 applist: Allow swiping up on shelf to show applist when autohide. Test: manual Bug: 881483 , 891366 Change-Id: I88c5d7a5d41f7ef4013c84debf5c4e963f891d21 Reviewed-on: https://chromium-review.googlesource.com/c/1279356 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599778} [modify] https://crrev.com/c035b3ff56f31954c6ac938d5e250d00b4d7a561/ash/app_list/app_list_controller_impl.cc [modify] https://crrev.com/c035b3ff56f31954c6ac938d5e250d00b4d7a561/ash/app_list/home_launcher_gesture_handler.cc [modify] https://crrev.com/c035b3ff56f31954c6ac938d5e250d00b4d7a561/ash/app_list/home_launcher_gesture_handler.h [modify] https://crrev.com/c035b3ff56f31954c6ac938d5e250d00b4d7a561/ash/app_list/home_launcher_gesture_handler_unittest.cc [modify] https://crrev.com/c035b3ff56f31954c6ac938d5e250d00b4d7a561/ash/shelf/shelf_layout_manager.cc
,
Oct 17
@Sammie does this CL fix the issue, or is there more to be done here? Thanks!
,
Oct 17
re#3- It fixes it, but we usually keep the bug open until merge is complete.
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5547e63d10a8dbaf60c00a170db6556f91f6ce8e commit 5547e63d10a8dbaf60c00a170db6556f91f6ce8e Author: Sammie Quon <sammiequon@google.com> Date: Wed Oct 17 16:57:13 2018 [merge to 71] applist: Allow swiping up on shelf to show applist when autohide. TBR=sammiequon@google.com (cherry picked from commit c035b3ff56f31954c6ac938d5e250d00b4d7a561) Test: manual Bug: 881483 , 891366 Change-Id: I88c5d7a5d41f7ef4013c84debf5c4e963f891d21 Reviewed-on: https://chromium-review.googlesource.com/c/1279356 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599778} Reviewed-on: https://chromium-review.googlesource.com/c/1286898 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#88} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/5547e63d10a8dbaf60c00a170db6556f91f6ce8e/ash/app_list/app_list_controller_impl.cc [modify] https://crrev.com/5547e63d10a8dbaf60c00a170db6556f91f6ce8e/ash/app_list/home_launcher_gesture_handler.cc [modify] https://crrev.com/5547e63d10a8dbaf60c00a170db6556f91f6ce8e/ash/app_list/home_launcher_gesture_handler.h [modify] https://crrev.com/5547e63d10a8dbaf60c00a170db6556f91f6ce8e/ash/app_list/home_launcher_gesture_handler_unittest.cc [modify] https://crrev.com/5547e63d10a8dbaf60c00a170db6556f91f6ce8e/ash/shelf/shelf_layout_manager.cc
,
Oct 17
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5547e63d10a8dbaf60c00a170db6556f91f6ce8e Commit: 5547e63d10a8dbaf60c00a170db6556f91f6ce8e Author: sammiequon@google.com Commiter: sammiequon@chromium.org Date: 2018-10-17 16:57:13 +0000 UTC [merge to 71] applist: Allow swiping up on shelf to show applist when autohide. TBR=sammiequon@google.com (cherry picked from commit c035b3ff56f31954c6ac938d5e250d00b4d7a561) Test: manual Bug: 881483 , 891366 Change-Id: I88c5d7a5d41f7ef4013c84debf5c4e963f891d21 Reviewed-on: https://chromium-review.googlesource.com/c/1279356 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599778} Reviewed-on: https://chromium-review.googlesource.com/c/1286898 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#88} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
||||
►
Sign in to add a comment |
||||
Comment 1 by sammiequon@chromium.org
, Oct 2