New issue
Advanced search Search tips

Issue 891333 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task

Blocked on:
issue 884675



Sign in to add a comment

Create a view controller for shortcuts

Project Member Reported by stkhapugin@chromium.org, Oct 2

Issue description

Create a view controller that displays 4 most visited tiles and 4 collection shortcut buttons 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46a8d7b93e45cf9137f66aff39a63cccb0486e53

commit 46a8d7b93e45cf9137f66aff39a63cccb0486e53
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Tue Oct 09 16:09:40 2018

Create the shortcuts view controller.

Creates and displays an empty shortcuts view controller.

Bug:  891333 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I74cd9b7d4df0e2d63c514b4fc4637cedeccaad86
Reviewed-on: https://chromium-review.googlesource.com/c/1256833
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597933}
[modify] https://crrev.com/46a8d7b93e45cf9137f66aff39a63cccb0486e53/ios/chrome/browser/ui/omnibox/popup/BUILD.gn
[modify] https://crrev.com/46a8d7b93e45cf9137f66aff39a63cccb0486e53/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_coordinator.mm
[modify] https://crrev.com/46a8d7b93e45cf9137f66aff39a63cccb0486e53/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.h
[modify] https://crrev.com/46a8d7b93e45cf9137f66aff39a63cccb0486e53/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.mm
[modify] https://crrev.com/46a8d7b93e45cf9137f66aff39a63cccb0486e53/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller_unittest.mm
[add] https://crrev.com/46a8d7b93e45cf9137f66aff39a63cccb0486e53/ios/chrome/browser/ui/omnibox/popup/shortcuts/BUILD.gn
[add] https://crrev.com/46a8d7b93e45cf9137f66aff39a63cccb0486e53/ios/chrome/browser/ui/omnibox/popup/shortcuts/shortcuts_coordinator.h
[add] https://crrev.com/46a8d7b93e45cf9137f66aff39a63cccb0486e53/ios/chrome/browser/ui/omnibox/popup/shortcuts/shortcuts_coordinator.mm
[add] https://crrev.com/46a8d7b93e45cf9137f66aff39a63cccb0486e53/ios/chrome/browser/ui/omnibox/popup/shortcuts/shortcuts_coordinator_unittest.mm
[add] https://crrev.com/46a8d7b93e45cf9137f66aff39a63cccb0486e53/ios/chrome/browser/ui/omnibox/popup/shortcuts/shortcuts_view_controller.h
[add] https://crrev.com/46a8d7b93e45cf9137f66aff39a63cccb0486e53/ios/chrome/browser/ui/omnibox/popup/shortcuts/shortcuts_view_controller.mm
[add] https://crrev.com/46a8d7b93e45cf9137f66aff39a63cccb0486e53/ios/chrome/browser/ui/omnibox/popup/shortcuts/shortcuts_view_controller_unittest.mm

Status: Fixed (was: Started)

Sign in to add a comment