New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 891332 link

Starred by 1 user
Status: Fixed
Owner:
crouleau@chromium.org
Closed: Oct 3
Cc:
perezju@chromium.org
█ dpranke@google.com
crouleau@chromium.org
jbudorick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 891747



Sign in to add a comment

A whole telemetry test shard fails with "UnboundLocalError: local variable 'rc' referenced before assignment"

Project Member Reported by nednguyen@chromium.org, Oct 2 
Log:
https://chrome-swarming.appspot.com/task?id=404db16cf363b910&refresh=10&show_raw=1

  File "/b/s/w/ir/testing/scripts/run_telemetry_benchmark_as_googletest.py", line 137, in run_benchmark
    rc = test_env.run_command_with_output(cmd, env=env, stdoutfile=stdoutfile)
  File "/b/s/w/ir/testing/scripts/../test_env.py", line 187, in run_command_with_output
    sys.stdout.write(reader.read())
UnicodeEncodeError: 'ascii' codec can't encode character u'\xd6' in position 253: ordinal not in range(128)
or_log._OnMessage:26  DevTools console [network]: Failed to load resource: the server responded with a status of 500 (Internal Server Error) http://www.b3.com.br/rb_8370fec7-c82e-413f-a2c6-777046ed9811?type=js&session=1%2464DA69F774A0F0043B18EEEE82E03F24&svrid=1&flavor=post&referer=http%3A%2F%2Fwww.b3.com.br%2Fpt_br%2F&visitID=HBPRCBLOGBMDPBFHLOJNUMIILDMFAWGM
(WARNING) 2018-10-02 06:12:09,955 inspector_log._OnMessage:26  DevTools console [network]: Failed to load resource: the server responded with a status of 500 (Internal Server Error) http://www.b3.com.br/rb_8370fec7-c82e-413f-a2c6-777046ed9811?type=js&session=1%2464DA69F774A0F0043B18EEEE82E03F24&svrid=1&flavor=post&referer=http%3A%2F%2Fwww.b3.com.br%2Fpt_br%2F&visitID=HBPRCBLOGBMDPBFHLOJNUMIILDMFAWGM
(WARNING) 2018-10-02 06:12:13,853 inspector_log._OnMessage:26  DevTools console [network]: Failed to load resource: the server responded with a status of 404 (Not Found) https://sp-mms.weather.com/aagaEBta3pleW96a2VweUV8QzcsZ2lpdXt0emVvakM3PDksZ2h2Q2xncnlrLHhrbGt4eGt4QyxwfEM4NDY0Pz42LGlqaUN9b3RqdX00ZXl2ZTRzeW00ZW90emt4dGdyNGlqaTcsbnhrbENuenp2eSs5Rys4TCs4TH1rZ3pua3g0aXVzKzhMLHorO0h-KztKQyE=
(INFO) 2018-10-02 06:12:25,699 chrome_tracing_agent.RecordClockSyncMarker:180  Chrome version: 3569
(INFO) 2018-10-02 06:12:25,699 chrome_tracing_agent._RemoveTraceConfigFile:294  Remove trace config file in /b/s/w/it1UazAC/tmpwDgtV2/chrome-trace-config.json
(INFO) 2018-10-02 06:12:33,284 trace_data.Serialize:186  Trace sizes in bytes: {'cpuSnapshots': 4042068, 'traceEvents': 210612163, 'telemetry': 674764}
(INFO) 2018-10-02 06:12:42,416 trace_data.Serialize:195  trace2html finished in 9.13 seconds.
(INFO) 2018-10-02 06:12:42,417 timeline_based_measurement._ComputeTimelineBasedMetrics:317  Starting to compute metrics on trace
Traceback (most recent call last):
  File "../../testing/scripts/run_performance_tests.py", line 277, in <module>
    sys.exit(main())
  File "../../testing/scripts/run_performance_tests.py", line 253, in main
    False, stories=stories) or return_code)
  File "../../testing/scripts/run_performance_tests.py", line 132, in execute_benchmark
    args, per_benchmark_args, is_histograms))
  File "/b/s/w/ir/testing/scripts/run_telemetry_benchmark_as_googletest.py", line 176, in run_benchmark
    if rc == 0:
UnboundLocalError: local variable 'rc' referenced before assignment

Comment 1 by crouleau@chromium.org, Oct 3

Blocking: 891747

Comment 2 by crouleau@chromium.org, Oct 3

Owner: crouleau@chromium.org
Status: Assigned (was: Untriaged)
Since this is making the perfbot sheriff rotation difficult (I'm the sheriff right now), I will just fix it.

Comment 3 by nedngu...@google.com, Oct 3

Cc: dpranke@google.com
I think we also need to fix /b/s/w/ir/testing/scripts/../test_env.py to be able to deal with unicode?

Comment 4 by crouleau@chromium.org, Oct 3 

Yes.  issue 891747  covers that.

I would like this issue to be limited in scope to the unbound variable error that I already sent out a fix for.  issue 891747  still requires an owner. Should be a quick fix for someone who understands character encodings and python
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8f5446356355e6c6d5309d931d020945436639c

commit e8f5446356355e6c6d5309d931d020945436639c
Author: Caleb Rouleau <crouleau@chromium.org>
Date: Wed Oct 03 19:15:09 2018

[Telemetry] Always set return code.

This fixes the exception:

  File "/b/s/w/ir/testing/scripts/run_telemetry_benchmark_as_googletest.py", line 176, in run_benchmark
    if rc == 0:
UnboundLocalError: local variable 'rc' referenced before assignment

TBR=nednguyen

Bug:  891332 
Change-Id: I81b8502f8f95bf8db070d8ccc062a343b062e880
Reviewed-on: https://chromium-review.googlesource.com/c/1258978
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596316}
[modify] https://crrev.com/e8f5446356355e6c6d5309d931d020945436639c/testing/scripts/run_telemetry_benchmark_as_googletest.py

Comment 6 by crouleau@chromium.org, Oct 3

Status: Fixed (was: Assigned)
►

Sign in to add a comment