New issue
Advanced search Search tips

Issue 891307 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task



Sign in to add a comment

Log which languages were added/removed in Explicit Ask

Project Member Reported by anthonyvd@chromium.org, Oct 2

Issue description

The Explicit ask prompt should log (in UMA) which languages were added and removed from the list by the user.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ac39e28b7858f44ee8a8fd2dafa0eb6c00a8c8b

commit 3ac39e28b7858f44ee8a8fd2dafa0eb6c00a8c8b
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Thu Oct 04 15:05:28 2018

Log in UMA the languages added/removed in the Explicit Language Ask

This CL adds 2 histograms that record languages added and removed from
Accept Languages by the user from the Explicit Language Ask prompt during
Android Chrome 2nd run.

Bug:  891307 
Change-Id: I1b6e8feb7e3d56f77c0381ec5870eb9694085b74
Reviewed-on: https://chromium-review.googlesource.com/c/1255575
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596669}
[modify] https://crrev.com/3ac39e28b7858f44ee8a8fd2dafa0eb6c00a8c8b/chrome/android/java/src/org/chromium/chrome/browser/language/LanguageAskPrompt.java
[modify] https://crrev.com/3ac39e28b7858f44ee8a8fd2dafa0eb6c00a8c8b/components/language/android/BUILD.gn
[add] https://crrev.com/3ac39e28b7858f44ee8a8fd2dafa0eb6c00a8c8b/components/language/android/android_language_metrics_bridge.cc
[add] https://crrev.com/3ac39e28b7858f44ee8a8fd2dafa0eb6c00a8c8b/components/language/android/java/src/org/chromium/components/language/AndroidLanguageMetricsBridge.java
[modify] https://crrev.com/3ac39e28b7858f44ee8a8fd2dafa0eb6c00a8c8b/tools/metrics/histograms/histograms.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4fff22511aa9aa039daa4e537e57d02c6140dbb

commit b4fff22511aa9aa039daa4e537e57d02c6140dbb
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Fri Oct 26 22:26:11 2018

Log events in the Explicit Language Ask prompt to UMA

Bug:  891307 
Change-Id: I9b3c2429dc9ebe96d3f06e904aaddfdb034c83f7
Reviewed-on: https://chromium-review.googlesource.com/c/1296809
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603219}
[modify] https://crrev.com/b4fff22511aa9aa039daa4e537e57d02c6140dbb/chrome/android/java/src/org/chromium/chrome/browser/language/LanguageAskPrompt.java
[modify] https://crrev.com/b4fff22511aa9aa039daa4e537e57d02c6140dbb/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/b4fff22511aa9aa039daa4e537e57d02c6140dbb/tools/metrics/histograms/histograms.xml

Labels: -Pri-3 Merge-Request-71 OS-Android Pri-1
Requesting merge for CL in #2
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 29

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-71 Merge-Approved-71
Merge approved to 71, branch 3578.
Cc: benmason@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 30

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81733436d0e9eef49df47e7ffa95b1fa3ff47223

commit 81733436d0e9eef49df47e7ffa95b1fa3ff47223
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Tue Oct 30 14:00:04 2018

Log events in the Explicit Language Ask prompt to UMA

Bug:  891307 
Change-Id: I9b3c2429dc9ebe96d3f06e904aaddfdb034c83f7
Reviewed-on: https://chromium-review.googlesource.com/c/1296809
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#603219}(cherry picked from commit b4fff22511aa9aa039daa4e537e57d02c6140dbb)
Reviewed-on: https://chromium-review.googlesource.com/c/1307575
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#388}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/81733436d0e9eef49df47e7ffa95b1fa3ff47223/chrome/android/java/src/org/chromium/chrome/browser/language/LanguageAskPrompt.java
[modify] https://crrev.com/81733436d0e9eef49df47e7ffa95b1fa3ff47223/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/81733436d0e9eef49df47e7ffa95b1fa3ff47223/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/81733436d0e9eef49df47e7ffa95b1fa3ff47223

Commit: 81733436d0e9eef49df47e7ffa95b1fa3ff47223
Author: anthonyvd@chromium.org
Commiter: anthonyvd@chromium.org
Date: 2018-10-30 14:00:04 +0000 UTC

Log events in the Explicit Language Ask prompt to UMA

Bug:  891307 
Change-Id: I9b3c2429dc9ebe96d3f06e904aaddfdb034c83f7
Reviewed-on: https://chromium-review.googlesource.com/c/1296809
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#603219}(cherry picked from commit b4fff22511aa9aa039daa4e537e57d02c6140dbb)
Reviewed-on: https://chromium-review.googlesource.com/c/1307575
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#388}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment