New issue
Advanced search Search tips
Starred by 5 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment
link

Issue 891303: chrome://omnibox refresh

Reported by manukh@chromium.org, Oct 2 Project Member

Issue description

Feature description:
Update the `chrome://omnibox` debug page to more closely resemble what is seen in the actual omnibox; include additional helpful information, such as http requests and responses from search suggestion providers; and improve ui.

Design doc: https://docs.google.com/document/d/1hTiJ1dxI6UdXbQtktLcp6h_rS-q7ECXB34RQ1QsgbBo/edit?pli=1#

Overview of appearance changes:
https://docs.google.com/document/d/1jhteNgqFSVLGAYiUsHohFdvpIbgPdtgHMJXcU9d_f5Q/edit#heading=h.y7hei8nlcd9i
 

Comment 1 by manukh@chromium.org, Oct 2

list of cl's already merged before this tacking issue was created:

-[[about:omnibox]: fix url for transition header](https://chromium-review.googlesource.com/c/chromium/src/+/1252010)

-[[chrome://omnibox]: create BrowseryProxy class to encapsulate communication with OmniboxPageHandler.](https://chromium-review.googlesource.com/c/chromium/src/+/1252324)

-[[about:omnibox] Order rendering functions from outer element to inner element.](https://chromium-review.googlesource.com/c/chromium/src/+/1249830)

-[[about-omnibox] Performance refactoring of omnibox.js: split refresh method, extract inlined dom elements, and improved html output clearing.](https://chromium-review.googlesource.com/c/chromium/src/+/1246295)

-[[about-omnibox] minor html touchup.](https://chromium-review.googlesource.com/c/chromium/src/+/1243567)

-[[about-omnibox] auto submit on query change](https://chromium-review.googlesource.com/c/chromium/src/+/1241570)

-[[about-omnibox] formatting omnibox.js](https://chromium-review.googlesource.com/c/chromium/src/+/1239352)

-[[about:omnibox] changed check- and x- mark icons & styling (bold, font size 30) to be more visible.](https://chromium-review.googlesource.com/c/chromium/src/+/1226101)

Comment 2 by bugdroid1@chromium.org, Oct 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/924619f7c3a9c1294208a97d8cf25d5848d848ef

commit 924619f7c3a9c1294208a97d8cf25d5848d848ef
Author: manuk <manukh@chromium.org>
Date: Fri Oct 05 16:19:36 2018

[chrome:omnibox] clear previous outputs on making a new request.

A line was accidentally left out when moving code in the previous cl [1] resulting in outputs from the previous query not being cleared when making a new query when the `Show incomplete results` option was enabled.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1252324

Change-Id: I12f8465898171badff2e6c4f69fcbcaf121f680b
Bug: 891303
Reviewed-on: https://chromium-review.googlesource.com/c/1264815
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597156}
[modify] https://crrev.com/924619f7c3a9c1294208a97d8cf25d5848d848ef/chrome/browser/resources/omnibox/omnibox.js

Comment 3 by mpear...@chromium.org, Oct 5

drive-by comments about the UI doc (as it's not open to comments):

1.
fill_into_edit and inline_autocompletion are not the same thing; you cannot combine them into one column.  For example, they may differ even at the end.  For example, if I type "cs", I see no inline autocompletion, yet fill_into_edit shows "cs/".

2.
How does "expand on hover" work?  Does it stay expanded?  In particular, I often need to look down a list of (long) URLs.  I need some way to for the URLs to all be/stay displayed at once.  (This means that sometimes I definitely need the horizontal scroll bar.)


Otherwise the new draft UI looks great to me!

Comment 4 by manukh@chromium.org, Oct 5

the doc should be open to comment/edits now.

1. that example would work fine, and be displayed as 'cs/'. My assumption is that inline auto-completion will either be blank or a suffix of fill-into-edit. So we can show the fill-into-edit, and then box (or somehow indicate) the inline portion. There's a fallback for if in the future we encounter a match where that assumption does not hold, we show them separately.

2. Justin had the same thoughts and suggested adding a 'expand all elisions' option. Also, if we get around to allowing user to specifically select which columns to show/hide, we could add a third option show-elided/show-unelided/hide. I'll add both thoughts to the the doc.

Comment 5 by mpear...@chromium.org, Oct 5

> There's a fallback for if in the future we encounter a match
> where that assumption does not hold, we show them separately.
I'm glad you'll have a fallback.  I don't like baking assumptions about what can happen into debugging tools. :-)

Comment 6 by bugdroid1@chromium.org, Oct 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60b51e83048e477af0aab0e2848b568547a9485c

commit 60b51e83048e477af0aab0e2848b568547a9485c
Author: manuk <manukh@chromium.org>
Date: Tue Oct 09 19:35:43 2018

[chrome:omnibox] Make boolean indicators copy-able.

Previously, the boolean indicators on the page were ascii icons and therefore copyable as normal text. Since we changed to using svg vectors for clearer indicators, they are no longer copyable through normal interaction (e.g. select and press ctrl+c). This cl adds invisible (font size 0) true/false text to each indicator for copying purposes.

Bug: 891303
Change-Id: I64ee5533f2d5415120d4cca6c85566d43b4f47d7
Reviewed-on: https://chromium-review.googlesource.com/c/1271359
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598039}
[modify] https://crrev.com/60b51e83048e477af0aab0e2848b568547a9485c/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/60b51e83048e477af0aab0e2848b568547a9485c/chrome/browser/resources/omnibox/omnibox.js

Comment 7 by bugdroid1@chromium.org, Oct 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32f66b1b681c1f63ffb8fbaef34b614a03c0a8c9

commit 32f66b1b681c1f63ffb8fbaef34b614a03c0a8c9
Author: manuk <manukh@chromium.org>
Date: Wed Oct 10 21:02:42 2018

[chrome:omnibox]: create OmniboxInputs and OmniboxOutput custom HTML elements to encapsulate interaction with the DOM.

This CL is the first step to refactoring JS<->HTML communications. Actually refactoring output generation will be in a separate CL. More specifically, OmniboxOutput is a shell filled with <p> elements generated from the JS directly via document.createElement. In the upcoming CL's, this will be changed so that OmniboxOutput consists of custom elements as well.

Bug: 891303
Change-Id: I7b72ce3817aa7ad345f7c1ff7919668fd51aa4f0
Reviewed-on: https://chromium-review.googlesource.com/c/1257546
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598498}
[modify] https://crrev.com/32f66b1b681c1f63ffb8fbaef34b614a03c0a8c9/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/32f66b1b681c1f63ffb8fbaef34b614a03c0a8c9/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/32f66b1b681c1f63ffb8fbaef34b614a03c0a8c9/chrome/browser/resources/omnibox/omnibox.js

Comment 8 by bugdroid1@chromium.org, Oct 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94008c3eed9678c066db3a066f426a06579889e3

commit 94008c3eed9678c066db3a066f426a06579889e3
Author: manuk <manukh@chromium.org>
Date: Tue Oct 16 15:29:41 2018

[chrome:omnibox] Extract each Custom Element to individual JS file.

OmniboxElement, OmniboxInputs, and OmniboxOutput

Bug: 891303
Change-Id: I9de04903beddab6638e379227ae714801ad65991
Reviewed-on: https://chromium-review.googlesource.com/c/1281164
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599993}
[modify] https://crrev.com/94008c3eed9678c066db3a066f426a06579889e3/chrome/browser/browser_resources.grd
[modify] https://crrev.com/94008c3eed9678c066db3a066f426a06579889e3/chrome/browser/resources/omnibox/BUILD.gn
[modify] https://crrev.com/94008c3eed9678c066db3a066f426a06579889e3/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/94008c3eed9678c066db3a066f426a06579889e3/chrome/browser/resources/omnibox/omnibox.js
[add] https://crrev.com/94008c3eed9678c066db3a066f426a06579889e3/chrome/browser/resources/omnibox/omnibox_element.js
[add] https://crrev.com/94008c3eed9678c066db3a066f426a06579889e3/chrome/browser/resources/omnibox/omnibox_inputs.js
[add] https://crrev.com/94008c3eed9678c066db3a066f426a06579889e3/chrome/browser/resources/omnibox/omnibox_output.js
[modify] https://crrev.com/94008c3eed9678c066db3a066f426a06579889e3/chrome/browser/ui/webui/omnibox/omnibox_ui.cc

Comment 9 by bugdroid1@chromium.org, Oct 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96dd36a5de5f945622e808a91c1cc1a560a87e3a

commit 96dd36a5de5f945622e808a91c1cc1a560a87e3a
Author: manuk <manukh@chromium.org>
Date: Thu Oct 18 18:03:06 2018

[chrome:omnibox] Create class to track and manage responses from C++ AutocompleteController.

Previously, BrowserProxy kept track of autocomplete results, while the static global functions `refreshAllResults` and `refreshNewResult` initialized a chain of global static functions to render them. Now, instead the new OutputData class keeps track of the results and encapsulates `refreshAllResults` and `refreshNewResult` in order to remove all extraneous from BrowserProxy.

Bug: 891303
Change-Id: I5f3477d3b74c001e975a9dd63ef8199f47359052
Reviewed-on: https://chromium-review.googlesource.com/c/1287047
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600823}
[modify] https://crrev.com/96dd36a5de5f945622e808a91c1cc1a560a87e3a/chrome/browser/resources/omnibox/omnibox.js

Comment 10 by bugdroid1@chromium.org, Oct 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/750982a49afe03f74cc547de292a17dd24edae96

commit 750982a49afe03f74cc547de292a17dd24edae96
Author: manuk <manukh@chromium.org>
Date: Thu Oct 18 18:08:15 2018

[chrome:omnibox] 2 variable renamed for consistency.

The global variable cursorPositionUsed was renamed to cursorPosition in order to match the name in the C++ files. Similarly, PresentationInfoRecord.urlLabelForHeader was renamed to url in order to match the parameter name and for brevity.

Bug: 891303
Change-Id: Icce59c31e09824b01bb1cac3a5c542bc8267cf7d
Reviewed-on: https://chromium-review.googlesource.com/c/1287100
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600825}
[modify] https://crrev.com/750982a49afe03f74cc547de292a17dd24edae96/chrome/browser/resources/omnibox/omnibox.js

Comment 11 by bugdroid1@chromium.org, Oct 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c1b499d39b560836924662a6cbe49b3679d4c97

commit 4c1b499d39b560836924662a6cbe49b3679d4c97
Author: manuk <manukh@chromium.org>
Date: Fri Oct 26 22:35:24 2018

[chrome:omnibox]: Refactoring HTML generation part 1/3, create OutputMatch helper class.

This is the first of 3 CL's to replace the global static helper functions which manipulate the DOM with classes. In this CL, we:

- Replaced the functions createCellForPropertyAndRemoveProperty and addResultTableToOutput with OutputMatch, which is responsible for generating individual HTML rows from individual omnibox matches.

- Moved the data class PresentationInfoRecord and the constants array of PresentationInfoRecord's PROPERTY_OUTPUT_ORDER from omnibox.js to omnibox_output.js as that's where it's now used.

Bug: 891303
Change-Id: If653e16763a3956b0576bf677ede1570626007d7
Reviewed-on: https://chromium-review.googlesource.com/c/1293757
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603225}
[modify] https://crrev.com/4c1b499d39b560836924662a6cbe49b3679d4c97/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/4c1b499d39b560836924662a6cbe49b3679d4c97/chrome/browser/resources/omnibox/omnibox.js
[modify] https://crrev.com/4c1b499d39b560836924662a6cbe49b3679d4c97/chrome/browser/resources/omnibox/omnibox_element.js
[modify] https://crrev.com/4c1b499d39b560836924662a6cbe49b3679d4c97/chrome/browser/resources/omnibox/omnibox_inputs.js
[modify] https://crrev.com/4c1b499d39b560836924662a6cbe49b3679d4c97/chrome/browser/resources/omnibox/omnibox_output.js

Comment 12 by bugdroid1@chromium.org, Oct 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bdf97d19e6b4a97825a82cc9402e48eb8b10add

commit 1bdf97d19e6b4a97825a82cc9402e48eb8b10add
Author: manuk <manukh@chromium.org>
Date: Sat Oct 27 03:00:07 2018

[chrome:omnibox]: Refactoring HTML generation part 2/3, create OutputResultsTable helper class.

This is the second of 3 CL's to replace the global static helper functions which manipulate the DOM with classes. In this CL, we replace the function addResultTableToOutput with OutputResultsTable, which is responsible for generating HTML tables from the combined and each individual providers' results.

Bug: 891303
Change-Id: Ie14196a712039b9ca80a1b9376afb6ed8e3dafee
Reviewed-on: https://chromium-review.googlesource.com/c/1294016
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603301}
[modify] https://crrev.com/1bdf97d19e6b4a97825a82cc9402e48eb8b10add/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/1bdf97d19e6b4a97825a82cc9402e48eb8b10add/chrome/browser/resources/omnibox/omnibox.js
[modify] https://crrev.com/1bdf97d19e6b4a97825a82cc9402e48eb8b10add/chrome/browser/resources/omnibox/omnibox_element.js
[modify] https://crrev.com/1bdf97d19e6b4a97825a82cc9402e48eb8b10add/chrome/browser/resources/omnibox/omnibox_output.js

Comment 13 by bugdroid1@chromium.org, Oct 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8af1b93eee848764600127174bc506fe1b66f20

commit a8af1b93eee848764600127174bc506fe1b66f20
Author: manuk <manukh@chromium.org>
Date: Mon Oct 29 14:11:24 2018

[chrome:omnibox]: Refactoring HTML generation part 3/3, create OutputResultsGroup helper class.

This is the 3rd of 3 CL's to replace the global static helper functions which manipulate the DOM with classes. In this CL, we replace the function addResultToOutput with OutputResultsGroup, which is responsible for generating HTML for each response from C++ AutocompleteController. Multiple responses can be returned for a single query, each is handled by unique OutputResultsGroup.

Bug: 891303
Change-Id: I385ee9b3b299d640f9cfb62d0b3bef5c704adbe8
Reviewed-on: https://chromium-review.googlesource.com/c/1294412
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603484}
[modify] https://crrev.com/a8af1b93eee848764600127174bc506fe1b66f20/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/a8af1b93eee848764600127174bc506fe1b66f20/chrome/browser/resources/omnibox/omnibox.js
[modify] https://crrev.com/a8af1b93eee848764600127174bc506fe1b66f20/chrome/browser/resources/omnibox/omnibox_output.js

Comment 14 by bugdroid1@chromium.org, Oct 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cbd30f237d8502f9f46549a0f992b3a22be7fa5

commit 1cbd30f237d8502f9f46549a0f992b3a22be7fa5
Author: manuk <manukh@chromium.org>
Date: Tue Oct 30 17:06:07 2018

[chrome:omnibox] Encapsulate custom elements and update orchestration of inputs

- OmniboxInputs to displatch events with details containing display and query inputs when they change

- OutputController to handle those events, cache display and query inputs, and invoke OmniboxOutputs.refresh

- OmniboxOutputs.refresh to manage updating the HTML from inputs

Bug: 891303
Change-Id: Ice63b04f4eafea5d98e8dddd1f16b17618f2652e
Reviewed-on: https://chromium-review.googlesource.com/c/1299534
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603932}
[modify] https://crrev.com/1cbd30f237d8502f9f46549a0f992b3a22be7fa5/chrome/browser/resources/omnibox/omnibox.js
[modify] https://crrev.com/1cbd30f237d8502f9f46549a0f992b3a22be7fa5/chrome/browser/resources/omnibox/omnibox_inputs.js
[modify] https://crrev.com/1cbd30f237d8502f9f46549a0f992b3a22be7fa5/chrome/browser/resources/omnibox/omnibox_output.js

Comment 15 by bugdroid1@chromium.org, Nov 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f060f535435a98e03c12568c8e958a0efd575788

commit f060f535435a98e03c12568c8e958a0efd575788
Author: manuk <manukh@chromium.org>
Date: Fri Nov 09 18:35:29 2018

[chrome:omnibox] Use anchor tags <a> to render cells containing links.

Bug: 891303
Change-Id: I682561e9427a0f2dedf356744bc66d28eff64ccb
Reviewed-on: https://chromium-review.googlesource.com/c/1329444
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606906}
[modify] https://crrev.com/f060f535435a98e03c12568c8e958a0efd575788/chrome/browser/resources/omnibox/omnibox_output.js

Comment 16 by bugdroid1@chromium.org, Nov 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05be455c677be002930e46df814366836a607691

commit 05be455c677be002930e46df814366836a607691
Author: manuk <manukh@chromium.org>
Date: Tue Nov 13 01:08:00 2018

[chrome:omnibox] Add checkbox to lock cursor position to end of input.

Bug: 891303
Change-Id: Ic5ad4fc57347db7632ba753eafe67eb37281061f
Reviewed-on: https://chromium-review.googlesource.com/c/1330281
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607397}
[modify] https://crrev.com/05be455c677be002930e46df814366836a607691/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/05be455c677be002930e46df814366836a607691/chrome/browser/resources/omnibox/omnibox_inputs.js

Comment 17 by bugdroid1@chromium.org, Nov 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d557ace8644a84f3e217b13562c91d1bf20945d3

commit d557ace8644a84f3e217b13562c91d1bf20945d3
Author: manuk <manukh@chromium.org>
Date: Thu Nov 15 15:22:18 2018

[chrome:omnibox] Add buttons to copy response data.

Two copy buttons are added. The first copies the visible table as text; display options, which affect the visibility of tables, columns, rows, also affect what text is copied. The second copies the responses as JSON.

Also, as this CL introduces a second outputs interface, I took this opportunity to consolidate this new interface and the previous OutputController (which served as an interface for OmniboxOutput) into a single interface, OmniboxController, which will be responsible for interfacing to individual Output classes responsible for:
1 render tables from responses
2 control visibility based on display options
3 control visibility and coloring based on search text
4 export/copy output
5 preserve inputs and reset default inputs
6 export/import inputs

Bug: 891303
Change-Id: I1b6e10e6aa2213912235863f61163c9d8e9f66f7
Reviewed-on: https://chromium-review.googlesource.com/c/1329842
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608370}
[modify] https://crrev.com/d557ace8644a84f3e217b13562c91d1bf20945d3/chrome/browser/resources/omnibox/BUILD.gn
[modify] https://crrev.com/d557ace8644a84f3e217b13562c91d1bf20945d3/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/d557ace8644a84f3e217b13562c91d1bf20945d3/chrome/browser/resources/omnibox/omnibox.js
[modify] https://crrev.com/d557ace8644a84f3e217b13562c91d1bf20945d3/chrome/browser/resources/omnibox/omnibox_inputs.js
[modify] https://crrev.com/d557ace8644a84f3e217b13562c91d1bf20945d3/chrome/browser/resources/omnibox/omnibox_output.js
[modify] https://crrev.com/d557ace8644a84f3e217b13562c91d1bf20945d3/third_party/closure_compiler/externs/pending.js

Comment 18 by bugdroid1@chromium.org, Nov 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9f402c51aa79dd099e76a656c244835860af1fa

commit b9f402c51aa79dd099e76a656c244835860af1fa
Author: manuk <manukh@chromium.org>
Date: Mon Nov 26 23:18:45 2018

[chrome:omnibox] Add input box and a filter/highlight toggle to search results.

When the filter option is selected, matches (rows) which do not match the search query are hidden; when the highlight option is selected, matches which do match the search query are highlighted (light blue).

Bug: 891303
Change-Id: I4c34dae1a1cef2c7baeffdd6de0355ef7ea53f0a
Reviewed-on: https://chromium-review.googlesource.com/c/1340904
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610969}
[modify] https://crrev.com/b9f402c51aa79dd099e76a656c244835860af1fa/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/b9f402c51aa79dd099e76a656c244835860af1fa/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/b9f402c51aa79dd099e76a656c244835860af1fa/chrome/browser/resources/omnibox/omnibox.js
[modify] https://crrev.com/b9f402c51aa79dd099e76a656c244835860af1fa/chrome/browser/resources/omnibox/omnibox_element.js
[modify] https://crrev.com/b9f402c51aa79dd099e76a656c244835860af1fa/chrome/browser/resources/omnibox/omnibox_inputs.js
[modify] https://crrev.com/b9f402c51aa79dd099e76a656c244835860af1fa/chrome/browser/resources/omnibox/omnibox_output.js
[modify] https://crrev.com/b9f402c51aa79dd099e76a656c244835860af1fa/third_party/closure_compiler/externs/pending.js

Comment 19 by bugdroid1@chromium.org, Nov 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef1d86aabc62cbd82be347bd09f66a01df3806b8

commit ef1d86aabc62cbd82be347bd09f66a01df3806b8
Author: manuk <manukh@chromium.org>
Date: Wed Nov 28 00:20:45 2018

[chrome:omnibox] Render additional properties as key value pairs (i.e. `last visit: 48 hours`).

Previously, the additional properties column was rendered as stringified JSON [1]. Using colon-delimited key value strings [2] improves readability and saves >75% vertical space.

[1]
[
  {
    "key": "last visit",
    "value": "48 hours ago"
  },
  {
    "key": "typed count",
    "value": "36"
  },
  {
    "key": "visit count",
    "value": "36"
  }
]

[2]
last visit: 48 hours ago
typed count: 36
visit count: 36

Bug: 891303
Change-Id: I4630347e2806cc8deb434f80c20b1587cf06c989
Reviewed-on: https://chromium-review.googlesource.com/c/1340946
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611446}
[modify] https://crrev.com/ef1d86aabc62cbd82be347bd09f66a01df3806b8/chrome/browser/resources/omnibox/omnibox_output.js

Comment 20 by bugdroid1@chromium.org, Nov 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5c9950c7b569d623d93940e88fbf34366d2badc

commit e5c9950c7b569d623d93940e88fbf34366d2badc
Author: manuk <manukh@chromium.org>
Date: Wed Nov 28 23:31:41 2018

[chrome:omnibox] Move output table description column adjacent to contents column.

Bug: 891303
Change-Id: I07686b8d72934ad32574aa8d2b901e110c41457c
Reviewed-on: https://chromium-review.googlesource.com/c/1352506
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611933}
[modify] https://crrev.com/e5c9950c7b569d623d93940e88fbf34366d2badc/chrome/browser/resources/omnibox/omnibox_output.js

Comment 21 by bugdroid1@chromium.org, Nov 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e7a7218542303fcb9a32e4d9139754ef43028ae

commit 2e7a7218542303fcb9a32e4d9139754ef43028ae
Author: manuk <manukh@chromium.org>
Date: Thu Nov 29 20:22:48 2018

[chrome:omnibox] Output table styling.

This CL intends to style the output table to approximately resemble the end goal. There will be more styling changes in future as 1) a single CL for all the styling changes would be too large, and 2) some of the styling changes depend on changes to how we generate and manage the HTML elements from the JS code.
In addition to 1) trivial CSS styling, this CL also 2) scales the table and column widths with the page width (down to a minimum width) and therefore gives all tables the equal width and consistent column widths; and 3) merges the combined results and individual provider results tables into a single table delimited with inner header rows.

Bug: 891303
Change-Id: Ifc823456a8404ade90f34a2c07545c1f643cb96d
Reviewed-on: https://chromium-review.googlesource.com/c/1354132
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612335}
[modify] https://crrev.com/2e7a7218542303fcb9a32e4d9139754ef43028ae/chrome/browser/browser_resources.grd
[modify] https://crrev.com/2e7a7218542303fcb9a32e4d9139754ef43028ae/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/2e7a7218542303fcb9a32e4d9139754ef43028ae/chrome/browser/resources/omnibox/omnibox.html
[add] https://crrev.com/2e7a7218542303fcb9a32e4d9139754ef43028ae/chrome/browser/resources/omnibox/omnibox_column_widths.css
[modify] https://crrev.com/2e7a7218542303fcb9a32e4d9139754ef43028ae/chrome/browser/resources/omnibox/omnibox_output.js
[modify] https://crrev.com/2e7a7218542303fcb9a32e4d9139754ef43028ae/chrome/browser/ui/webui/omnibox/omnibox_ui.cc

Comment 22 by bugdroid1@chromium.org, Nov 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4207c786a14548e6d9a10032f59ad44e5434d4c

commit a4207c786a14548e6d9a10032f59ad44e5434d4c
Author: manuk <manukh@chromium.org>
Date: Thu Nov 29 21:42:58 2018

[chrome:omnibox] Refactor table cell rendering.

Previously, we used 6 satic methods to render each type of table cell:
3) renderBooleanProperty_
5) renderKeyValueTuples_
2) renderJsonProperty_
4) renderLinkProperty_
1) renderTextProperty_

This CL replaces those static methods with classes:
1) OutputBooleanProperty
2) OutputKeyValueTuplesProperty
3) OutputJsonProperty
4) OutputLinkProperty
5) OutputTextProperty

This refactor serves two purposes:

1) By having an object own the rendered HTML instead of directly injecting it into the DOM, we can later reference and manipulate these cells. E.g.:
  - When filtering, currently, we highlight entire rows if any of the cells contain a match. This change allows highlight the specific cells which matched.
  - Currently, when the user toggles `show details`, we must re-render the entire table, because we have no way of retrieving cells and toggling their visibility after we render them. This change allows toggling cell visibility after they've been added to the DOM, and, therefore, avoiding the re-rendering.

2) Supporting more intensive cells without relying on a network of static helper functions.
  - Currently, JSON content is stringified and displayed as text. This change allows more elegant, colored, tabular display of JSON property.
  - Currently, boolean cells have values true & false, making it hard to search for a specific column value. This would change allows filtering; e.g. 'is bookmarked'.
  - Currently, our cells contain mostly single text values. This change makes it easier to display multiple properties, images, and other formatted content in cells.

Bug: 891303
Change-Id: I89d75798943e135cda53a898a4b8c1f26dd869a1
Reviewed-on: https://chromium-review.googlesource.com/c/1354308
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612378}
[modify] https://crrev.com/a4207c786a14548e6d9a10032f59ad44e5434d4c/chrome/browser/resources/omnibox/omnibox_output.js

Comment 23 by bugdroid1@chromium.org, Nov 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccc7463327a80db7f6e3b8141516404de6371344

commit ccc7463327a80db7f6e3b8141516404de6371344
Author: manuk <manukh@chromium.org>
Date: Fri Nov 30 19:49:52 2018

[chrome:omnibox] Use `OutputProperty.text` instead of DOM text when filtering rows.

This allows us to 1) have smarter filtering; e.g. filtering for bookmarked properties with 'is bookmarked' (separate CL) and 2) avoid unnecessarily going through the DOM for something.

Bug: 891303
Change-Id: I336096881f0fcd2e90a621ab2e54853c83e01608
Reviewed-on: https://chromium-review.googlesource.com/c/1357311
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612734}
[modify] https://crrev.com/ccc7463327a80db7f6e3b8141516404de6371344/chrome/browser/resources/omnibox/omnibox_output.js

Comment 24 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a13c919a8a62a28cf4f3f87de0a436224c38332

commit 6a13c919a8a62a28cf4f3f87de0a436224c38332
Author: manuk <manukh@chromium.org>
Date: Fri Dec 07 15:50:23 2018

[chrome:omnibox] Use Custom Elements for each sections of the output.

This results in multiple organizational changes.
1) Filtering logic is engulfed by these elements instead of being grouped in FilterDelegate. FilterDelegate, as a result, only contains static methods that operate on plain strings and are oblivious to the OmniobxOutput hierarchy.
2) As FilterDelegate no longer exists, it seemed unnecessary to maintain the distinction between OmniboxOutput and RenderDelegate; RenderDelegate was merged into OmniboxOutput.
3) Decoupled display input (e.g. showDetails) logic from rendering. First, the HTML elements are created, without regards to display inputs, and then visibility of various sections is updated afterwards. This has the added advantage that toggling display inputs no longer require recreating the HTML elements.

Bug: 891303
Change-Id: I7872e8b4449ce5fbd4a22e230c549ccc0d2764dd
Reviewed-on: https://chromium-review.googlesource.com/c/1357010
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614706}
[modify] https://crrev.com/6a13c919a8a62a28cf4f3f87de0a436224c38332/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/6a13c919a8a62a28cf4f3f87de0a436224c38332/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/6a13c919a8a62a28cf4f3f87de0a436224c38332/chrome/browser/resources/omnibox/omnibox.js
[modify] https://crrev.com/6a13c919a8a62a28cf4f3f87de0a436224c38332/chrome/browser/resources/omnibox/omnibox_element.js
[modify] https://crrev.com/6a13c919a8a62a28cf4f3f87de0a436224c38332/chrome/browser/resources/omnibox/omnibox_inputs.js
[modify] https://crrev.com/6a13c919a8a62a28cf4f3f87de0a436224c38332/chrome/browser/resources/omnibox/omnibox_output.js

Comment 25 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5865840ca7b1b0520378f53b5d312b630b47349f

commit 5865840ca7b1b0520378f53b5d312b630b47349f
Author: manuk <manukh@chromium.org>
Date: Fri Dec 07 15:54:14 2018

[chrome:omnibox] Highlight specific cells when filtering.

Currently, we highlighted only the rows that matched. Sometimes, rows it would be unclear why some rows matched and were highlighted; e.g. if you're filtering for `goo` with the intention of finding `google` urls, and some match had a url `go.com/o`, it would match and be highlighted. Highlighing the specific cell helps identify which specific cells of a row actually matched.

Bug: 891303
Change-Id: I99965255c386aecb6b49f85bf989159716209bb5
Reviewed-on: https://chromium-review.googlesource.com/c/1364157
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614707}
[modify] https://crrev.com/5865840ca7b1b0520378f53b5d312b630b47349f/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/5865840ca7b1b0520378f53b5d312b630b47349f/chrome/browser/resources/omnibox/omnibox_output.js

Comment 26 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a274aceb144cfa923c15dd7d3fd36205d4165e91

commit a274aceb144cfa923c15dd7d3fd36205d4165e91
Author: manuk <manukh@chromium.org>
Date: Fri Dec 07 15:58:58 2018

[chrome:omnibox] Incrementally build output tables.

Instead of clearing and re-building the entire list of tables, and then clearing and re-adding those tables to the DOM every time AutocompleteController returned a new response, this CL appends to the list of tables and the DOM.

Bug: 891303
Change-Id: I817ddded6531fb0836771e6f70c15ac46dd528e3
Reviewed-on: https://chromium-review.googlesource.com/c/1365879
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614709}
[modify] https://crrev.com/a274aceb144cfa923c15dd7d3fd36205d4165e91/chrome/browser/resources/omnibox/omnibox_output.js

Comment 27 by bugdroid1@chromium.org, Dec 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/327d5eeb813726e529c48bb63bbca51e2b06aacd

commit 327d5eeb813726e529c48bb63bbca51e2b06aacd
Author: manuk <manukh@chromium.org>
Date: Sat Dec 08 00:28:45 2018

[chrome:omnibox] Colored output for 'additional properties' column.

The additional properties column is displayed only when there is an unaccounted
property on matches returned form the page handler; ideally, it should never be
shown. When it is shown, originally (before any chrome:omnibox refresh CL's), we
displayed 1 column per unaccounted property, each in the format of
"propertyName=propertyValue". Previous CL's changed it to be a single column of
stringified JSON. This CL adds color to it.

Bug: 891303
Change-Id: I84d4655b87d3aea2a94cd2ab74051b5d8edd0007
Reviewed-on: https://chromium-review.googlesource.com/c/1368457
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614882}
[modify] https://crrev.com/327d5eeb813726e529c48bb63bbca51e2b06aacd/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/327d5eeb813726e529c48bb63bbca51e2b06aacd/chrome/browser/resources/omnibox/omnibox_output.js

Comment 28 by bugdroid1@chromium.org, Dec 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e543cd603f8d2e78e311b6a39071f998cc6997d1

commit e543cd603f8d2e78e311b6a39071f998cc6997d1
Author: manuk <manukh@chromium.org>
Date: Sat Dec 08 00:30:34 2018

[chrome:omnibox] Smarter boolean filtering; e.g. 'is starred' or 'not deletable'.

Previously, boolean properties used their true or false values for filtering.
If you wished to filter bookmarked matches, you could type 'true', but this
would filter bookmarked matches as well as any match that has any true boolean
property. With this CL, you can type 'is starred' or 'not starred'; boolean
properties now use the 'is:' or 'not:' prefix in conjunction with their
property name.

Other minor but related changes:

1) Filtering is now case insensitive.
2) The filter input box now has examples in the placeholder text as well as an
explanation of the filter algorithm in the tooltip.
3) Filter text now correctly escapes special characters.

Bug: 891303
Change-Id: I259b4a9a71b9f8249839ec881196a1c2d483bc11
Reviewed-on: https://chromium-review.googlesource.com/c/1366256
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614884}
[modify] https://crrev.com/e543cd603f8d2e78e311b6a39071f998cc6997d1/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/e543cd603f8d2e78e311b6a39071f998cc6997d1/chrome/browser/resources/omnibox/omnibox_output.js

Comment 29 by bugdroid1@chromium.org, Dec 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/303292c37af00787ae2d204a10bf8a9dec1027ca

commit 303292c37af00787ae2d204a10bf8a9dec1027ca
Author: manuk <manukh@chromium.org>
Date: Sat Dec 08 00:36:18 2018

[chrome:omnibox] Colored output for 'additional info' column.

The additional info column contains a list of key and value pairs. Additional
info cells are rendered as such: "relevance_from_server: true should_prefetch:
false", line wrapped only when necessary, which makes it difficult to read.
This CL add's new lines between each key value pair, and styles keys bold purple
(same as how keys are colored in the additional properties column) and values
blue (same as how numbers are styled in the additinal properties column).

Bug: 891303
Change-Id: I7062e7582789e6abf08b2478d058e198ebdfff84
Reviewed-on: https://chromium-review.googlesource.com/c/1368775
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614888}
[modify] https://crrev.com/303292c37af00787ae2d204a10bf8a9dec1027ca/chrome/browser/resources/omnibox/omnibox_output.js

Comment 30 by bugdroid1@chromium.org, Dec 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c278e3a974d463bf89560ba9d3d3ebd5e1c9856

commit 6c278e3a974d463bf89560ba9d3d3ebd5e1c9856
Author: manuk <manukh@chromium.org>
Date: Mon Dec 10 18:30:55 2018

[chrome:omnibox] Join columns 'provider name' with 'type' and 'contents' with
'description'.

This CL introduces support for multi-property columns. For now, we use it for
the two simplest cases, but in future, more columns may display multiple
columns, and some columns may display more than two properties..

Relevant minor changes also included in this CL:

1) In order to make styling multi-property cells easier, we introduce 'cell-*'
CSS classes and rename the previous 'column-*' CSS classes, which referred to
header cells, to 'header-*'.

2) To clarify naming, we renamed the type PresentationInfoRecord and the
constant PROPERTY_OUTPUT_ORDER to Column and COLUMNS respectively.

3) To avoid post-processing the columns in order to append computed properties
after first initializing them, we use a constructor instead of object literals.

4) To avoid relying on 'typeof' and reduce complexity, we declare each column's
OutputProperty class (e.g. OutputBooleanProperty or OutputJsonProperty).

Bug: 891303
Change-Id: I9bb15e22a9c07d42947111014213ddf3f924f9ab
Reviewed-on: https://chromium-review.googlesource.com/c/1368028
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615178}
[modify] https://crrev.com/6c278e3a974d463bf89560ba9d3d3ebd5e1c9856/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/6c278e3a974d463bf89560ba9d3d3ebd5e1c9856/chrome/browser/resources/omnibox/omnibox_column_widths.css
[modify] https://crrev.com/6c278e3a974d463bf89560ba9d3d3ebd5e1c9856/chrome/browser/resources/omnibox/omnibox_output.js

Comment 31 by bugdroid1@chromium.org, Dec 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/939fae0092f249666564fd6fe273939b7327de65

commit 939fae0092f249666564fd6fe273939b7327de65
Author: manuk <manukh@chromium.org>
Date: Tue Dec 11 21:14:14 2018

[chrome:omnibox] Join columns 'Fill Into Edit' and 'Inline Autocompletion'.

Additionally, typically the inline text is a suffix of the fill text; e.g.
typing 'g', may result in the inline text 'oogle.com' and fill text
'google.com'. To conserve space and mimick how the actual omnibox displays the
inline and fill texts, we display the inline text only once, and format it (1px
border & bold font) to distinguish it from the fill text; e.g. g|oogle.com|. In
the yet-unencountered case where the inline text is not a suffix of the fill
text, we display both adjacent.

Bug: 891303
Change-Id: I8096eca7b14d84be0941ae19c5a076cbc782218c
Reviewed-on: https://chromium-review.googlesource.com/c/1372231
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615660}
[modify] https://crrev.com/939fae0092f249666564fd6fe273939b7327de65/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/939fae0092f249666564fd6fe273939b7327de65/chrome/browser/resources/omnibox/omnibox_column_widths.css
[modify] https://crrev.com/939fae0092f249666564fd6fe273939b7327de65/chrome/browser/resources/omnibox/omnibox_output.js

Comment 32 by mpear...@chromium.org, Dec 11

>>>
In the yet-unencountered case where the inline text is not a suffix of the fill
text, we display both adjacent.
>>>
This can happen.  For example, a local hostname "go".  If the user types "go", there is no inline autocompletion, yet the fill into edit text is "go/", to make it clear to the omnibox system that that's the canonical way to get to that destination.

Comment 33 by bugdroid1@chromium.org, Dec 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7c31efa862f37842f36f4a188c00daf0469f04a

commit a7c31efa862f37842f36f4a188c00daf0469f04a
Author: manuk <manukh@chromium.org>
Date: Tue Dec 11 21:23:42 2018

[chrome:omnibox] Limit matches' texts for filtering.

For matches with long text, the regex filtering algorithm's performance becomes
problematic. For matches of about 350 characters, occasional lag becomes
noticeable as you type the filter text. For matches of about 500 characters, the
page approaches unusable when trying to filter.

When the match text being filtered is longer than 200 characters, we truncate it
to 100 characters and `console.warn` a message.

Bug: 891303
Change-Id: I79d9ce5eb17b479ddb0584aa0ac2e461938e8dac
Reviewed-on: https://chromium-review.googlesource.com/c/1372308
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615665}
[modify] https://crrev.com/a7c31efa862f37842f36f4a188c00daf0469f04a/chrome/browser/resources/omnibox/omnibox_output.js

Comment 34 by manukh@chromium.org, Dec 11

This (c#31) sounds similar to c#3 & c#4.

> My assumption is that inline auto-completion will either be blank or a suffix of fill-into-edit

In the 'go' example, this assumption holds.

Comment 35 by bugdroid1@chromium.org, Dec 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6680f22027722607ffd67ca0d9a4e4ff9624cd1b

commit 6680f22027722607ffd67ca0d9a4e4ff9624cd1b
Author: manuk <manukh@chromium.org>
Date: Wed Dec 12 00:04:41 2018

[chrome:omnibox] Add access keys for input elements.

Using L and F for query and find input boxes in order to be similar to
browser shortcuts for focusing the omnibox and find dialog respectively.

Using I, D, and P for 'show incomplete results', 'show details', and 'show per
provider' display checkboxes respectively.

Using C, A, and K for 'lock cursor', 'prevent autocomplete', 'keyword mode'
input checkboxes respectively.

Using U for 'current page' dropdown.

Bug: 891303
Change-Id: Id715fb6c3db5787a8e676f2497578128a2810fd9
Reviewed-on: https://chromium-review.googlesource.com/c/1372243
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615736}
[modify] https://crrev.com/6680f22027722607ffd67ca0d9a4e4ff9624cd1b/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/6680f22027722607ffd67ca0d9a4e4ff9624cd1b/chrome/browser/resources/omnibox/omnibox.html

Comment 36 by bugdroid1@chromium.org, Dec 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9322b46a3378547e779fa9f89552cb4cfbce2f35

commit 9322b46a3378547e779fa9f89552cb4cfbce2f35
Author: manuk <manukh@chromium.org>
Date: Wed Dec 12 20:03:03 2018

[chrome:omnibox] Minor styling adjustment for positioning fill and inline cell texts.

Inline text has a 1px border. Previously, we used a white 1px border on the fill
text in order to help align them vertically add also add a 1px horizontal gap
between them. After other styling changes, the invisible border was no longer
necessary for vertical alignment. Additionally, it was causing the horizontal
positioning to be slightly off. This CL removes the invisible border, instead
using a right-margin for horizontal positioning.

Bug: 891303
Change-Id: Ib5fdfc876ada51f129ac2b34c1c59b3d1bd1994e
Reviewed-on: https://chromium-review.googlesource.com/c/1374204
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616006}
[modify] https://crrev.com/9322b46a3378547e779fa9f89552cb4cfbce2f35/chrome/browser/resources/omnibox/omnibox.css

Comment 37 by bugdroid1@chromium.org, Dec 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af5575591751d6f69955630cf0c0e4d64fa8f404

commit af5575591751d6f69955630cf0c0e4d64fa8f404
Author: manuk <manukh@chromium.org>
Date: Wed Dec 12 20:27:27 2018

[chrome:omnibox] Reduce table header and body row heights.

Reduced table body row heights from 44px to 42px. 42px is just sufficient to
display 3 lines. Any less, and cells with 3 lines of contents would grow in
height on hover. 3 lines seems sufficient for most matches without consuming too
much vertical space.

Reduced table header row padding from 20 (top) and 10px (bottom) to 12 and 6px
respectively. This looks more visually pleasing and consumes less vertical space
without appearing cramped compared with the adjacent table rows.

Bug: 891303
Change-Id: I75efba70799163bd7f33e1340cfecdd2d1bb45a3
Reviewed-on: https://chromium-review.googlesource.com/c/1374400
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616018}
[modify] https://crrev.com/af5575591751d6f69955630cf0c0e4d64fa8f404/chrome/browser/resources/omnibox/omnibox.css

Comment 38 by bugdroid1@chromium.org, Dec 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de910441219180faa182bd869b5a03358f57eb94

commit de910441219180faa182bd869b5a03358f57eb94
Author: manuk <manukh@chromium.org>
Date: Wed Dec 12 22:52:02 2018

[chrome:omnibox] Display string representation for transition column enum.

Previously, the transition column displays the enum's integer representation.
The 'generated' and 'typed' transition values are most common, adjusting the
transition column width to 70px (from 60px) allows these values to be displayed
without eliding.

Bug: 891303
Change-Id: Ic356e9f89541e22fa1cdfd54959a444d0cab6836
Reviewed-on: https://chromium-review.googlesource.com/c/1374489
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616092}
[modify] https://crrev.com/de910441219180faa182bd869b5a03358f57eb94/chrome/browser/resources/omnibox/omnibox_column_widths.css
[modify] https://crrev.com/de910441219180faa182bd869b5a03358f57eb94/chrome/browser/ui/webui/omnibox/omnibox.mojom
[modify] https://crrev.com/de910441219180faa182bd869b5a03358f57eb94/chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc

Comment 39 by bugdroid1@chromium.org, Dec 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97d8fc2564702f0bf8aa21ef4e61cb895eb709ef

commit 97d8fc2564702f0bf8aa21ef4e61cb895eb709ef
Author: manuk <manukh@chromium.org>
Date: Thu Dec 13 23:31:54 2018

[chrome:omnibox] Make boolean indicators copy-able.

The svg vector boolean indicators are not copyable through normal interaction
(e.g. select and press ctrl+c). This CL adds invisible (font size 0) true/false
text to each indicator for copying purposes.

This feature was initially added in CL 1271359, but was unintentionally removed
during refactors.

Bug: 891303
Change-Id: Id153b7aaefca7ec5797e33d8f20996772c1c9c0b
Reviewed-on: https://chromium-review.googlesource.com/c/1376718
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616484}
[modify] https://crrev.com/97d8fc2564702f0bf8aa21ef4e61cb895eb709ef/chrome/browser/resources/omnibox/omnibox_output.js

Comment 40 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/146f80904172432a90a2a8843e8ccc13a9928773

commit 146f80904172432a90a2a8843e8ccc13a9928773
Author: manuk <manukh@chromium.org>
Date: Fri Dec 14 22:08:46 2018

[chrome:omnibox] Remove option to hide rows when filtering.

Previously, filtering output had two modes: 1) highlighting matches, 2) hiding
non-matches. This CL removes the 2nd option as the 1st was deemed more useful.

Bug: 891303
Change-Id: I0df88f56cecb2498ae82b4870f20f3b7e92b2850
Reviewed-on: https://chromium-review.googlesource.com/c/1373872
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616843}
[modify] https://crrev.com/146f80904172432a90a2a8843e8ccc13a9928773/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/146f80904172432a90a2a8843e8ccc13a9928773/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/146f80904172432a90a2a8843e8ccc13a9928773/chrome/browser/resources/omnibox/omnibox.js
[modify] https://crrev.com/146f80904172432a90a2a8843e8ccc13a9928773/chrome/browser/resources/omnibox/omnibox_inputs.js
[modify] https://crrev.com/146f80904172432a90a2a8843e8ccc13a9928773/chrome/browser/resources/omnibox/omnibox_output.js

Comment 41 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54673460c2c5f127611c17c13ed918c520d1ef83

commit 54673460c2c5f127611c17c13ed918c520d1ef83
Author: manuk <manukh@chromium.org>
Date: Mon Dec 17 20:01:11 2018

[omnibox] Adjust table styling to accommodate cells with long content.

1) Set fixed but larger (4 lines + some added padding) row heights. Previously,
rows where 3 lines high, but grew on hover.
2) On hovering over a cell, vertical scroll bar is added only to that single
cell and not the other cells in the same row.
3) The 'additional info' column is multi-lined even when non-hovered (hence the
added padding to row height), which unfortunately also means it has no ellipses
to signify when it's elided.

Bug: 891303
Change-Id: I3d21424a80f477cc9fce835e1217d9d8e7b4b107
Reviewed-on: https://chromium-review.googlesource.com/c/1377183
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617196}
[modify] https://crrev.com/54673460c2c5f127611c17c13ed918c520d1ef83/chrome/browser/resources/omnibox/omnibox.css

Comment 42 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34c7cbd04ab4f3bf2388b31fc7cd46ae38ffaeb0

commit 34c7cbd04ab4f3bf2388b31fc7cd46ae38ffaeb0
Author: manuk <manukh@chromium.org>
Date: Mon Dec 17 21:28:29 2018

[omnibox chrome:omnibox] Use default font instead of monospace font.

The default font `DejaVu Sans, Arial, sans-serif` is defined in
text_defaults.css.

Bug: 891303
Change-Id: I257e96ad68feafd3de919d8b1199bb71174e396e
Reviewed-on: https://chromium-review.googlesource.com/c/1380957
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617235}
[modify] https://crrev.com/34c7cbd04ab4f3bf2388b31fc7cd46ae38ffaeb0/chrome/browser/resources/omnibox/omnibox.css

Comment 43 by bugdroid1@chromium.org, Dec 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2af893e34471b4b2cd34d070fd8f1e13c4289db7

commit 2af893e34471b4b2cd34d070fd8f1e13c4289db7
Author: manuk <manukh@chromium.org>
Date: Tue Dec 18 17:23:55 2018

[chrome:omnibox] Add styling to table headers.

Currently, to help distinguish contents of multi-property cells, we apply
different styling to each property value. To further clarify which value is
associated with which property, this CL applies similar styling to their
headers. E.g., currently, provider names are displayed in green, and provider
types are displayed in black. This CL similarly styles the header text:
'[green]Provider[/green] & Text'.

Bug: 891303
Change-Id: I79249000ed401c918497f1f6007757cb2202c905
Reviewed-on: https://chromium-review.googlesource.com/c/1374528
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617544}
[modify] https://crrev.com/2af893e34471b4b2cd34d070fd8f1e13c4289db7/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/2af893e34471b4b2cd34d070fd8f1e13c4289db7/chrome/browser/resources/omnibox/omnibox_output.js

Comment 44 by bugdroid1@chromium.org, Dec 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e524190614b8c31ea29cabb2894eeaf091e8d348

commit e524190614b8c31ea29cabb2894eeaf091e8d348
Author: manuk <manukh@chromium.org>
Date: Tue Dec 18 18:30:23 2018

[omnibox chrome:omnibox] Remove need for 'shift' key from accesskeys.

1) 'Show all details' accesskey changed from 'd' to 't' as both 'd' and 'e' are
reserved by the browser.
2) Filter text input accesskye changed from 'f' to 'g'.

Accordingly, the accesskey hint in the placholder texts of text inputs are
changed to no longer include 'shift'.

Bug: 891303
Change-Id: I67003c7978e68a01bad3bdf6816bbba932167c43
Reviewed-on: https://chromium-review.googlesource.com/c/1381135
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617570}
[modify] https://crrev.com/e524190614b8c31ea29cabb2894eeaf091e8d348/chrome/browser/resources/omnibox/omnibox.html

Comment 45 by bugdroid1@chromium.org, Dec 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2fbdfc98b3f5dad0cb2df414a559192c0559aef

commit a2fbdfc98b3f5dad0cb2df414a559192c0559aef
Author: manuk <manukh@chromium.org>
Date: Tue Dec 18 19:16:09 2018

[omnibox chrome:omnibox] Add Omnibox team to omnibox debug page OWNERS

Bug: 891303
Change-Id: Ieb38ddb33fc3f6c47ac0ec33c8aee282ec0f3db5
Reviewed-on: https://chromium-review.googlesource.com/c/1382902
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617583}
[add] https://crrev.com/a2fbdfc98b3f5dad0cb2df414a559192c0559aef/chrome/browser/resources/omnibox/OWNERS

Comment 46 by bugdroid1@chromium.org, Dec 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9f398e31428f29e9500a22104a329472d284b35

commit a9f398e31428f29e9500a22104a329472d284b35
Author: manuk <manukh@chromium.org>
Date: Tue Dec 18 20:35:03 2018

[omnibox chrome:omnibox] Adjust default input values.

1) Default value for 'Current page classification' changed from
'new tab page omnibox' to 'arbitrary URL' because 'new tab page omniobx' won't
allow zero suggest results, but otherwise they act similarly.
2) 'Show all providers' checked by default.
3) The column 'Can be default' always visible instead of only when
'show all details' is checked.

Bug: 891303
Change-Id: Ic3bcd6a0f438485efa363135413929a8c85601cc
Reviewed-on: https://chromium-review.googlesource.com/c/1381145
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617608}
[modify] https://crrev.com/a9f398e31428f29e9500a22104a329472d284b35/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/a9f398e31428f29e9500a22104a329472d284b35/chrome/browser/resources/omnibox/omnibox_output.js

Comment 47 by bugdroid1@chromium.org, Dec 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/faf47d4887a07a6ca63d4e5673c353b95c05648b

commit faf47d4887a07a6ca63d4e5673c353b95c05648b
Author: manuk <manukh@chromium.org>
Date: Tue Dec 18 21:06:16 2018

[omnibox chrome:omnibox] Disable browser autocomplete on text inputs.

Browser autocomplete was not useful on this debug page and was occasionally
causing issues preventing user input. This CL sets autocomplete off for
the query and filter text inputs.

Bug: 891303
Change-Id: I05fd5f4f8168eb7a959d0539273041bf81f54971
Reviewed-on: https://chromium-review.googlesource.com/c/1381152
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617616}
[modify] https://crrev.com/faf47d4887a07a6ca63d4e5673c353b95c05648b/chrome/browser/resources/omnibox/omnibox.html

Comment 48 by bugdroid1@chromium.org, Dec 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53304a9b8d1c0c0c56be9b50c9e3bb1f67c4b7b9

commit 53304a9b8d1c0c0c56be9b50c9e3bb1f67c4b7b9
Author: manuk <manukh@chromium.org>
Date: Wed Dec 19 14:57:16 2018

[chrome:omnibox] Add 'reset autocomplete controller' checkbox.

Currently, the autocomplete controller is reset for each query. This prohibits
replicating behavior that depends on previous queries, e.g. results with
answers. This CL adds an input paramter to toggle whether to reset the
autocomplete controller for each query.

Bug: 891303
Change-Id: Iffbd2a71f952148eead0fc14cb0c1ba08d76b642
Reviewed-on: https://chromium-review.googlesource.com/c/1377191
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617830}
[modify] https://crrev.com/53304a9b8d1c0c0c56be9b50c9e3bb1f67c4b7b9/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/53304a9b8d1c0c0c56be9b50c9e3bb1f67c4b7b9/chrome/browser/resources/omnibox/omnibox.js
[modify] https://crrev.com/53304a9b8d1c0c0c56be9b50c9e3bb1f67c4b7b9/chrome/browser/resources/omnibox/omnibox_inputs.js
[modify] https://crrev.com/53304a9b8d1c0c0c56be9b50c9e3bb1f67c4b7b9/chrome/browser/ui/webui/omnibox/omnibox.mojom
[modify] https://crrev.com/53304a9b8d1c0c0c56be9b50c9e3bb1f67c4b7b9/chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc
[modify] https://crrev.com/53304a9b8d1c0c0c56be9b50c9e3bb1f67c4b7b9/chrome/browser/ui/webui/omnibox/omnibox_page_handler.h

Comment 49 by bugdroid1@chromium.org, Dec 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5d8d0b4d3beacbccec4638b825df7cda05bf9f3

commit f5d8d0b4d3beacbccec4638b825df7cda05bf9f3
Author: manuk <manukh@chromium.org>
Date: Wed Dec 19 16:18:54 2018

[omnibox chrome:omnibox] 1-letter boolean column headers.

Currently, boolean columns are too narrow (18px) to display more than 1
character without becoming '...'. This CL changes all boolean column headers to
their first character, and adds the full header title to the tooltip.

Bug: 891303
Change-Id: I8e85810d0fbcfbd0569b2cacf979e0eac8aee7b2
Reviewed-on: https://chromium-review.googlesource.com/c/1380963
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617850}
[modify] https://crrev.com/f5d8d0b4d3beacbccec4638b825df7cda05bf9f3/chrome/browser/resources/omnibox/omnibox_output.js

Comment 50 by bugdroid1@chromium.org, Dec 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/626e8b40a2bc3f4e1382d21a4f9d86239d641422

commit 626e8b40a2bc3f4e1382d21a4f9d86239d641422
Author: manuk <manukh@chromium.org>
Date: Wed Dec 19 21:35:11 2018

[omnibox chrome:omnibox] Vertical padding for table inner headers.

crrev.com/c/1374528 unintentionally restricted the CSS rule which applied
vertical padding to top headers only. This CL applies the padding to inner headers
as well.

Bug: 891303
Change-Id: I6b7f8f9705c7eeba7c91839e135dd09fe2a6f4af
Reviewed-on: https://chromium-review.googlesource.com/c/1384618
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617956}
[modify] https://crrev.com/626e8b40a2bc3f4e1382d21a4f9d86239d641422/chrome/browser/resources/omnibox/omnibox.css

Comment 51 by bugdroid1@chromium.org, Dec 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/909941bb826b5339ea7c812ff256a2f9b582b908

commit 909941bb826b5339ea7c812ff256a2f9b582b908
Author: manuk <manukh@chromium.org>
Date: Wed Dec 19 22:39:52 2018

[omnibox chrome:omnibox] Reapply filter between input changes.

Currently, when the query inputs change (as opposed to display inputs), filter
highlighting is disabled until the filter text input is changed. This CL
reapplies the filter highlighting after query input changes.

Besides arguments of which behavior is typically desired on input changes, this
has the added advantage of having the filter text and filter highlights be
consistent.

Bug: 891303
Change-Id: I7f8741b508c4273a9ddc1854c3646bdaf010f6de
Reviewed-on: https://chromium-review.googlesource.com/c/1384355
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617990}
[modify] https://crrev.com/909941bb826b5339ea7c812ff256a2f9b582b908/chrome/browser/resources/omnibox/omnibox.js
[modify] https://crrev.com/909941bb826b5339ea7c812ff256a2f9b582b908/chrome/browser/resources/omnibox/omnibox_output.js

Comment 52 by bugdroid1@chromium.org, Dec 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bd68689f8f02c9ff9e28fd49ca8e2673276ad81

commit 2bd68689f8f02c9ff9e28fd49ca8e2673276ad81
Author: manuk <manukh@chromium.org>
Date: Thu Dec 20 20:07:22 2018

[omnibox chrome:omnibox] Initialize OmniboxOutput displayOptions with defaults.

crrev.com/c/1381145 set the 'show all providers' checkbox checked by default
(on page load). However, this state is not propagated to OmniboxOuptut until at
least 1 display option was changed by the user, leading to unintuitive results:

1) 'show all providers' behaved as if it was unchecked but was displayed checked
2) unchecking 'show all providers' would appear to change nothing
3) checking another display checkbox (e.g. 'show all details'), would also
active 'show all providers'

This CL initializes OmniboxOutput's displayOptions to the default values.

Bug: 891303
Change-Id: I328180d1b79319ff60f23a9c1d860bc1f68d8c76
Reviewed-on: https://chromium-review.googlesource.com/c/1384930
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618305}
[modify] https://crrev.com/2bd68689f8f02c9ff9e28fd49ca8e2673276ad81/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/2bd68689f8f02c9ff9e28fd49ca8e2673276ad81/chrome/browser/resources/omnibox/omnibox_inputs.js
[modify] https://crrev.com/2bd68689f8f02c9ff9e28fd49ca8e2673276ad81/chrome/browser/resources/omnibox/omnibox_output.js

Comment 53 by orinj@google.com, Dec 21

Here are some before/after screenshots for restyle in CL @ https://chromium-review.googlesource.com/c/chromium/src/+/1382899
Before.png
190 KB View Download
After.png
208 KB View Download

Comment 54 by bugdroid1@chromium.org, Dec 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3a8def66f9362c1a0fcebfb082309f65fc741f1

commit b3a8def66f9362c1a0fcebfb082309f65fc741f1
Author: manuk <manukh@chromium.org>
Date: Fri Dec 21 22:01:04 2018

[omnibox chrome:omnibox] Replace className with ClassList

Bug: 891303
Change-Id: If58334d48debc7c5e23717f4cd13f2a77bb2c286
Reviewed-on: https://chromium-review.googlesource.com/c/1388705
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618622}
[modify] https://crrev.com/b3a8def66f9362c1a0fcebfb082309f65fc741f1/chrome/browser/resources/omnibox/omnibox_output.js

Comment 55 by bugdroid1@chromium.org, Dec 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35fd6e51f4cb3c03bd05d923328d4d49950750b7

commit 35fd6e51f4cb3c03bd05d923328d4d49950750b7
Author: manuk <manukh@chromium.org>
Date: Fri Dec 21 22:02:51 2018

[chrome:omnibox] Support zero suggest results.

This CL wires in the current_page and from_omnibox_focus autocomplete input
fields to the UI. Adding these fields allows the debug page to work with the
zero suggest provider, but they also affect other providers, such as search
provider.

Adds 'zero suggest' checkbox which controls the from_omnibox_focus autocomplete
input field. This field enables the zero suggest and clipboard providers while
also disabling the bookmarks, built in, history, history url, keyword, search,
and shortcut providers.

Also adds a 'current url' input box which controls the current_url autocomplete
input field. This field is essential for the zero suggest provider but may also
affect the search and clipboard providers.

To avoid redundant typing, when 'zero suggest' is checked, the 'current url'
input becomes disabled and auto-populated with the contents of the 'omnibox
text' input.

Lastly, changed the accesskey of 'current page context' from 'u' to 'o' in order
to use the accesskey 'u' for the 'current url' input.

Bug: 891303
Change-Id: I51f4815d9f837245b6b6fab03dcec5d009783b6b
Reviewed-on: https://chromium-review.googlesource.com/c/1378246
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618624}
[modify] https://crrev.com/35fd6e51f4cb3c03bd05d923328d4d49950750b7/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/35fd6e51f4cb3c03bd05d923328d4d49950750b7/chrome/browser/resources/omnibox/omnibox.js
[modify] https://crrev.com/35fd6e51f4cb3c03bd05d923328d4d49950750b7/chrome/browser/resources/omnibox/omnibox_inputs.js
[modify] https://crrev.com/35fd6e51f4cb3c03bd05d923328d4d49950750b7/chrome/browser/ui/webui/omnibox/omnibox.mojom
[modify] https://crrev.com/35fd6e51f4cb3c03bd05d923328d4d49950750b7/chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc
[modify] https://crrev.com/35fd6e51f4cb3c03bd05d923328d4d49950750b7/chrome/browser/ui/webui/omnibox/omnibox_page_handler.h

Comment 56 by mpear...@chromium.org, Dec 21

>>>
To avoid redundant typing, when 'zero suggest' is checked, the 'current url'
input becomes disabled and auto-populated with the contents of the 'omnibox
text' input.
>>>
This part might need to be rolled back sometime if we're going to use chrome://omnibox to investigate zero suggest in context of query-in-the-omnibox.

Comment 57 by bugdroid1@chromium.org, Dec 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91b4c46fc6f789aa9aca38a362ec2053229a8d5e

commit 91b4c46fc6f789aa9aca38a362ec2053229a8d5e
Author: manuk <manukh@chromium.org>
Date: Fri Dec 21 23:38:29 2018

[omnibox chrome:omnibox] Restyle inputs section.

Bug: 891303
Change-Id: I2e9dd3d635a2d5776fc5d1bca045b9b2fee539b3
Reviewed-on: https://chromium-review.googlesource.com/c/1382899
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618674}
[modify] https://crrev.com/91b4c46fc6f789aa9aca38a362ec2053229a8d5e/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/91b4c46fc6f789aa9aca38a362ec2053229a8d5e/chrome/browser/resources/omnibox/omnibox.html

Comment 58 by bugdroid1@chromium.org, Dec 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe3d9a4f7bca1a67ec5f6164e18f364cb9c09e79

commit fe3d9a4f7bca1a67ec5f6164e18f364cb9c09e79
Author: manuk <manukh@chromium.org>
Date: Wed Dec 26 22:20:29 2018

[omnibox chrome:omnibox] Rename OmniboxInputs to OmniboxInput

This is consistent with OmniboxOutput. We're using to input and output as
collective nouns rather than as a container for a collection of inputs and
outputs.

Bug: 891303
Change-Id: I2e7166c7e24f2bac4e84383f5b8fb4a573c9b3e2
Reviewed-on: https://chromium-review.googlesource.com/c/1387397
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618969}
[modify] https://crrev.com/fe3d9a4f7bca1a67ec5f6164e18f364cb9c09e79/chrome/browser/browser_resources.grd
[modify] https://crrev.com/fe3d9a4f7bca1a67ec5f6164e18f364cb9c09e79/chrome/browser/resources/omnibox/BUILD.gn
[modify] https://crrev.com/fe3d9a4f7bca1a67ec5f6164e18f364cb9c09e79/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/fe3d9a4f7bca1a67ec5f6164e18f364cb9c09e79/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/fe3d9a4f7bca1a67ec5f6164e18f364cb9c09e79/chrome/browser/resources/omnibox/omnibox.js
[rename] https://crrev.com/fe3d9a4f7bca1a67ec5f6164e18f364cb9c09e79/chrome/browser/resources/omnibox/omnibox_input.js
[modify] https://crrev.com/fe3d9a4f7bca1a67ec5f6164e18f364cb9c09e79/chrome/browser/resources/omnibox/omnibox_output.js
[modify] https://crrev.com/fe3d9a4f7bca1a67ec5f6164e18f364cb9c09e79/chrome/browser/ui/webui/omnibox/omnibox_ui.cc

Comment 59 by bugdroid1@chromium.org, Jan 2

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f62d1dab8d952f2a63d30bb871e2f6e5996040c2

commit f62d1dab8d952f2a63d30bb871e2f6e5996040c2
Author: manuk <manukh@chromium.org>
Date: Wed Jan 02 17:33:05 2019

[chrome:omnibox] Add answer entities and favicons.

Added favicons to the 'URL' column. Favicons are displayed to the left of the
url, similar to how they're displayed in the omnibox.
Added answer entities to the 'Contents & Description & Answer' column. Answer
images are displayed to the left of the contents and description, similar to how
they're displayed in the omniobx. For answers which have text associated with
them (e.g. 'weathe<b>r</b> / 76°F Thu / answer type weather'), it will be
displayed in orange after the contents and description.

Bug: 891303
Change-Id: I46d50fcce39f93b57a70aae5d2f439333d203dbf
Reviewed-on: https://chromium-review.googlesource.com/c/1376661
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619427}
[modify] https://crrev.com/f62d1dab8d952f2a63d30bb871e2f6e5996040c2/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/f62d1dab8d952f2a63d30bb871e2f6e5996040c2/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/f62d1dab8d952f2a63d30bb871e2f6e5996040c2/chrome/browser/resources/omnibox/omnibox.js
[modify] https://crrev.com/f62d1dab8d952f2a63d30bb871e2f6e5996040c2/chrome/browser/resources/omnibox/omnibox_output.js
[modify] https://crrev.com/f62d1dab8d952f2a63d30bb871e2f6e5996040c2/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
[modify] https://crrev.com/f62d1dab8d952f2a63d30bb871e2f6e5996040c2/chrome/browser/ui/webui/omnibox/omnibox.mojom
[modify] https://crrev.com/f62d1dab8d952f2a63d30bb871e2f6e5996040c2/chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc
[modify] https://crrev.com/f62d1dab8d952f2a63d30bb871e2f6e5996040c2/components/omnibox/browser/suggestion_answer.cc
[modify] https://crrev.com/f62d1dab8d952f2a63d30bb871e2f6e5996040c2/tools/traffic_annotation/summary/annotations.xml

Comment 60 by bugdroid1@chromium.org, Jan 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69b770ab67284c8f52a96952acc4d7ddfec85183

commit 69b770ab67284c8f52a96952acc4d7ddfec85183
Author: manuk <manukh@chromium.org>
Date: Mon Jan 07 23:45:28 2019

[omnibox chrome:omnibox] Adjust styling.

The previous CL crrev.com/c/1382899 updated the styling of the inputs section.
This CL follows up with additional minor styling changes:
1) Adds light gray background to hovered checkboxes. The previous CL added
similar backgrounds to the other elements (text inputs, selects, buttons).
2) Synchronizes the heights of input elements. Most of the input elements had
similar heights (20-26px), except the checkboxes, which were noticeably smaller.
This CL gives all the input elements 26px heights.
3) Adjusts colors and border thicknesses.
4) Adjusts table vertical spacing. Previously, there was no spacing between
the input and outputs sections unless table details were shown.
5) Styles the table details section.

Bug: 891303
Change-Id: Ifca41272aff09a6cafc369c32e82c749b4436b9f
Reviewed-on: https://chromium-review.googlesource.com/c/1391308
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620529}
[modify] https://crrev.com/69b770ab67284c8f52a96952acc4d7ddfec85183/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/69b770ab67284c8f52a96952acc4d7ddfec85183/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/69b770ab67284c8f52a96952acc4d7ddfec85183/chrome/browser/resources/omnibox/omnibox_element.js
[modify] https://crrev.com/69b770ab67284c8f52a96952acc4d7ddfec85183/chrome/browser/resources/omnibox/omnibox_input.js
[modify] https://crrev.com/69b770ab67284c8f52a96952acc4d7ddfec85183/chrome/browser/resources/omnibox/omnibox_output.js

Comment 61 by bugdroid1@chromium.org, Jan 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e76eec0720c359c9aa169ff571858f6889ee5919

commit e76eec0720c359c9aa169ff571858f6889ee5919
Author: manuk <manukh@chromium.org>
Date: Tue Jan 08 14:59:52 2019

[omnibox chrome:omnibox] Add cursor position indicators.

When the query text input is not focused, an arrow is added below it to
indicate the cursor position. This is most useful when viewing imported
data or traversing response history.

Bug: 891303
Change-Id: Ib87a2d6d42211716181f1df073411530400eb3bd
Reviewed-on: https://chromium-review.googlesource.com/c/1394727
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620719}
[modify] https://crrev.com/e76eec0720c359c9aa169ff571858f6889ee5919/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/e76eec0720c359c9aa169ff571858f6889ee5919/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/e76eec0720c359c9aa169ff571858f6889ee5919/chrome/browser/resources/omnibox/omnibox_input.js

Comment 62 by bugdroid1@chromium.org, Jan 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c659d2e222c0daf642ff6aa5e378fa6f0102147

commit 7c659d2e222c0daf642ff6aa5e378fa6f0102147
Author: manuk <manukh@chromium.org>
Date: Tue Jan 08 18:00:28 2019

[omnibox chrome:omnibox] Export and Import JSON files

This CL adds a `Download as JSON` button to download the query inputs, display
inputs, and autocomplete responses to a .JSON file named
`omnibox_debug_export_<query>_<timestamp>.json`. This replaces the current
`Copy as JSON` button. The `Copy as Text` button, which only extracts the visual
output and not the entire responses or inputs, remains as is.

This CL also adds an `Import JSON` button to import previously exported JSON's.
Clicking the button will open a file selector; dragging the .JSON file or a
JSON string to the button also works. Selecting or dragging an invalid JSON file
or dragging an invalid JSON string results in a console.error message.

After successfully importing, a red 'Viewing imported data' warning will be
displayed under the import button to signify that the output may not reflect the
output the input would currently produce.

Bug: 891303
Change-Id: I1a17cda783fa9170baca8841bb80b19a3a67ab82
Reviewed-on: https://chromium-review.googlesource.com/c/1391917
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620789}
[modify] https://crrev.com/7c659d2e222c0daf642ff6aa5e378fa6f0102147/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/7c659d2e222c0daf642ff6aa5e378fa6f0102147/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/7c659d2e222c0daf642ff6aa5e378fa6f0102147/chrome/browser/resources/omnibox/omnibox.js
[modify] https://crrev.com/7c659d2e222c0daf642ff6aa5e378fa6f0102147/chrome/browser/resources/omnibox/omnibox_input.js
[modify] https://crrev.com/7c659d2e222c0daf642ff6aa5e378fa6f0102147/chrome/browser/resources/omnibox/omnibox_output.js

Comment 63 by bugdroid1@chromium.org, Jan 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32d39951e6427705484b3d023fb48b59c9223432

commit 32d39951e6427705484b3d023fb48b59c9223432
Author: manuk <manukh@chromium.org>
Date: Thu Jan 10 02:11:24 2019

[omnibox chrome:omnibox] Keep input at top when scrolling

This only applies to screens with height greater than 900px (Pixel 2XL
has a height of 823px) in order to preserve vertical space.

Bug: 891303
Change-Id: I602f9fe75fbe45d812bf6db817e5b33f9deac6ec
Reviewed-on: https://chromium-review.googlesource.com/c/1403175
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621423}
[modify] https://crrev.com/32d39951e6427705484b3d023fb48b59c9223432/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/32d39951e6427705484b3d023fb48b59c9223432/chrome/browser/resources/omnibox/omnibox.html

Comment 64 by bugdroid1@chromium.org, Jan 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc6de262fa45f445a3d62ce94d609cdd0d62b459

commit fc6de262fa45f445a3d62ce94d609cdd0d62b459
Author: manuk <manukh@chromium.org>
Date: Mon Jan 14 16:42:59 2019

[omnibox chrome:omnibox] Connect the browser's omnibox, CL 1 of 2

Interacting with the real omnibox of any normal or incognito browser window
while the debug page is open will update the debug page's output.

This is the 1st of 2 related CL's. This CL wires in the browser omnibox,
whereas the 2nd will add a UI input to disable this feature.

Bug: 891303
Change-Id: I64d72ed01710d4eb472373527f7ade61c19b0fda
Reviewed-on: https://chromium-review.googlesource.com/c/1399450
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622476}
[modify] https://crrev.com/fc6de262fa45f445a3d62ce94d609cdd0d62b459/chrome/browser/resources/omnibox/omnibox.js
[modify] https://crrev.com/fc6de262fa45f445a3d62ce94d609cdd0d62b459/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
[modify] https://crrev.com/fc6de262fa45f445a3d62ce94d609cdd0d62b459/chrome/browser/ui/omnibox/chrome_omnibox_client.h
[modify] https://crrev.com/fc6de262fa45f445a3d62ce94d609cdd0d62b459/chrome/browser/ui/webui/omnibox/omnibox.mojom
[modify] https://crrev.com/fc6de262fa45f445a3d62ce94d609cdd0d62b459/chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc
[modify] https://crrev.com/fc6de262fa45f445a3d62ce94d609cdd0d62b459/chrome/browser/ui/webui/omnibox/omnibox_page_handler.h
[modify] https://crrev.com/fc6de262fa45f445a3d62ce94d609cdd0d62b459/components/omnibox/browser/BUILD.gn
[modify] https://crrev.com/fc6de262fa45f445a3d62ce94d609cdd0d62b459/components/omnibox/browser/DEPS
[modify] https://crrev.com/fc6de262fa45f445a3d62ce94d609cdd0d62b459/components/omnibox/browser/omnibox_client.cc
[modify] https://crrev.com/fc6de262fa45f445a3d62ce94d609cdd0d62b459/components/omnibox/browser/omnibox_client.h
[modify] https://crrev.com/fc6de262fa45f445a3d62ce94d609cdd0d62b459/components/omnibox/browser/omnibox_controller.cc
[add] https://crrev.com/fc6de262fa45f445a3d62ce94d609cdd0d62b459/components/omnibox/browser/omnibox_controller_emitter.cc
[add] https://crrev.com/fc6de262fa45f445a3d62ce94d609cdd0d62b459/components/omnibox/browser/omnibox_controller_emitter.h

Comment 65 by bugdroid1@chromium.org, Jan 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be7036d87fcd7e8a84673bcddbe10e2cf22ae8e8

commit be7036d87fcd7e8a84673bcddbe10e2cf22ae8e8
Author: manuk <manukh@chromium.org>
Date: Mon Jan 14 18:43:34 2019

[omnibox chrome:omnibox] Horizontal sizing of input query column

Previously, when the user entered long query text, the input field its column
would grow to accomodate the long text and thereby shrink the other input
columns. This CL keeps all input columns at an equal width regardless of query
length.

Additionally, previously, when the query text was long and the cursor position
was not visible (i.e. was further along the text than the portion displayed),
the cursor position indicator would wrap to the beginning of the next line,
appearing as if the cursor was in fact at the start of the text. This CL keeps
the indicator at the end of the line.

Bug: 891303
Change-Id: I24606e99c670c4e931de684b0558866456038b4b
Reviewed-on: https://chromium-review.googlesource.com/c/1407603
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622532}
[modify] https://crrev.com/be7036d87fcd7e8a84673bcddbe10e2cf22ae8e8/chrome/browser/resources/omnibox/omnibox.css

Comment 66 by bugdroid1@chromium.org, Jan 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/234e2dd1bd41b0efe21bb44e28f64bf7899d7c53

commit 234e2dd1bd41b0efe21bb44e28f64bf7899d7c53
Author: manuk <manukh@chromium.org>
Date: Tue Jan 15 15:03:23 2019

[omnibox chrome:omnibox] Connect the browser's omnibox, CL 2 of 2, UI

Interacting with the real omnibox of any browser window while the debug page is
open will update the debug page's output. Incognito window omnibox results will
update only debug pages open in incognito windows. Likewise, normal window
omnibox results will update only debug pages open in normal windows.

This is the 2nd of 2 related CL's. The previous CL wired in the browser
omnibox, whereas this CL adds the 'Connect with window omnibox' checkbox to
disable and enable this feature.

Bug: 891303
Change-Id: I4a366e83de22316008df384491f5af9c3f579c64
Reviewed-on: https://chromium-review.googlesource.com/c/1393526
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622858}
[modify] https://crrev.com/234e2dd1bd41b0efe21bb44e28f64bf7899d7c53/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/234e2dd1bd41b0efe21bb44e28f64bf7899d7c53/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/234e2dd1bd41b0efe21bb44e28f64bf7899d7c53/chrome/browser/resources/omnibox/omnibox.js
[modify] https://crrev.com/234e2dd1bd41b0efe21bb44e28f64bf7899d7c53/chrome/browser/resources/omnibox/omnibox_input.js

Comment 67 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08694ef0d458ceb51757ea221157c9c1a78566d9

commit 08694ef0d458ceb51757ea221157c9c1a78566d9
Author: manuk <manukh@chromium.org>
Date: Wed Jan 16 00:10:29 2019

[omnibox chrome:omnibox] Scope CSS Styling

This CL replaces the large omnibox.css stylesheet shared  by the page
and each custom element within it with omnibox_input.css and
omnibox_output.css and <style>'s inlined inside the custom elements'
templates. The page is not visually affected by this CL.

Bug: 891303
Change-Id: I16f1eceef39bf96c17a2464a8d81db7967d318e7
Reviewed-on: https://chromium-review.googlesource.com/c/1388649
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622901}
[modify] https://crrev.com/08694ef0d458ceb51757ea221157c9c1a78566d9/chrome/browser/browser_resources.grd
[modify] https://crrev.com/08694ef0d458ceb51757ea221157c9c1a78566d9/chrome/browser/resources/omnibox/omnibox.css
[modify] https://crrev.com/08694ef0d458ceb51757ea221157c9c1a78566d9/chrome/browser/resources/omnibox/omnibox.html
[add] https://crrev.com/08694ef0d458ceb51757ea221157c9c1a78566d9/chrome/browser/resources/omnibox/omnibox_input.css
[rename] https://crrev.com/08694ef0d458ceb51757ea221157c9c1a78566d9/chrome/browser/resources/omnibox/omnibox_output_column_widths.css
[add] https://crrev.com/08694ef0d458ceb51757ea221157c9c1a78566d9/chrome/browser/resources/omnibox/output_results_group.css
[modify] https://crrev.com/08694ef0d458ceb51757ea221157c9c1a78566d9/chrome/browser/ui/webui/omnibox/omnibox_ui.cc

Comment 68 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89c2db5bd1e7f48f0c2d269bc37a9e8edb3d0652

commit 89c2db5bd1e7f48f0c2d269bc37a9e8edb3d0652
Author: manuk <manukh@chromium.org>
Date: Wed Jan 16 20:56:03 2019

[omnibox chrome:omnibox] Add accesskeys for import and export buttons

The 3 buttons below were the only remaining inputs that did not have accesskeys.
- Copy as te(x)t
- Do(w)nload as JSON
- I(m)port JSON

Bug: 891303
Change-Id: I10930f0e9b00a1625b14547a211007adb2aef095
Reviewed-on: https://chromium-review.googlesource.com/c/1409912
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623349}
[modify] https://crrev.com/89c2db5bd1e7f48f0c2d269bc37a9e8edb3d0652/chrome/browser/resources/omnibox/omnibox.html

Comment 69 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a95212958bf906492ba6d16b9f0234064a032ff1

commit a95212958bf906492ba6d16b9f0234064a032ff1
Author: manuk <manukh@chromium.org>
Date: Wed Jan 16 23:10:24 2019

[omnibox chrome:omnibox] Support traversing query history

Previously, once a new autocomple query is made, responses from the previous
query were discarded. This CL supports viewing and traversing autocomplete
responses from previous queries. Exported and importing the JSON data will
preserve this history. Display parameters can be changed when viewing
previous queries, but changing query parameters will generate a new query.

Bug: 891303
Change-Id: Ifce51847339671cc221bafff2a87092c692c69d3
Reviewed-on: https://chromium-review.googlesource.com/c/1399300
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623431}
[modify] https://crrev.com/a95212958bf906492ba6d16b9f0234064a032ff1/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/a95212958bf906492ba6d16b9f0234064a032ff1/chrome/browser/resources/omnibox/omnibox.js
[modify] https://crrev.com/a95212958bf906492ba6d16b9f0234064a032ff1/chrome/browser/resources/omnibox/omnibox_input.css
[modify] https://crrev.com/a95212958bf906492ba6d16b9f0234064a032ff1/chrome/browser/resources/omnibox/omnibox_input.js
[modify] https://crrev.com/a95212958bf906492ba6d16b9f0234064a032ff1/chrome/browser/resources/omnibox/omnibox_output.js

Comment 71 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ba57f898a5173c4499096c529ac692bd6c7d727

commit 7ba57f898a5173c4499096c529ac692bd6c7d727
Author: Ahmed Fakhry <afakhry@chromium.org>
Date: Thu Jan 17 00:04:53 2019

Revert "[omnibox chrome:omnibox] Add checkbox to toggle cell eliding"

This reverts commit 3200e3e7f3e60874cb93faf451cef850f9b80054.

Reason for revert: Breaks compile on linux-chromeos-rel

BUG= 922820 

Original change's description:
> [omnibox chrome:omnibox] Add checkbox to toggle cell eliding
> 
> Bug: 891303
> Change-Id: I25ac8d8897d388e8f9fd92e0f175d878683ca83e
> Reviewed-on: https://chromium-review.googlesource.com/c/1407772
> Commit-Queue: manuk hovanesian <manukh@chromium.org>
> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#623452}

TBR=jdonnelly@chromium.org,manukh@chromium.org

Change-Id: Ib9f7544c7d79efbfe5ea07964267ae3d01b52f22
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891303
Reviewed-on: https://chromium-review.googlesource.com/c/1416816
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623459}
[modify] https://crrev.com/7ba57f898a5173c4499096c529ac692bd6c7d727/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/7ba57f898a5173c4499096c529ac692bd6c7d727/chrome/browser/resources/omnibox/omnibox_input.js
[modify] https://crrev.com/7ba57f898a5173c4499096c529ac692bd6c7d727/chrome/browser/resources/omnibox/omnibox_output.js
[modify] https://crrev.com/7ba57f898a5173c4499096c529ac692bd6c7d727/chrome/browser/resources/omnibox/output_results_group.css

Comment 72 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98b57f86a38c3a7b92174fecaf4867a7a8e2a53b

commit 98b57f86a38c3a7b92174fecaf4867a7a8e2a53b
Author: manuk <manukh@chromium.org>
Date: Thu Jan 17 20:31:07 2019

[omnibox chrome:omnibox] Reorder methods in OmniboxInput

Bug: 891303
Change-Id: I7c02adc678e156557d90365bb4aa6b65b95068a0
Reviewed-on: https://chromium-review.googlesource.com/c/1407608
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623819}
[modify] https://crrev.com/98b57f86a38c3a7b92174fecaf4867a7a8e2a53b/chrome/browser/resources/omnibox/omnibox_input.js

Comment 74 by bugdroid1@chromium.org, Jan 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26627dadd2268b06a0867c68bb3d3f32728c9e48

commit 26627dadd2268b06a0867c68bb3d3f32728c9e48
Author: manuk <manukh@chromium.org>
Date: Fri Jan 18 15:04:59 2019

[omnibox chrome:omnibox] Rename AutocompleteResults to AutocompleteResponse

Previously, the debug page and the related page handler referred to responses
returned from the page handler to the debug page as results, which in turn
contained autocomplete matches also referred to as results. This became slightly
confusing when naming methods and variables. To alleviate the issue, the JS code
began distinguishing them by referring to the prior as AutocompleteResponses and
the latter as results. This left the JS naming slightly inconsistent with
the page handler naming. This CL extends the distinction to the page handler.

Bug: 891303
Change-Id: I65a6d0986a30bfe4dc9f9ffff9f2001c0fb82fb6
Reviewed-on: https://chromium-review.googlesource.com/c/1407370
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624124}
[modify] https://crrev.com/26627dadd2268b06a0867c68bb3d3f32728c9e48/chrome/browser/resources/omnibox/omnibox.js
[modify] https://crrev.com/26627dadd2268b06a0867c68bb3d3f32728c9e48/chrome/browser/resources/omnibox/omnibox_output.js
[modify] https://crrev.com/26627dadd2268b06a0867c68bb3d3f32728c9e48/chrome/browser/ui/webui/omnibox/omnibox.mojom
[modify] https://crrev.com/26627dadd2268b06a0867c68bb3d3f32728c9e48/chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc

Comment 75 by bugdroid1@chromium.org, Jan 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e7ec2b84c891ec63a6275f66911a5bb74e1b379

commit 0e7ec2b84c891ec63a6275f66911a5bb74e1b379
Author: manuk <manukh@chromium.org>
Date: Fri Jan 18 18:55:59 2019

[omnibox chrome:omnibox] Use `rem` instead of `px` for font-size units

Bug: 891303
Change-Id: Ibeaf710631e305e055e38f73cd049b24853b5a76
Reviewed-on: https://chromium-review.googlesource.com/c/1407090
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624218}
[modify] https://crrev.com/0e7ec2b84c891ec63a6275f66911a5bb74e1b379/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/0e7ec2b84c891ec63a6275f66911a5bb74e1b379/chrome/browser/resources/omnibox/omnibox_input.css
[modify] https://crrev.com/0e7ec2b84c891ec63a6275f66911a5bb74e1b379/chrome/browser/resources/omnibox/output_results_group.css

Comment 76 by bugdroid1@chromium.org, Jan 18

Project Member

Comment 77 by bugdroid1@chromium.org, Jan 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/974bde76897bd793f825090b7c2ea4b23f22e800

commit 974bde76897bd793f825090b7c2ea4b23f22e800
Author: manuk <manukh@chromium.org>
Date: Sat Jan 19 00:08:47 2019

[omnibox chrome:omnibox] Decrease inputs font-size to .75rem.

Decrease inputs font-size from 0.875rem (14px on 'medium' font setting)
to .75rem (12px) in order to match outputs' font-size.

Bug: 891303
Change-Id: I1416029ae7cc0e61569fb176066cb93a4a74207b
Reviewed-on: https://chromium-review.googlesource.com/c/1423398
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624370}
[modify] https://crrev.com/974bde76897bd793f825090b7c2ea4b23f22e800/chrome/browser/resources/omnibox/omnibox_input.css

Comment 78 by bugdroid, Jan 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cebe159f2cad4ec22801ca73fd8d4a6726a9dd9

commit 9cebe159f2cad4ec22801ca73fd8d4a6726a9dd9
Author: manuk <manukh@chromium.org>
Date: Wed Jan 23 19:26:27 2019

[omnibox chrome:omnibox] Display answer image urls.

Currently, answer images are displayed as image elements whose src attribute
is set to a data url; the user has no way of obtaining the original
image url. This CL adds an anchor element displaying the image src to the
'Contents & Description & Answer' column.

Bug: 891303
Change-Id: I3ba68f58a95557554bee67d5088b10eec8b3bb29
Reviewed-on: https://chromium-review.googlesource.com/c/1430682
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625305}

Comment 79 by bugdroid, Feb 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d670994fe15465ee7f3057038077de007bd40a3

commit 4d670994fe15465ee7f3057038077de007bd40a3
Author: manuk <manukh@chromium.org>
Date: Fri Feb 08 18:49:38 2019

[omnibox chrome:omnibox]: Use header tooltip when searching boolean properties.

Before, we used the column header text when searching by boolean properties.
When we replaced the headers with 1 letter abbreviations, this broke searching
boolean properties. I.e., to search for results that could be the default match,
you'd have to type 'is:d', but 'is:default' would no longer work. This CL
changes searching to use the first line of the tooltip text instead of the
header text.

The current tooltip names are:
  - Can be Default
  - Starred
  - Has Tab Match
  - deletable
  - From Previous
  - Done

Bug: 891303
Change-Id: Ic275924ca3e7dfad6fba3c20514e87577bbbf807
Reviewed-on: https://chromium-review.googlesource.com/c/1459782
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630398}
[modify] https://crrev.com/4d670994fe15465ee7f3057038077de007bd40a3/chrome/browser/resources/omnibox/omnibox_output.js

Comment 80 by bugdroid, Feb 19 (4 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/723e4022d37e3a9d001e50d267b9a4c5062cae62

commit 723e4022d37e3a9d001e50d267b9a4c5062cae62
Author: manuk <manukh@chromium.org>
Date: Tue Feb 19 22:21:19 2019

[omnibox chrome:omnibox] Add stripped URL.

This CL adds the stripped URL to the existing URL column. To help differentiate
the two, the styles the stripped URL red.

Bug: 891303
Change-Id: I959e8c22695651a768bffaacd8082a42cfe2a0c4
Reviewed-on: https://chromium-review.googlesource.com/c/1477871
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633425}
[modify] https://crrev.com/723e4022d37e3a9d001e50d267b9a4c5062cae62/chrome/browser/resources/omnibox/omnibox_output.js
[modify] https://crrev.com/723e4022d37e3a9d001e50d267b9a4c5062cae62/chrome/browser/resources/omnibox/output_results_group.css
[modify] https://crrev.com/723e4022d37e3a9d001e50d267b9a4c5062cae62/chrome/browser/ui/webui/omnibox/omnibox.mojom
[modify] https://crrev.com/723e4022d37e3a9d001e50d267b9a4c5062cae62/chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc

Sign in to add a comment