New issue
Advanced search Search tips

Issue 891299 link

Starred by 1 user
Status: Verified
Owner:
djean@chromium.org
Closed: Oct 18
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Dynamic Type: Payment doesn't support Dynamic Type

Project Member Reported by gambard@chromium.org, Oct 2 
With large fonts.

What steps will reproduce the problem?
Open a Payment Request page.
The "Review your payment" screen is shown.

What is the expected result?
The text should be scaled up.

What happens instead?
The font size is the same.
Simulator Screen Shot - iPhone SE - 2018-10-02 at 16.39.23.png
59.7 KB View Download

Comment 1 by mahmadi@chromium.org, Oct 2

Cc: mahmadi@chromium.org
Owner: ----
Status: Available (was: Assigned)
I don't have any cycles to take this on this cycle? any chance someone else could own this?

Comment 2 by rouslan@chromium.org, Oct 2 

This can wait until 2019. Would you mind if I left this assigned to you (with low priority) to avoid forgetting it?

Comment 3 by mahmadi@chromium.org, Oct 2

Cc: -mahmadi@chromium.org
Labels: -Pri-2 Pri-3
Owner: mahmadi@chromium.org
Status: Assigned (was: Available)
sg!

Comment 4 by djean@chromium.org, Oct 5

Owner: djean@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fab20f2bce96542152b7d57cc07dcbc6499a7b0

commit 3fab20f2bce96542152b7d57cc07dcbc6499a7b0
Author: David Jean <djean@google.com>
Date: Thu Oct 18 09:53:55 2018

[ios] Add dynamic type fonts to payments cells

Video: https://drive.google.com/open?id=16GEAtsIQLbSjYlrIC3a1hby8gVxjgYAz

Bug:  891299 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I8601ac0eb934e42dbe6ca6389b91ed35d3228964
Reviewed-on: https://chromium-review.googlesource.com/c/1264383
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600709}
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/autofill/cells/autofill_edit_item.h
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/autofill/cells/autofill_edit_item.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrome.h
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrome.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/collection_view/cells/collection_view_footer_item.h
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/collection_view/cells/collection_view_footer_item.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/collection_view/cells/collection_view_switch_item.h
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/collection_view/cells/collection_view_switch_item.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/collection_view/collection_view_controller.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/payments/billing_address_selection_mediator.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/payments/cells/accepted_payment_methods_item.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/payments/cells/autofill_profile_item.h
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/payments/cells/autofill_profile_item.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/payments/cells/page_info_item.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/payments/cells/payment_method_item.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/payments/cells/payments_selector_edit_item.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/payments/cells/payments_text_item.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/payments/cells/price_item.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/payments/contact_info_selection_mediator.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/payments/payment_items_display_view_controller.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/payments/payment_request_mediator.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/payments/payment_request_picker_view_controller.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/payments/payment_request_view_controller.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/payments/shipping_address_selection_mediator.mm
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/uikit_ui_util.h
[modify] https://crrev.com/3fab20f2bce96542152b7d57cc07dcbc6499a7b0/ios/chrome/browser/ui/uikit_ui_util.mm

Comment 6 by djean@chromium.org, Oct 18

Status: Fixed (was: Started)

Comment 7 by rakurati@chromium.org, Oct 23

Status: Verified (was: Fixed)
Verified in 72.0.3585.0 Canary in iPad Air(iOS 12 Beta), iPad 2018(iOS 11.4.1), iPhone 6s plus(iOS 12 Beta 5),  iPhone 8plus(iOS 11.4.1)

Payment supports dynamic type now, looks good

Link to video:
https://drive.google.com/file/d/1i3M1NbOj7nTY2_2pCsxWvApqxdNRwtnV/view?usp=sharing

Note: However issue still exist in iOS 10, A separate issue is not yet reported since M72 and later versions doesn't support iOS 10. A separate issue will be reported if the CL is merged in to M71

Comment 8 by djean@chromium.org, Oct 23 

iOS 10 doesn't offer the api needed to scale our fonts (UIFontMetrics).
►

Sign in to add a comment