New issue
Advanced search Search tips

Issue 891291 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Dynamic Type: QR code text isn't scaling up

Project Member Reported by gambard@chromium.org, Oct 2

Issue description

With large fonts.

What steps will reproduce the problem?
Open the QR Code Scanner.

What is the expected result?
The text should be scaled up.

What happens instead?
The font size is the same.
 
Owner: djean@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88b885aee2ca555ab9af27ad46cfe45e88b8665a

commit 88b885aee2ca555ab9af27ad46cfe45e88b8665a
Author: David Jean <djean@google.com>
Date: Mon Oct 08 08:26:11 2018

[ios] add dynamic types to qr code label

Bug:  891291 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I8e72497ea3a71a2cb2c6b8e51e4b5076b233457c
Reviewed-on: https://chromium-review.googlesource.com/c/1264538
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597495}
[modify] https://crrev.com/88b885aee2ca555ab9af27ad46cfe45e88b8665a/ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified the issue on the build version 72.0.3582.0 canary tested on iPhone and iPad iOS 12, 
QR Code text size increase on increasing the device font size,looks good.
This issue has been verified and found fixed. Details are given below:
Build No. : 71.0.3578.8 beta
Device : iPad Pro, iPhone 7+
OS Version: 12.0.1

Sign in to add a comment