Dynamic Type: Bubble tips aren't scaling up |
||||
Issue descriptionWith large fonts. What steps will reproduce the problem? Enable "InProductHelp demo mode" in chrome://flags (to BottomToolbarTip for phone for example). Relaunch chrome. What is the expected result? The bubble tips text should be scaled up. What happens instead? The text has the same font size as usual.
,
Oct 5
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9cd5f428b85c82ce1002fa7dd2fe2f00c3804471 commit 9cd5f428b85c82ce1002fa7dd2fe2f00c3804471 Author: David Jean <djean@google.com> Date: Tue Oct 09 07:05:24 2018 [ios] add dynamic types to bubble tips Bug: 891287 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I18406f97dd776c4947a30ba2861a2c6308f87c80 Reviewed-on: https://chromium-review.googlesource.com/c/1264579 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#597826} [modify] https://crrev.com/9cd5f428b85c82ce1002fa7dd2fe2f00c3804471/ios/chrome/browser/ui/bubble/bubble_view.mm [modify] https://crrev.com/9cd5f428b85c82ce1002fa7dd2fe2f00c3804471/ios/chrome/browser/ui/bubble/bubble_view_unittest.mm
,
Oct 9
,
Oct 16
Verified the issue on the build version 72.0.3582.0 canary tested on iPhone 7+(iOS 12). Bubble tip text size increases as the font size increases. Image : https://drive.google.com/file/d/1hI8EWR_WK-aIjYP0OnvrmOoYbmOFx1j4/view?usp=sharing |
||||
►
Sign in to add a comment |
||||
Comment 1 by gambard@chromium.org
, Oct 269.3 KB
69.3 KB View Download