Dynamic Type: Recent Tabs history icon isn't correctly positioned |
|||
Issue descriptionWith large fonts. What steps will reproduce the problem? Open Recent Tabs from the tools menu. What is the expected result? The "history" icon should have padding on the side. What happens instead? The "history" icon is very close to the border of the screen and of the text.
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40c7ab374ac8af68f922376ded00ad3cca212df7 commit 40c7ab374ac8af68f922376ded00ad3cca212df7 Author: Yi Su <mrsuyi@chromium.org> Date: Fri Dec 21 15:44:00 2018 Fix TableViewImageItem for accessibility font size. TableViewImageItem's Autolayout constraints are not well-defined for accessibility font size. This CL fixes it, and removes unused chevron view. Bug: 891283 ,870841 Change-Id: Ia27bb25d158163a405dbb888050558fbd95dbb00 Reviewed-on: https://chromium-review.googlesource.com/c/1386784 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#618535} [modify] https://crrev.com/40c7ab374ac8af68f922376ded00ad3cca212df7/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm [modify] https://crrev.com/40c7ab374ac8af68f922376ded00ad3cca212df7/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm [modify] https://crrev.com/40c7ab374ac8af68f922376ded00ad3cca212df7/ios/chrome/browser/ui/table_view/cells/table_view_image_item.h [modify] https://crrev.com/40c7ab374ac8af68f922376ded00ad3cca212df7/ios/chrome/browser/ui/table_view/cells/table_view_image_item.mm [modify] https://crrev.com/40c7ab374ac8af68f922376ded00ad3cca212df7/ios/chrome/browser/ui/table_view/cells/table_view_image_item_unittest.mm
,
Dec 24
,
Jan 15
Verified on 73.0.3672.0 Canary, iPhoneXR iOS 12.1.2, iPhone6S iOS 11.4.1 Looks good. https://drive.google.com/file/d/1fLQsYlSpMOuaNJklaTjDxF8UF1SzYn1z/view?usp=sharing |
|||
►
Sign in to add a comment |
|||
Comment 1 by mrsuyi@chromium.org
, Dec 20Owner: mrsuyi@chromium.org
Status: Started (was: Assigned)