[css-scroll-snap] scroll-snap-align keywords should not be reversed |
||
Issue descriptionIf scroll-snap-align is set to "start end", Blink serializes the specified value as "start end" but the computed value is incorrectly reported as "end start" Spec: https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-snap-align Test case: http://jsfiddle.net/ericwilligers/sqjtx3vr/
,
Oct 5
If anybody wants to take a look at this, please do.
,
Oct 5
This should be straightforward if a new contributor, student or intern wants to take it on.
,
Oct 6
@ericwilligers@chromium.org I am working on this issue and I checked that it works fine with my patch. I will send a CL ASAP.
,
Oct 7
I 've uploaded the CL https://chromium-review.googlesource.com/c/chromium/src/+/1267055
,
Oct 7
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a31d6d6cf095f81e5a14c4845d2cddff92e539f9 commit a31d6d6cf095f81e5a14c4845d2cddff92e539f9 Author: Dong-hee Na <donghee.na92@gmail.com> Date: Mon Oct 08 23:47:52 2018 css-scroll-snap: scroll-snap-align keywords should not be reversed According to spec, if two values specified for the ScrollSnapAlign these values should be set as the block axis and inline axis respectively. But the current implementation does not follow this so it should be updated. refernce: https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-snap-align Bug: 891282 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id765b44c86ce4f2aeb5e85ec74f83a36cc282196 Reviewed-on: https://chromium-review.googlesource.com/c/1267055 Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#597735} [modify] https://crrev.com/a31d6d6cf095f81e5a14c4845d2cddff92e539f9/cc/input/scroll_snap_data.h [modify] https://crrev.com/a31d6d6cf095f81e5a14c4845d2cddff92e539f9/cc/input/scroll_snap_data_unittest.cc [modify] https://crrev.com/a31d6d6cf095f81e5a14c4845d2cddff92e539f9/third_party/WebKit/LayoutTests/external/wpt/css/css-scroll-snap/inheritance-expected.txt [modify] https://crrev.com/a31d6d6cf095f81e5a14c4845d2cddff92e539f9/third_party/blink/renderer/core/css/properties/computed_style_utils.cc [modify] https://crrev.com/a31d6d6cf095f81e5a14c4845d2cddff92e539f9/third_party/blink/renderer/core/css/properties/longhands/scroll_snap_align_custom.cc [modify] https://crrev.com/a31d6d6cf095f81e5a14c4845d2cddff92e539f9/third_party/blink/renderer/core/page/scrolling/snap_coordinator_test.cc
,
Oct 8
|
||
►
Sign in to add a comment |
||
Comment 1 by ericwilligers@chromium.org
, Oct 3