New issue
Advanced search Search tips

Issue 891279 link

Starred by 2 users
Status: Verified
Owner:
djean@chromium.org
Closed: Oct 5
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Bookmarks "Choose Folder" screen isn't respecting Dynamic Type

Project Member Reported by gambard@chromium.org, Oct 2 
With large fonts.
Having at least one folder in bookmarks.

What steps will reproduce the problem?
(1) Open bookmarks
(2) Enter edit mode
(3) Select a Folder
(4) Select More in the toolbar
(5) Select Move in the alert

What is the expected result?
This screen should respect Dynamic Type.

What happens instead?
The labels top and bottom are cut.
Simulator Screen Shot - iPhone SE - 2018-10-02 at 16.03.58.png
37.9 KB View Download

Comment 1 by djean@chromium.org, Oct 3

Owner: djean@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72758d92461e238aa314c1ffb6219eab17daf5ae

commit 72758d92461e238aa314c1ffb6219eab17daf5ae
Author: David Jean <djean@google.com>
Date: Thu Oct 04 07:57:13 2018

[ios] Make “Choose folder” respect dynamic type

Image: https://drive.google.com/open?id=1fxpVgLqHb4-5oUCU1pMVJbGjUhrheQSf
On 10.3.1: https://drive.google.com/open?id=1xaO4Ja8WZbvjRvT1lQXccBkTfBFiECqE

Bug:  891279 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I13ac8525ebc6108f0e2e064c424d7e8762435694
Reviewed-on: https://chromium-review.googlesource.com/c/1257792
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596539}
[modify] https://crrev.com/72758d92461e238aa314c1ffb6219eab17daf5ae/ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.mm

Comment 3 by djean@chromium.org, Oct 5

Status: Fixed (was: Started)

Comment 4 by subhashi...@chromium.org, Oct 9

Status: Verified (was: Fixed)
Verified in:

App Version: 71.0.3574.0 canary
Devices: iPhone 7 Plus, iPhoneX
iOS Versions: 10.3.3, 11.4.1

Bookmarks 'choose Folder' screen respect dynamic type.
Bookmarks_Choose_Folder.jpg
171 KB View Download
►

Sign in to add a comment