New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 891259 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

run_benchmarks could make its required binaries more obvious, or build them

Project Member Reported by leszeks@chromium.org, Oct 2

Issue description

Running tools/perf/run_benchmark, I often hit the case that

a) I don't have the required binary/apk built, or
b) I do have it, but it's stale

Since the benchmark runner already knows my output directory and binary, it could probably figure out if there's a matching output directory without the binary (in which case it could print "please build <target>" as an error), and it could figure out if its binary is stale (e.g. check if "ninja -n <binary>" does anything, and print a warning if yes).

Even better, there could be a --build flag which triggers the build (probably not on by default). That would save me a few helper scripts.
 
Cc: nednguyen@chromium.org
+nednguyen FYI

Sign in to add a comment