See the link to graphs below.
All graphs for this bug: https://chromeperf.appspot.com/group_report?bug_id=891257 (For debugging:) Original alerts at time of bug-filing: https://chromeperf.appspot.com/group_report?sid=7919f0f5da9ee5325c4891c9d1911666292ffe43219fe9973da275e82b9a4b81 Bot(s) for this bug's original alert(s): Win 7 Nvidia GPU Perf memory.desktop - Benchmark documentation link: None
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16d1c23ce40000
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/16d1c23ce40000 [Language] Do not show translation offer prompt when CLD and html/content by frechette@chromium.org https://chromium.googlesource.com/chromium/src/+/530abd79f10af8ec610559457e5dd2d746d74aa1 1.879e+07 → 1.89e+07 (+1.138e+05) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: None
Hypothesis: `LanguageDetectionDetails` is pretty heavy (since it contains the content that is used for CLD). Saving it in the LanguageState (https://chromium-review.googlesource.com/c/chromium/src/+/1221687/17/components/translate/core/browser/language_state.h#103) causes an increase in memory consumption.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89d6f0d7ea7982e72db195523356338171977c49 commit 89d6f0d7ea7982e72db195523356338171977c49 Author: Alexandre Frechette <frechette@chromium.org> Date: Sun Oct 07 21:05:33 2018 Revert "[Language] Do not show translation offer prompt when CLD and html/content" This reverts commit 530abd79f10af8ec610559457e5dd2d746d74aa1. Reason for revert: This CL needs to be reworked. It causes a memory regression (https://bugs.chromium.org/p/chromium/issues/detail?id=891257), and also has badly addressed edge cases (see thread in https://bugs.chromium.org/p/chromium/issues/detail?id=875035, causing bug https://bugs.chromium.org/p/chromium/issues/detail?id=892441). Original change's description: > [Language] Do not show translation offer prompt when CLD and html/content > languages differ. > > There are cases where CLD is wrong, it differs from the HTML or content > languages (signals from the webpage) and we still trust it. In such > situation, we should not actively suggest translation, and simply show > the icon. > > We achieve this by passing the signals that were used during > language detection to the component in charge of showing translation. > > Bug: 875035 > Change-Id: Icbaf6ec19aeffeb246c7af03c18ee75d97fa7eeb > Reviewed-on: https://chromium-review.googlesource.com/1221687 > Reviewed-by: Jonathan Metzman <metzman@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Michael Martis <martis@chromium.org> > Reviewed-by: anthonyvd <anthonyvd@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Alexandre Frechette <frechette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594323} TBR=dcheng@chromium.org,twellington@chromium.org,anthonyvd@chromium.org,martis@chromium.org,metzman@chromium.org,frechette@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 875035, 892441 , 891257 , 892783 Change-Id: I7c839fa96bee25b2a9332b3156f1de622bb47e19 Reviewed-on: https://chromium-review.googlesource.com/c/1263893 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#597467} [modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/chrome/browser/android/contextualsearch/contextual_search_context.cc [modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/content/browser/content_translate_driver.cc [modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/content/common/translate.mojom [modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/content/common/translate_struct_traits.cc [modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/content/common/translate_struct_traits.h [modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/content/renderer/translate_helper.cc [modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/browser/language_state.cc [modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/browser/language_state.h [modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/browser/language_state_unittest.cc [modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/browser/translate_browser_metrics.h [modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/browser/translate_manager.cc [modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/browser/translate_manager_unittest.cc [modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/common/language_detection_details.h [modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/language_detection/language_detection_util.cc [modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/language_detection/language_detection_util.h [modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/language_detection/language_detection_util_unittest.cc [modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/ios/browser/ios_translate_driver.mm [modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/ios/browser/language_detection_controller.mm [modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/testing/libfuzzer/fuzzers/language_detection_fuzzer.cc
Comment 1 by 42576172...@developer.gserviceaccount.com
, Oct 2