New issue
Advanced search Search tips

Issue 891251 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 5
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Serialize header lines in H/1 consistently with other browsers

Project Member Reported by annevank...@gmail.com, Oct 2

Issue description

As discussed in https://github.com/web-platform-tests/wpt/issues/7567 and tested by https://github.com/web-platform-tests/wpt/pull/13317 (xhr/setrequestheader-content-type.htm in particular).

Standardization is https://github.com/httpwg/http-core/issues/137.
 
Cc: -mmenke@chromium.org
Components: -Blink>Network Internals>Network
Owner: mmenke@chromium.org
Status: Assigned (was: Unconfirmed)
Per linked bug, I'll do this.  Hadn't realized this was request headers, rather than response headers, so this should be a completely trivial change (Modulo any other tests it may break)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/444d67b34a8d23e5a21db8c887d201364cf5f3f7

commit 444d67b34a8d23e5a21db8c887d201364cf5f3f7
Author: Matt Menke <mmenke@chromium.org>
Date: Fri Oct 05 22:19:35 2018

Include space after colon on HTTP/1.x headers that are empty strings.

This matches behavior of all other browsers. WPT tests were recently
updated to check for the more common behavior, instead of Chrome's
divergent behavior, so this CL also updates the expectations of a
number of layout tests.

Bug:  891251 
Change-Id: I3b0b091fe52000d1adb597c7fe6491dd3d2371c4
Reviewed-on: https://chromium-review.googlesource.com/c/1256284
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597339}
[modify] https://crrev.com/444d67b34a8d23e5a21db8c887d201364cf5f3f7/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc
[modify] https://crrev.com/444d67b34a8d23e5a21db8c887d201364cf5f3f7/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/444d67b34a8d23e5a21db8c887d201364cf5f3f7/net/http/http_request_headers.cc
[modify] https://crrev.com/444d67b34a8d23e5a21db8c887d201364cf5f3f7/net/http/http_request_headers_unittest.cc
[modify] https://crrev.com/444d67b34a8d23e5a21db8c887d201364cf5f3f7/net/url_request/url_request_ftp_job_unittest.cc
[modify] https://crrev.com/444d67b34a8d23e5a21db8c887d201364cf5f3f7/net/url_request/url_request_http_job_unittest.cc
[modify] https://crrev.com/444d67b34a8d23e5a21db8c887d201364cf5f3f7/net/websockets/websocket_stream_test.cc
[delete] https://crrev.com/bf4ceebf36d04e6e9743017fbbe91d9561f524cb/third_party/WebKit/LayoutTests/external/wpt/xhr/setrequestheader-allow-empty-value-expected.txt
[delete] https://crrev.com/bf4ceebf36d04e6e9743017fbbe91d9561f524cb/third_party/WebKit/LayoutTests/external/wpt/xhr/setrequestheader-allow-whitespace-in-value-expected.txt
[modify] https://crrev.com/444d67b34a8d23e5a21db8c887d201364cf5f3f7/third_party/WebKit/LayoutTests/external/wpt/xhr/setrequestheader-content-type-expected.txt

Status: Fixed (was: Assigned)

Sign in to add a comment