Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of clamy@google.com Builders failed on: - WebKit Mac10.13 (retina): https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29 See first failing build: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29/4561 Will revert https://chromium-review.googlesource.com/c/chromium/src/+/1254341 which modified the tests affected.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46f49dac270620c93c38be3767adb64db95fe225 commit 46f49dac270620c93c38be3767adb64db95fe225 Author: Camille Lamy <clamy@chromium.org> Date: Tue Oct 02 12:12:11 2018 Revert "remove SK_SUPPORT_LEGACY_SVG_ARC_TO" This reverts commit 05ee0393e7a7f04f306be79aa5b8c1f4398344a6. Reason for revert: Sheriff reverting due to several paint-invalidation failing on the bot WebKit Mac 10.13 Retina. See https://crbug.com/891230 Original change's description: > remove SK_SUPPORT_LEGACY_SVG_ARC_TO > > Change-Id: I330bdfe4dcbfed55a03385043e703af6fe070ffd > Reviewed-on: https://chromium-review.googlesource.com/1254341 > Commit-Queue: Mike Reed <reed@chromium.org> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595627} TBR=fmalita@chromium.org,reed@chromium.org Change-Id: Ica1ccdd43953772d40c70d22f3fc399df7dd56b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891230 Reviewed-on: https://chromium-review.googlesource.com/1256825 Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595805} [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/skia/config/SkUserConfig.h [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/relative-sized-inner-svg-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/relative-sized-use-on-symbol-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/relative-sized-use-without-attributes-on-symbol-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/tabgroup-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/paths-data-03-f-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-symbol-inside-pattern-expected.png [delete] https://crrev.com/21cf5dfbb934c0e2227b66568ab1094c5c9fc009/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/svg/relative-sized-inner-svg-expected.png [delete] https://crrev.com/21cf5dfbb934c0e2227b66568ab1094c5c9fc009/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/svg/relative-sized-use-on-symbol-expected.png [delete] https://crrev.com/21cf5dfbb934c0e2227b66568ab1094c5c9fc009/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/svg/relative-sized-use-without-attributes-on-symbol-expected.png [delete] https://crrev.com/21cf5dfbb934c0e2227b66568ab1094c5c9fc009/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/svg/tabgroup-expected.png [delete] https://crrev.com/21cf5dfbb934c0e2227b66568ab1094c5c9fc009/third_party/WebKit/LayoutTests/platform/mac-retina/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png [delete] https://crrev.com/21cf5dfbb934c0e2227b66568ab1094c5c9fc009/third_party/WebKit/LayoutTests/platform/mac-retina/svg/W3C-SVG-1.1/paths-data-03-f-expected.png [delete] https://crrev.com/21cf5dfbb934c0e2227b66568ab1094c5c9fc009/third_party/WebKit/LayoutTests/platform/mac-retina/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png [delete] https://crrev.com/21cf5dfbb934c0e2227b66568ab1094c5c9fc009/third_party/WebKit/LayoutTests/platform/mac-retina/svg/as-image/img-preserveAspectRatio-support-1-expected.png [delete] https://crrev.com/21cf5dfbb934c0e2227b66568ab1094c5c9fc009/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/use-on-symbol-inside-pattern-expected.png [delete] https://crrev.com/21cf5dfbb934c0e2227b66568ab1094c5c9fc009/third_party/WebKit/LayoutTests/platform/mac-retina/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/relative-sized-inner-svg-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/relative-sized-use-on-symbol-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/relative-sized-use-without-attributes-on-symbol-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/tabgroup-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/relative-sized-inner-svg-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/relative-sized-use-on-symbol-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/relative-sized-use-without-attributes-on-symbol-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/tabgroup-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/paths-data-03-f-expected.png [modify] https://crrev.com/46f49dac270620c93c38be3767adb64db95fe225/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-on-symbol-inside-pattern-expected.png
After the revert landed, this bot, and others, have started failing: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20(1)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781 commit a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781 Author: Sorin Jianu <sorin@chromium.org> Date: Tue Oct 02 14:53:44 2018 Reland "remove SK_SUPPORT_LEGACY_SVG_ARC_TO" This reverts commit 46f49dac270620c93c38be3767adb64db95fe225. Reason for revert: reverting the original change breaks other bots, such as https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29 an it does not fix the problem on WebKit Mac 10.13 Retina anyway. Original change's description: > Revert "remove SK_SUPPORT_LEGACY_SVG_ARC_TO" > > This reverts commit 05ee0393e7a7f04f306be79aa5b8c1f4398344a6. > > Reason for revert: Sheriff reverting due to several paint-invalidation failing on the bot WebKit Mac 10.13 Retina. > See https://crbug.com/891230 > > Original change's description: > > remove SK_SUPPORT_LEGACY_SVG_ARC_TO > > > > Change-Id: I330bdfe4dcbfed55a03385043e703af6fe070ffd > > Reviewed-on: https://chromium-review.googlesource.com/1254341 > > Commit-Queue: Mike Reed <reed@chromium.org> > > Reviewed-by: Florin Malita <fmalita@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#595627} > > TBR=fmalita@chromium.org,reed@chromium.org > > Change-Id: Ica1ccdd43953772d40c70d22f3fc399df7dd56b1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 891230 > Reviewed-on: https://chromium-review.googlesource.com/1256825 > Reviewed-by: Camille Lamy <clamy@chromium.org> > Commit-Queue: Camille Lamy <clamy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595805} TBR=fmalita@chromium.org,clamy@chromium.org,reed@chromium.org Change-Id: If0cd979dc3772397f1631d01efc8e08911ecd98c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891230 Reviewed-on: https://chromium-review.googlesource.com/1256375 Reviewed-by: Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595834} [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/skia/config/SkUserConfig.h [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/relative-sized-inner-svg-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/relative-sized-use-on-symbol-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/relative-sized-use-without-attributes-on-symbol-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/tabgroup-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/paths-data-03-f-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-symbol-inside-pattern-expected.png [add] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/svg/relative-sized-inner-svg-expected.png [add] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/svg/relative-sized-use-on-symbol-expected.png [add] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/svg/relative-sized-use-without-attributes-on-symbol-expected.png [add] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/svg/tabgroup-expected.png [add] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac-retina/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png [add] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac-retina/svg/W3C-SVG-1.1/paths-data-03-f-expected.png [add] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac-retina/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png [add] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac-retina/svg/as-image/img-preserveAspectRatio-support-1-expected.png [add] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/use-on-symbol-inside-pattern-expected.png [add] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac-retina/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/relative-sized-inner-svg-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/relative-sized-use-on-symbol-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/relative-sized-use-without-attributes-on-symbol-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/tabgroup-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/relative-sized-inner-svg-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/relative-sized-use-on-symbol-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/relative-sized-use-without-attributes-on-symbol-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/tabgroup-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/paths-data-03-f-expected.png [modify] https://crrev.com/a4bd67dfdf48e430f18c871e9dfa9dfaeda3b781/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-on-symbol-inside-pattern-expected.png
I'll look at rebaselining Mac10.13 (retina), please don't revert again.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3401067af0c54c7a933c35b9383c849ccc14844e commit 3401067af0c54c7a933c35b9383c849ccc14844e Author: Florin Malita <fmalita@chromium.org> Date: Tue Oct 02 16:17:53 2018 Rebaseline Retina layout tests after 05ee0393e7a7f04f306be79aa5b8c1f4398344a6 Manual rebaseline for some layout tests left in a bad state after https://chromium-review.googlesource.com/c/chromium/src/+/1254341. TBR=reed Bug: 891230 Change-Id: I8e2c43c972d63f1d3eeb44ecbcaeffea2242fb34 Reviewed-on: https://chromium-review.googlesource.com/1256085 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#595865} [modify] https://crrev.com/3401067af0c54c7a933c35b9383c849ccc14844e/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/svg/relative-sized-inner-svg-expected.png [modify] https://crrev.com/3401067af0c54c7a933c35b9383c849ccc14844e/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/svg/relative-sized-use-on-symbol-expected.png [modify] https://crrev.com/3401067af0c54c7a933c35b9383c849ccc14844e/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/svg/relative-sized-use-without-attributes-on-symbol-expected.png [modify] https://crrev.com/3401067af0c54c7a933c35b9383c849ccc14844e/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/svg/tabgroup-expected.png [modify] https://crrev.com/3401067af0c54c7a933c35b9383c849ccc14844e/third_party/WebKit/LayoutTests/platform/mac-retina/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png [modify] https://crrev.com/3401067af0c54c7a933c35b9383c849ccc14844e/third_party/WebKit/LayoutTests/platform/mac-retina/svg/W3C-SVG-1.1/paths-data-03-f-expected.png [modify] https://crrev.com/3401067af0c54c7a933c35b9383c849ccc14844e/third_party/WebKit/LayoutTests/platform/mac-retina/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png [modify] https://crrev.com/3401067af0c54c7a933c35b9383c849ccc14844e/third_party/WebKit/LayoutTests/platform/mac-retina/svg/as-image/img-preserveAspectRatio-support-1-expected.png [modify] https://crrev.com/3401067af0c54c7a933c35b9383c849ccc14844e/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/use-on-symbol-inside-pattern-expected.png [modify] https://crrev.com/3401067af0c54c7a933c35b9383c849ccc14844e/third_party/WebKit/LayoutTests/platform/mac-retina/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png
WebKit Mac10.13 (retina) turned green: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29/4623
Comment 1 by bugdroid1@chromium.org
, Oct 2