[ozone/wayland]: Wayland keyboard: pressing key may crash on PerformanceTiming::FirstInputDelay assert |
||||
Issue descriptionChrome Version: ToT #595755 What steps will reproduce the problem? (1) Open https://www.youtube.com/tv (2) Wait to show video previews. (3) Press down key. What is the expected result? Navigate down. What happens instead? It crashes with an assert: [1:1:1002/100607.129760:FATAL:performance_timing.cc(52)] Check failed: duration >= TimeDelta() (-864417 s vs. 0 s) #0 0x7efc7aa3a39d base::debug::StackTrace::StackTrace() #1 0x7efc7a71c06a base::debug::StackTrace::StackTrace() #2 0x7efc7a74b50b logging::LogMessage::~LogMessage() #3 0x7efc5d61a9ed blink::ToIntegerMilliseconds() #4 0x7efc5d61a917 blink::PerformanceTiming::FirstInputDelay() #5 0x7efc5c8c67b5 blink::WebPerformance::FirstInputDelay() #6 0x56043282e998 page_load_metrics::MetricsRenderFrameObserver::GetTiming() #7 0x56043282afc6 page_load_metrics::MetricsRenderFrameObserver::SendMetrics() #8 0x56043282af15 page_load_metrics::MetricsRenderFrameObserver::DidChangePerformanceTiming() #9 0x7efc757f8876 content::RenderFrameImpl::DidChangePerformanceTiming() #10 0x7efc5c8a7241 blink::LocalFrameClientImpl::DidChangePerformanceTiming() #11 0x7efc5d23325e blink::DocumentLoader::DidChangePerformanceTiming() #12 0x7efc5d25d433 blink::InteractiveDetector::HandleForInputDelay() #13 0x7efc5d30b85e blink::PageWidgetDelegate::HandleInputEvent() #14 0x7efc5c914ee4 blink::WebViewImpl::HandleInputEvent() #15 0x7efc5caa665c blink::WebViewFrameWidget::HandleInputEvent() #16 0x7efc7551e91d content::RenderWidgetInputHandler::HandleInputEvent() #17 0x7efc7583f76c content::RenderWidget::HandleInputEvent()
,
Oct 2
,
Oct 2
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e21369e1f9d9aa69e36270a28f60778bf9012bbc commit e21369e1f9d9aa69e36270a28f60778bf9012bbc Author: Jose Dapena Paz <jose.dapena@lge.com> Date: Tue Oct 02 11:09:46 2018 [ozone/wayland] Fix wayland keyboard event timestamps On using keyboard with Wayland, we get performance timing asserts. It is caused by inconsistency in how we generate the timestamps from the native events. This replicates the reasoning of Windows EventTimeFromMSG, as the problem is the same. For platform independent events we use TimeTicks::Now, but for native events we use a different time origin. So let's use for keyboard also EventTimeForNow(). Bug: 891205 Change-Id: Iaf1c2e106ea39c7ea3fc6da5c5ab647109f87c7a Reviewed-on: https://chromium-review.googlesource.com/1256569 Reviewed-by: Maksim Sisov <msisov@igalia.com> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#595790} [modify] https://crrev.com/e21369e1f9d9aa69e36270a28f60778bf9012bbc/ui/ozone/platform/wayland/wayland_keyboard.cc
,
Oct 2
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jose.dap...@lge.com
, Oct 2