Reading List background text isn't correctly displayed with large font |
|||||
Issue descriptionWith large fonts. What steps will reproduce the problem? (1) Make sure there is no item in ReadingList (2) Open ReadingList What is the expected result? The background text should be readable. What happens instead? Text is overlapping.
,
Oct 8
Taking that
,
Oct 8
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a1c8cff1487d7a5f073ed7eeef658a7b5e03961 commit 8a1c8cff1487d7a5f073ed7eeef658a7b5e03961 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Oct 09 08:35:02 2018 [iOS] Change empty ReadingList line spacing This CL makes sure that the line spacing of the empty ReadingList's message isn't negative up when the font size increase. Bug: 891198 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I29957d54e2a0e334e14413737d79e0365af3a450 Reviewed-on: https://chromium-review.googlesource.com/c/1267995 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#597840} [modify] https://crrev.com/8a1c8cff1487d7a5f073ed7eeef658a7b5e03961/ios/chrome/browser/ui/reading_list/empty_reading_list_message_util.mm
,
Oct 9
,
Oct 17
Verified in 72.0.3582.0 Canary in iPhone X(iOS 11.4.1), iPhone 8plus(iOS 12.1 Beta) Text is no more overlapping with large font, Looks good Link to screenshot: https://drive.google.com/file/d/1Ry9_59jz74aroUniyArVO5fEZrzj35RY/view?usp=sharing
,
Oct 17
Verified the issue on the build version 71.0.3578.8 beta tested on the device iPhone7+(iOS 12). Text is no more overlapping with large font, Looks good |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by gambard@chromium.org
, Oct 2