New issue
Advanced search Search tips

Issue 891195 link

Starred by 1 user
Status: Fixed
Owner:
moh...@chromium.org
Closed: Oct 9
Cc:
omrilio@chromium.org
afakhry@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Pull-to-refresh gesture does not work reliably

Project Member Reported by omrilio@chromium.org, Oct 2 
Chrome Version: 71.3558.0

What steps will reproduce the problem?
(1) Set flag #pull-to-refresh to Touchscreen
(2) Try to go to a site (e.g. chrome://flags or Google search)
(3) Try swiping from the top but not actually refreshing and releasing
(4) Try doing that again

What is the expected result?
Able to consistently swipe down to trigger the refresh UI

What happens instead?
Only happens the first time reliably


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by moh...@chromium.org, Oct 4

Cc: omrilio@chromium.org
Status: Started (was: Assigned)
I can't repro this on a newly opened tab, but if the content is scrolled once, then I'm able to repro. I'm pretty sure that's related to the "cool-off period"; i.e., after a successful page scroll pull-to-refresh would not start until 600ms is passed after the last successful scroll. I will take a deeper look...
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f43c2c528d409dba408c050f7131a58b331b145

commit 8f43c2c528d409dba408c050f7131a58b331b145
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Tue Oct 09 17:17:11 2018

Fix pull-to-refresh cool off period

Cool off period is the time after a successful scroll that
pull-to-refresh cannot be initiated. That's to prevent pull-to-refresh
when user is repeatedly scrolling up to reach the top of a page. After
cool off period has passed, user should be able to initiate
pull-to-refresh, however, state is not reset properly, and if you start
a pull-to-refresh and abort it, it acts like you have done a successful
page scroll and does not allow you to start pull-to-refresh until cool
off period is passed again.

BUG= 891195 
TEST=content_unittests --gtest_filter=OverscrollControllerTest.*

Change-Id: I2e2c113f5f489556aefa086dab7c66ddaa00f110
Reviewed-on: https://chromium-review.googlesource.com/c/1265117
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597964}
[modify] https://crrev.com/8f43c2c528d409dba408c050f7131a58b331b145/content/browser/renderer_host/overscroll_controller.cc
[modify] https://crrev.com/8f43c2c528d409dba408c050f7131a58b331b145/content/browser/renderer_host/overscroll_controller_unittest.cc

Comment 3 by moh...@chromium.org, Oct 9

Status: Fixed (was: Started)
►

Sign in to add a comment