New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 891188 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 820047



Sign in to add a comment

[ozone/wayland] the contents are not properly updated on weston.

Project Member Reported by msi...@igalia.com, Oct 2

Issue description

When the Ozone/Wayland is running on Weston, the contents are not properly 
updated and the browser flickers instead.

The problem happens when a damage region is not supplied.
To fix the problem, one must use the size of the buffer to make a compositor update a surface with new contents.
 
Blocking: 820047
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec8e0059e3f47cac7d2415b3a28e570f95f2ca95

commit ec8e0059e3f47cac7d2415b3a28e570f95f2ca95
Author: Maksim Sisov <msisov@igalia.com>
Date: Tue Oct 02 09:36:57 2018

[ozone/wayland] Fix flickering problems with Weston.

The wl_surface_damage method was used in a wrong manner -
if a damage region is not supplied, the wl_surface_damage
still must be provided with the width and the height of the buffer
to update the surface with a new content.

This happens when partial swap is disabled and there is no damage
region provided.

What is more, instead of using wl_surface_damage, start using
wl_surface_damage_buffer, as long as the damage region corresponds
more to the buffer region contents rather than the surface itself
(and which is claimed to be a better approach by the Wayland
documentation)

Bug:  891188 
Change-Id: Iff3a4eb50eae1a113818ef7881b6529b906f4820
Reviewed-on: https://chromium-review.googlesource.com/1255635
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#595775}
[modify] https://crrev.com/ec8e0059e3f47cac7d2415b3a28e570f95f2ca95/ui/ozone/platform/wayland/wayland_buffer_manager.cc
[modify] https://crrev.com/ec8e0059e3f47cac7d2415b3a28e570f95f2ca95/ui/ozone/platform/wayland/wayland_buffer_manager.h

Status: Fixed (was: Untriaged)

Sign in to add a comment